fix: remove extra if statement when checking if a message is an interactionNotification

pull/2789/head
William Grant 2 years ago
parent ede5fd8558
commit 77bdceb409

@ -1381,34 +1381,32 @@ export class MessageModel extends Backbone.Model<MessageAttributes> {
} }
} }
if (this.get('interactionNotification')) { const interactionNotification = this.get('interactionNotification');
const interactionNotification = this.get('interactionNotification'); if (interactionNotification) {
if (interactionNotification) { const { interactionType, interactionStatus } = interactionNotification;
const { interactionType, interactionStatus } = interactionNotification;
// NOTE For now we only show interaction errors in the message history
// NOTE For now we only show interaction errors in the message history if (interactionStatus === ConversationInteractionStatus.Error) {
if (interactionStatus === ConversationInteractionStatus.Error) { const convo = getConversationController().get(this.get('conversationId'));
const convo = getConversationController().get(this.get('conversationId'));
if (convo) {
if (convo) { const isGroup = !convo.isPrivate();
const isGroup = !convo.isPrivate(); const isCommunity = convo.isPublic();
const isCommunity = convo.isPublic();
switch (interactionType) {
switch (interactionType) { case ConversationInteractionType.Hide:
case ConversationInteractionType.Hide: return window.i18n('hideConversationFailed');
return window.i18n('hideConversationFailed'); case ConversationInteractionType.Leave:
case ConversationInteractionType.Leave: return isCommunity
return isCommunity ? window.i18n('leaveCommunityFailed')
? window.i18n('leaveCommunityFailed') : isGroup
: isGroup ? window.i18n('leaveGroupFailed')
? window.i18n('leaveGroupFailed') : window.i18n('deleteConversationFailed');
: window.i18n('deleteConversationFailed'); default:
default: assertUnreachable(
assertUnreachable( interactionType,
interactionType, `Message.getDescription: Missing case error "${interactionType}"`
`Message.getDescription: Missing case error "${interactionType}"` );
);
}
} }
} }
} }

Loading…
Cancel
Save