start in tray setting directly creates the tray icon

app/tray_icon.js

@@ -1,6 +1,5 @@
 const path = require('path');
 
-const fs = require('fs');
 const { app, Menu, Tray } = require('electron');
 
 let trayContextMenu = null;
@@ -70,16 +69,6 @@ function createTrayIcon(getMainWindow, messages) {
     tray.setContextMenu(trayContextMenu);
   };
 
-  tray.updateIcon = () => {
-    const image = iconNoNewMessages;
-
-    if (!fs.existsSync(image)) {
-      console.log('tray.updateIcon: Image for tray update does not exist!');
-      return;
-    }
-    tray.setImage(image);
-  };
-
   tray.on('click', tray.showWindow);
 
   tray.setToolTip(messages.sessionMessenger);

main.js

@@ -876,12 +876,6 @@ ipc.on('close-about', () => {
   }
 });
 
-ipc.on('update-tray-icon', (event, unreadCount) => {
-  if (tray) {
-    tray.updateIcon(unreadCount);
-  }
-});
-
 // Password screen related IPC calls
 ipc.on('password-window-login', async (event, passPhrase) => {
   const sendResponse = e => event.sender.send('password-window-login-response', e);
@@ -898,6 +892,17 @@ ipc.on('password-window-login', async (event, passPhrase) => {
 ipc.on('start-in-tray-on-start', async (event, newValue) => {
   try {
     userConfig.set('startInTray', newValue);
+
+    if (newValue) {
+      if (!tray) {
+        tray = createTrayIcon(getMainWindow, locale.messages);
+      }
+    } else {
+      if (tray) {
+        tray.destroy();
+      }
+      tray = null;
+    }
     event.sender.send('start-in-tray-on-start-response', null);
   } catch (e) {
     event.sender.send('start-in-tray-on-start-response', e);

preload.js

@@ -179,8 +179,6 @@ ipc.on('mediaPermissionsChanged', () => {
 window.closeAbout = () => ipc.send('close-about');
 window.readyForUpdates = () => ipc.send('ready-for-updates');
 
-window.updateTrayIcon = unreadCount => ipc.send('update-tray-icon', unreadCount);
-
 ipc.on('get-theme-setting', () => {
   const theme = window.Events.getThemeSetting();
   ipc.send('get-success-theme-setting', theme);

ts/components/conversation/AddMentions.tsx

@@ -48,7 +48,7 @@ export class AddMentions extends React.Component<Props> {
     const results: Array<any> = [];
     const FIND_MENTIONS = new RegExp(`@${PubKey.regexForPubkeys}`, 'g');
 
-    // We have to do this, because renderNonNewLine is not required in our Props object,
+    // We have to do this, because renderOther is not required in our Props object,
     //  but it is always provided via defaultProps.
     if (!renderOther) {
       return;

ts/components/session/settings/SessionSettings.tsx

@@ -382,7 +382,6 @@ class SettingsViewInner extends React.Component<SettingsViewProps, State> {
           await window.setStartInTray(newValue);
           // make sure to write it here too, as this is the value used on the UI to mark the toggle as true/false
           window.setSettingValue('start-in-tray-setting', newValue);
-          ToastUtils.pushRestartNeeded();
         },
         content: undefined,
         comparisonValue: undefined,