feat: made sure to clear attachment properties after deletion

confirmed everything works through testing

ts/types/MessageAttachment.ts

@@ -28,16 +28,16 @@ export const deleteExternalMessageFiles = async (message: {
 
   if (attachments && attachments.length) {
     await Promise.all(attachments.map(deleteData));
-    // testing that the files were successfully deleted
+    // test that the files were deleted successfully
     try {
       await Promise.all(
         attachments.map(async (attachment: { path: string; thumbnail: any; screenshot: any }) => {
           await readAttachmentData(attachment.path);
         })
       );
-      window.log.info(`WIP: failed in deleting files`);
+      window.log.info('[deleteExternalMessageFiles]: Failed to delete attachments for', message);
     } catch (err) {
-      window.log.info(`WIP: succeeded in deleting files`, err);
+      // If we fail to read the path then we know we deleted successfully
     }
   }
 
@@ -52,6 +52,9 @@ export const deleteExternalMessageFiles = async (message: {
         if (thumbnail && thumbnail.path && !thumbnail.copied) {
           await deleteOnDisk(thumbnail.path);
         }
+
+        attachment.thumbnail = undefined;
+        return attachment;
       })
     );
   }
@@ -64,6 +67,9 @@ export const deleteExternalMessageFiles = async (message: {
         if (image && image.path) {
           await deleteOnDisk(image.path);
         }
+
+        item.image = undefined;
+        return image;
       })
     );
   }

ts/types/attachments/migrations.ts

@@ -145,7 +145,6 @@ export const loadData = async (attachment: any) => {
 //      deleteData :: (RelativePath -> IO Unit)
 //                    Attachment ->
 //                    IO Unit
-// NOTE Flattening this function seemed to have worked
 export const deleteData = async (attachment: { path: string; thumbnail: any; screenshot: any }) => {
   if (!isValid(attachment)) {
     throw new TypeError('deleteData: attachment is not valid');
@@ -155,15 +154,20 @@ export const deleteData = async (attachment: { path: string; thumbnail: any; scr
 
   if (isString(path)) {
     await deleteOnDisk(path);
+    attachment.path = '';
   }
 
   if (thumbnail && isString(thumbnail.path)) {
     await deleteOnDisk(thumbnail.path);
+    attachment.thumbnail = undefined;
   }
 
   if (screenshot && isString(screenshot.path)) {
     await deleteOnDisk(screenshot.path);
+    attachment.screenshot = undefined;
   }
+
+  return attachment;
 };
 
 type CaptureDimensionType = { contentType: string; path: string };