Conversation: store lastMessage/lastMessageStatus in memory only

js/models/conversations.js

@@ -135,6 +135,8 @@
       this.on('read', this.updateLastMessage);
       this.on('sent', this.updateLastMessage);
       this.on('expired', this.onExpired);
+
+      this.updateLastMessage();
     },
 
     isMe() {
@@ -198,8 +200,8 @@
         isSelected: this.isSelected,
 
         lastMessage: {
-          status: this.get('lastMessageStatus'),
+          status: this.lastMessageStatus,
-          text: this.get('lastMessage'),
+          text: this.lastMessage,
         },
 
         onClick: () => this.trigger('select', this),
@@ -899,6 +901,10 @@
     },
 
     async updateLastMessage() {
+      if (!this.id) {
+        return;
+      }
+
       const messages = await window.Signal.Data.getMessagesByConversation(
         this.id,
         { limit: 1, MessageCollection: Whisper.MessageCollection }
@@ -907,26 +913,41 @@
         return;
       }
 
-      const lastMessage = messages.at(0);
+      const lastMessageModel = messages.at(0);
 
-      const lastMessageJSON = lastMessage ? lastMessage.toJSON() : null;
+      const lastMessageJSON = lastMessageModel
-      const lastMessageStatus = lastMessage
+        ? lastMessageModel.toJSON()
-        ? lastMessage.getMessagePropStatus()
+        : null;
+      const lastMessageStatusModel = lastMessageModel
+        ? lastMessageModel.getMessagePropStatus()
         : null;
       const lastMessageUpdate = Conversation.createLastMessageUpdate({
         currentLastMessageText: this.get('lastMessage') || null,
         currentTimestamp: this.get('timestamp') || null,
         lastMessage: lastMessageJSON,
-        lastMessageStatus,
+        lastMessageStatus: lastMessageStatusModel,
-        lastMessageNotificationText: lastMessage
+        lastMessageNotificationText: lastMessageModel
-          ? lastMessage.getNotificationText()
+          ? lastMessageModel.getNotificationText()
           : null,
       });
 
+      let hasChanged = false;
+      const { lastMessage, lastMessageStatus } = lastMessageUpdate;
+      lastMessageUpdate.lastMessage = null;
+      lastMessageUpdate.lastMessageStatus = null;
+
+      hasChanged = hasChanged || lastMessage !== this.lastMessage;
+      this.lastMessage = lastMessage;
+
+      hasChanged = hasChanged || lastMessageStatus !== this.lastMessageStatus;
+      this.lastMessageStatus = lastMessageStatus;
+
       this.set(lastMessageUpdate);
 
-      if (this.hasChanged('lastMessage') || this.hasChanged('timestamp')) {
+      if (this.hasChanged()) {
         this.save();
+      } else if (hasChanged) {
+        this.trigger('change');
       }
     },
 

js/views/conversation_list_item_view.js

@@ -15,7 +15,6 @@
     templateName: 'conversation-preview',
     initialize() {
       this.listenTo(this.model, 'destroy', this.remove);
-      this.model.updateLastMessage();
     },
 
     remove() {

test/_test.js

@@ -60,25 +60,26 @@ function hexToArrayBuffer(str) {
   return ret;
 }
 
-/* Delete the database before running any tests */
+function deleteDatabase() {
-before(function(done) {
+  return new Promise((resolve, reject) => {
     var idbReq = indexedDB.deleteDatabase('test');
-  idbReq.onsuccess = function() {
+    idbReq.onsuccess = resolve;
-    done();
+    idbReq.error = reject;
-  };
   });
+}
+
+/* Delete the database before running any tests */
+before(async () => {
+  await deleteDatabase();
 
-async function clearDatabase() {
   await Signal.Migrations.Migrations0DatabaseWithAttachmentData.run({
     Backbone,
     databaseName: Whisper.Database.id,
     logger: window.log,
   });
+});
 
-  const convos = new Whisper.ConversationCollection();
+async function clearDatabase() {
-  await wrapDeferred(convos.fetch());
+  const db = await Whisper.Database.open();
-  await wrapDeferred(convos.destroyAll());
+  await Whisper.Database.clear();
-  const messages = new Whisper.MessageCollection();
-  await wrapDeferred(messages.fetch());
-  await wrapDeferred(messages.destroyAll());
 }

test/fixtures_test.js

@@ -1,23 +1,19 @@
 'use strict';
 
 describe('Fixtures', function() {
-  before(function(done) {
+  before(function() {
     // NetworkStatusView checks this method every five seconds while showing
     window.getSocketStatus = function() {
       return WebSocket.OPEN;
     };
-
-    Whisper.Fixtures()
-      .saveAll()
-      .then(function() {
-        done();
-      });
   });
 
-  it('renders', function(done) {
+  it('renders', async () => {
+    await Whisper.Fixtures().saveAll();
+
     ConversationController.reset();
-    ConversationController.load()
+    await ConversationController.load();
-      .then(function() {
+
     var view = new Whisper.InboxView({ window: window });
     view.onEmpty();
     view.$el.prependTo($('#render-light-theme'));
@@ -26,7 +22,5 @@ describe('Fixtures', function() {
     view.$el.removeClass('light-theme').addClass('dark-theme');
     view.onEmpty();
     view.$el.prependTo($('#render-dark-theme'));
-      })
-      .then(done, done);
   });
 });

test/models/conversations_test.js

@@ -36,16 +36,16 @@
         .then(done);
     });
 
-    it('fetches persistent convos', function(done) {
+    it('fetches persistent convos', async () => {
       var convos = new Whisper.ConversationCollection();
       assert.strictEqual(convos.length, 0);
-      convos.fetch().then(function() {
+
+      await wrapDeferred(convos.fetch());
+
       var m = convos.at(0).attributes;
       _.each(conversation_attributes, function(val, key) {
         assert.deepEqual(m[key], val);
       });
-        done();
-      });
     });
 
     it('destroys persistent convos', function(done) {
@@ -226,14 +226,18 @@
   });
 
   describe('Conversation search', function() {
-    var convo = new Whisper.ConversationCollection().add({
+    let convo;
+
+    beforeEach(function(done) {
+      convo = new Whisper.ConversationCollection().add({
         id: '+14155555555',
         type: 'private',
         name: 'John Doe',
       });
-    before(function(done) {
       convo.save().then(done);
     });
+    afterEach(clearDatabase);
+
     function testSearch(queries, done) {
       return Promise.all(
         queries.map(function(query) {

test/views/attachment_view_test.js

@@ -9,6 +9,7 @@ describe('AttachmentView', () => {
 
   before(async () => {
     await clearDatabase();
+
     convo = new Whisper.Conversation({ id: 'foo' });
     message = convo.messageCollection.add({
       conversationId: convo.id,

test/views/conversation_search_view_test.js

@@ -24,20 +24,26 @@ describe('ConversationSearchView', function() {
     });
   });
   describe('Searching for left groups', function() {
-    var convo = new Whisper.ConversationCollection().add({
+    let convo;
+
+    before(() => {
+      convo = new Whisper.ConversationCollection().add({
         id: 'a-left-group',
         name: 'i left this group',
         members: [],
         type: 'group',
         left: true,
       });
-    before(() => {
+
       return wrapDeferred(convo.save());
     });
     describe('with no messages', function() {
-      var input = $('<input>');
+      var input;
-      var view = new Whisper.ConversationSearchView({ input: input }).render();
+      var view;
+
       before(function(done) {
+        input = $('<input>');
+        view = new Whisper.ConversationSearchView({ input: input }).render();
         view.$input.val('left');
         view.filterContacts();
         view.typeahead_view.collection.on('reset', function() {
@@ -52,9 +58,11 @@ describe('ConversationSearchView', function() {
       });
     });
     describe('with messages', function() {
-      var input = $('<input>');
+      var input;
-      var view = new Whisper.ConversationSearchView({ input: input }).render();
+      var view;
       before(function(done) {
+        input = $('<input>');
+        view = new Whisper.ConversationSearchView({ input: input }).render();
         convo.save({ lastMessage: 'asdf' }).then(function() {
           view.$input.val('left');
           view.filterContacts();
@@ -72,17 +80,22 @@ describe('ConversationSearchView', function() {
     });
   });
   describe('Showing all contacts', function() {
-    var input = $('<input>');
+    let input;
-    var view = new Whisper.ConversationSearchView({ input: input }).render();
+    let view;
+    let convo;
+
+    before(() => {
+      input = $('<input>');
+      view = new Whisper.ConversationSearchView({ input: input }).render();
       view.showAllContacts = true;
-    var convo = new Whisper.ConversationCollection().add({
+      convo = new Whisper.ConversationCollection().add({
         id: 'a-left-group',
         name: 'i left this group',
         members: [],
         type: 'group',
         left: true,
       });
-    before(() => {
+
       return wrapDeferred(convo.save());
     });
     describe('with no messages', function() {

test/views/inbox_view_test.js

@@ -1,11 +1,19 @@
 describe('InboxView', function() {
-  var inboxView = new Whisper.InboxView({
+  let inboxView;
+  let conversation;
+
+  before(() => {
+    inboxView = new Whisper.InboxView({
       model: {},
       window: window,
       initialLoadComplete: function() {},
     }).render();
 
-  var conversation = new Whisper.Conversation({ id: '1234', type: 'private' });
+    conversation = new Whisper.Conversation({
+      id: '1234',
+      type: 'private',
+    });
+  });
 
   describe('the conversation stack', function() {
     it('should be rendered', function() {