Remove returning models from block/unblock.

lint fixes.
pull/47/head
Mikunj 7 years ago
parent a3a7f4a621
commit 5f4a44ba8c

@ -47,29 +47,25 @@
// Make sure we don't block ourselves // Make sure we don't block ourselves
if (ourNumber === number) { if (ourNumber === number) {
window.log.info('BlockedNumberController: Cannot block yourself!'); window.log.info('BlockedNumberController: Cannot block yourself!');
return null; return;
} }
storage.addBlockedNumber(number); storage.addBlockedNumber(number);
// Make sure we don't add duplicates // Make sure we don't add duplicates
const exists = blockedNumbers.getNumber(number); if (blockedNumbers.getNumber(number))
if (exists) return;
return exists;
return blockedNumbers.add({ number }); blockedNumbers.add({ number });
}, },
unblock(number) { unblock(number) {
storage.removeBlockedNumber(number); storage.removeBlockedNumber(number);
// Make sure we don't add duplicates // Make sure we don't add duplicates
const exists = blockedNumbers.getNumber(number); const model = blockedNumbers.getNumber(number);
if (exists) { if (model) {
blockedNumbers.remove(exists); blockedNumbers.remove(model);
return exists;
} }
return null;
}, },
unblockAll() { unblockAll() {
const all = blockedNumbers.models; const all = blockedNumbers.models;

@ -77,8 +77,9 @@ window.setMediaPermissions = enabled =>
ipc.send('set-media-permissions', enabled); ipc.send('set-media-permissions', enabled);
window.getMediaPermissions = () => ipc.sendSync('get-media-permissions'); window.getMediaPermissions = () => ipc.sendSync('get-media-permissions');
// Events for updating block number states across different windows // Events for updating block number states across different windows.
// In this case we need these to update the blocked number collection on the main window from the settings window // In this case we need these to update the blocked number
// collection on the main window from the settings window.
window.onUnblockNumber = number => ipc.send('on-unblock-number', number); window.onUnblockNumber = number => ipc.send('on-unblock-number', number);
ipc.on('on-unblock-number', (event, number) => { ipc.on('on-unblock-number', (event, number) => {

@ -26,8 +26,9 @@ window.getAppInstance = () => config.appInstance;
window.closeSettings = () => ipcRenderer.send('close-settings'); window.closeSettings = () => ipcRenderer.send('close-settings');
// Events for updating block number states across different windows // Events for updating block number states across different windows.
// In this case we need these to update the blocked number collection on the main window from the settings window // In this case we need these to update the blocked number
// collection on the main window from the settings window.
window.onUnblockNumber = number => ipcRenderer.send('on-unblock-number', number); window.onUnblockNumber = number => ipcRenderer.send('on-unblock-number', number);
window.getDeviceName = makeGetter('device-name'); window.getDeviceName = makeGetter('device-name');

Loading…
Cancel
Save