Use `while` loop for IDB cursor iteration

Previously, I messily combined promises and callbacks because I thought we
were affected by the microtask issue:
https://github.com/gasi/idb#iteratecursor--iteratekeycursor

ESLint’s `more/no-then` encouraged me to revisit this and it works as expected.
pull/1/head
Daniel Gasienica 8 years ago
parent a76a6098c4
commit 5d927b73e6

@ -16,24 +16,24 @@ exports.run = async (transaction) => {
await db.transaction.complete; await db.transaction.complete;
}; };
exports._initializeMessageSchemaVersion = messagesStore => // NOTE: We disable `no-await-in-loop` because we want this migration to happen
new Promise((resolve, reject) => { // in sequence and not in parallel:
messagesStore.openCursor().then(async function cursorIterate(cursor) { // https://eslint.org/docs/rules/no-await-in-loop#when-not-to-use-it
const hasMoreResults = Boolean(cursor); exports._initializeMessageSchemaVersion = async (messagesStore) => {
if (!hasMoreResults) { let cursor = await messagesStore.openCursor();
return resolve(); while (cursor) {
} const message = cursor.value;
console.log('Initialize schema version for message:', message.id);
const message = cursor.value;
console.log('Initialize schema version for message:', message.id); const messageWithSchemaVersion = Message.initializeSchemaVersion(message);
try {
const messageWithInitializedSchemaVersion = Message.initializeSchemaVersion(message); // eslint-disable-next-line no-await-in-loop
try { await messagesStore.put(messageWithSchemaVersion, message.id);
await messagesStore.put(messageWithInitializedSchemaVersion, message.id); } catch (error) {
} catch (error) { console.log('Failed to put message with initialized schema version:', message.id);
console.log('Failed to put message with initialized schema version:', message.id); }
}
// eslint-disable-next-line no-await-in-loop
cursor.continue().then(cursorIterate); cursor = await cursor.continue();
}).catch(reject); }
}); };

Loading…
Cancel
Save