refactor: providedexpirationtype to provideddisappearingmode

pull/2971/head
William Grant 2 years ago
parent 029db2d73f
commit 38a8012e10

@ -383,13 +383,13 @@ export async function setDisappearingMessagesByConvoId(
if (!expirationMode || expirationMode === 'off' || !seconds || seconds <= 0) { if (!expirationMode || expirationMode === 'off' || !seconds || seconds <= 0) {
await conversation.updateExpireTimer({ await conversation.updateExpireTimer({
providedExpirationType: 'off', providedDisappearingMode: 'off',
providedExpireTimer: 0, providedExpireTimer: 0,
providedChangeTimestamp, providedChangeTimestamp,
}); });
} else { } else {
await conversation.updateExpireTimer({ await conversation.updateExpireTimer({
providedExpirationType: expirationMode, providedDisappearingMode: expirationMode,
providedExpireTimer: seconds, providedExpireTimer: seconds,
providedChangeTimestamp, providedChangeTimestamp,
}); });

@ -802,7 +802,7 @@ export class ConversationModel extends Backbone.Model<ConversationAttributes> {
// tslint:disable: cyclomatic-complexity // tslint:disable: cyclomatic-complexity
public async updateExpireTimer({ public async updateExpireTimer({
providedExpirationType, providedDisappearingMode,
providedExpireTimer, providedExpireTimer,
providedChangeTimestamp, providedChangeTimestamp,
providedSource, providedSource,
@ -811,7 +811,7 @@ export class ConversationModel extends Backbone.Model<ConversationAttributes> {
shouldCommit = true, shouldCommit = true,
existingMessage, existingMessage,
}: { }: {
providedExpirationType?: DisappearingMessageConversationModeType; providedDisappearingMode?: DisappearingMessageConversationModeType;
providedExpireTimer?: number; providedExpireTimer?: number;
providedChangeTimestamp: number; providedChangeTimestamp: number;
providedSource?: string; providedSource?: string;
@ -824,7 +824,7 @@ export class ConversationModel extends Backbone.Model<ConversationAttributes> {
window.log.warn("updateExpireTimer() Disappearing messages aren't supported in communities"); window.log.warn("updateExpireTimer() Disappearing messages aren't supported in communities");
return; return;
} }
let expirationMode = providedExpirationType; let expirationMode = providedDisappearingMode;
let expireTimer = providedExpireTimer; let expireTimer = providedExpireTimer;
const lastDisappearingMessageChangeTimestamp = providedChangeTimestamp; const lastDisappearingMessageChangeTimestamp = providedChangeTimestamp;
const source = providedSource || UserUtils.getOurPubKeyStrFromCache(); const source = providedSource || UserUtils.getOurPubKeyStrFromCache();

@ -318,7 +318,7 @@ export async function handleNewClosedGroup(
// TODO This is only applicable for old closed groups - will be removed in future // TODO This is only applicable for old closed groups - will be removed in future
await groupConvo.updateExpireTimer({ await groupConvo.updateExpireTimer({
providedExpirationType: expireTimer === 0 ? 'off' : 'deleteAfterSend', providedDisappearingMode: expireTimer === 0 ? 'off' : 'deleteAfterSend',
providedExpireTimer: expireTimer, providedExpireTimer: expireTimer,
providedChangeTimestamp: GetNetworkTime.getNowWithNetworkOffset(), providedChangeTimestamp: GetNetworkTime.getNowWithNetworkOffset(),
providedSource: sender, providedSource: sender,

@ -231,7 +231,7 @@ async function handleUserProfileUpdate(result: IncomingConfResult): Promise<Inco
if (wrapperNoteToSelfExpirySeconds !== expireTimer) { if (wrapperNoteToSelfExpirySeconds !== expireTimer) {
await ourConvo.updateExpireTimer({ await ourConvo.updateExpireTimer({
providedExpirationType: providedDisappearingMode:
wrapperNoteToSelfExpirySeconds && wrapperNoteToSelfExpirySeconds > 0 wrapperNoteToSelfExpirySeconds && wrapperNoteToSelfExpirySeconds > 0
? 'deleteAfterSend' ? 'deleteAfterSend'
: 'off', : 'off',
@ -387,7 +387,7 @@ async function handleContactsUpdate(result: IncomingConfResult): Promise<Incomin
wrapperConvo.expirationMode !== contactConvo.get('expirationMode') wrapperConvo.expirationMode !== contactConvo.get('expirationMode')
) { ) {
await contactConvo.updateExpireTimer({ await contactConvo.updateExpireTimer({
providedExpirationType: wrapperConvo.expirationMode, providedDisappearingMode: wrapperConvo.expirationMode,
providedExpireTimer: wrapperConvo.expirationTimerSeconds, providedExpireTimer: wrapperConvo.expirationTimerSeconds,
providedChangeTimestamp: result.latestEnvelopeTimestamp, providedChangeTimestamp: result.latestEnvelopeTimestamp,
providedSource: wrapperConvo.id, providedSource: wrapperConvo.id,

@ -455,7 +455,7 @@ export async function handleMessageJob(
} }
await conversation.updateExpireTimer({ await conversation.updateExpireTimer({
providedExpirationType: expirationTypeUpdate, providedDisappearingMode: expirationTypeUpdate,
providedExpireTimer: expireTimerUpdate, providedExpireTimer: expireTimerUpdate,
providedChangeTimestamp: lastDisappearingMessageChangeTimestamp, providedChangeTimestamp: lastDisappearingMessageChangeTimestamp,
providedSource: source, providedSource: source,

Loading…
Cancel
Save