Fix open group joining.

_locales/en/messages.json

@@ -1994,7 +1994,8 @@
       "Shown in the conversation history when someone updates the group"
   },
   "titleIsNow": {
-    "comment": "Do not add a period here, used as a fragment and will break unit test",
+    "comment":
+      "Do not add a period here, used as a fragment and will break unit test",
     "message": "Group name has been set to '$name$'",
     "description":
       "Shown in the conversation history when someone changes the title of the group",

js/background.js

@@ -1100,7 +1100,8 @@
       await conversation.setPublicSource(sslServerURL, channelId);
       // set friend and appropriate SYNC messages for multidevice
       await conversation.setFriendRequestStatus(
-        window.friends.friendRequestStatusEnum.friends
+        window.friends.friendRequestStatusEnum.friends,
+        { blockSync: true }
       );
 
       // and finally activate it

js/conversation_controller.js

@@ -136,10 +136,12 @@
 
       conversation.initialPromise = create();
       conversation.initialPromise.then(() => {
-        Promise.all([
+        if (!conversation.isPublic() && !conversation.isRss()) {
-          conversation.updateProfileAvatar(),
+          Promise.all([
-          window.lokiSnodeAPI.refreshSwarmNodesForPubKey(id),
+            conversation.updateProfileAvatar(),
-        ]);
+            window.lokiSnodeAPI.refreshSwarmNodesForPubKey(id),
+          ]);
+        }
       });
 
       return conversation;

js/modules/loki_app_dot_net_api.js

@@ -1629,12 +1629,13 @@ class LokiPublicChannelAPI {
       if (slavePrimaryMap[slaveKey]) {
         // rewrite source, profile
         messageData.source = primaryPubKey;
-        const { name, avatar, profileKey } = this.primaryUserProfileName[
+        const primaryProfile = this.primaryUserProfileName[primaryPubKey];
-          primaryPubKey
+        if (primaryProfile) {
-        ];
+          const { name, avatar, profileKey } = primaryProfile;
-        messageData.message.profile.displayName = name;
+          messageData.message.profile.displayName = name;
-        messageData.message.profile.avatar = avatar;
+          messageData.message.profile.avatar = avatar;
-        messageData.message.profileKey = profileKey;
+          messageData.message.profileKey = profileKey;
+        }
       }
       /* eslint-enable no-param-reassign */
       this.chatAPI.emit('publicMessage', {

ts/components/session/LeftPaneChannelSection.tsx

@@ -357,8 +357,8 @@ export class LeftPaneChannelSection extends React.Component<Props, State> {
     this.setState({ channelUrlPasted: value });
   }
 
-  private handleJoinChannelButtonClick() {
+  private handleJoinChannelButtonClick(groupUrl: string) {
-    const { loading, channelUrlPasted } = this.state;
+    const { loading } = this.state;
 
     if (loading) {
       return false;
@@ -366,7 +366,7 @@ export class LeftPaneChannelSection extends React.Component<Props, State> {
 
     const regexURL = /(http:\/\/www\.|https:\/\/www\.|http:\/\/|https:\/\/)?[a-z0-9]+([\-\.]{1}[a-z0-9]+)*\.[a-z]{2,5}(:[0-9]{1,5})?(\/.*)?/;
 
-    if (channelUrlPasted.length <= 0) {
+    if (groupUrl.length <= 0) {
       window.pushToast({
         title: window.i18n('noServerURL'),
         type: 'error',
@@ -376,7 +376,7 @@ export class LeftPaneChannelSection extends React.Component<Props, State> {
       return false;
     }
 
-    if (!regexURL.test(channelUrlPasted)) {
+    if (!regexURL.test(groupUrl)) {
       window.pushToast({
         title: window.i18n('noServerURL'),
         type: 'error',
@@ -386,7 +386,7 @@ export class LeftPaneChannelSection extends React.Component<Props, State> {
       return false;
     }
 
-    joinChannelStateManager(this, channelUrlPasted, () => {
+    joinChannelStateManager(this, groupUrl, () => {
       this.handleToggleOverlay(SessionGroupType.Open);
     });