Handle exceptions when fetching keys for devices

It's rare that we get in a state where we have a device record without a
session, but we should handle errors gracefully in that case. Catch them
and register them, except for identity key errors which are registered
in handleResult.

// FREEBIE

fixup error handling // FREEBIE

js/libtextsecure.js

@@ -39745,8 +39745,16 @@ OutgoingMessage.prototype = {
         return textsecure.storage.devices.getDeviceObjectsForNumber(number).then(function(devicesForNumber) {
             return Promise.all(devicesForNumber.map(function(device) {
                 return textsecure.protocol_wrapper.hasOpenSession(device.encodedNumber).then(function(result) {
-                    if (!result)
+                    if (!result) {
-                        return this.getKeysForNumber(number, [parseInt(textsecure.utils.unencodeNumber(device.encodedNumber)[1])]);
+                        return this.getKeysForNumber(number,
+                            [parseInt(textsecure.utils.unencodeNumber(device.encodedNumber)[1])]
+                        ).catch(function(error) {
+                            if (error.name !== 'OutgoingIdentityKeyError') {
+                                this.registerError(number, "Failed to retreive new device keys for " + device.encodedNumber, error);
+                            }
+                            return Promise.reject();
+                        }.bind(this));
+                    }
                 }.bind(this));
             }.bind(this))).then(function() {
                 return textsecure.storage.devices.getDeviceObjectsForNumber(number).then(function(devicesForNumber) {

libtextsecure/outgoing_message.js

@@ -114,8 +114,16 @@ OutgoingMessage.prototype = {
         return textsecure.storage.devices.getDeviceObjectsForNumber(number).then(function(devicesForNumber) {
             return Promise.all(devicesForNumber.map(function(device) {
                 return textsecure.protocol_wrapper.hasOpenSession(device.encodedNumber).then(function(result) {
-                    if (!result)
+                    if (!result) {
-                        return this.getKeysForNumber(number, [parseInt(textsecure.utils.unencodeNumber(device.encodedNumber)[1])]);
+                        return this.getKeysForNumber(number,
+                            [parseInt(textsecure.utils.unencodeNumber(device.encodedNumber)[1])]
+                        ).catch(function(error) {
+                            if (error.name !== 'OutgoingIdentityKeyError') {
+                                this.registerError(number, "Failed to retreive new device keys for " + device.encodedNumber, error);
+                            }
+                            return Promise.reject();
+                        }.bind(this));
+                    }
                 }.bind(this));
             }.bind(this))).then(function() {
                 return textsecure.storage.devices.getDeviceObjectsForNumber(number).then(function(devicesForNumber) {