- Only start the ip to country code in the Path activity
- Closing retriever for attachments to avoid leaks
- Handling a null case in MediaSend activity
- Switching to a bg thread for path retrieval in settings
This contains the new standardised deletion
A potential fix for the most common ANR
Removed the 'screenshot notification' toggle which was misleading
The set of 'nice to have' from the strings branch
* Not deleting a thread when it's empty - showing an empty snippet when thread is empty or only made up of 'marked as deleted' messages
* SES-2814 - show empty state when conversations are empty
* SES-2810 - Removing the screenshot privacy toggle
* SES-2813 - clickable only when there is a 'follow settings'
* SES-2815 - proper icon and spacing for deleted messages
* Simplified deletion dialog to be reused for note to self and the rest as only the labels change
* SES-2819 - Do not show a reaction on a deleted message
* Fixing up deletion details
Message view hides reactions completely if the message is marked as deleted
All messages can now show the 'Delete' long press option
Community messages should be removed completely not marked as deleted
* Revert "SES-2819 - Do not show a reaction on a deleted message"
This reverts commit 711e31a43a.
* Avoiding adding reactions if the message is marked as deleted
* Removing uneeded icon
* Deletion handled by VM so menu item is always visible
* SES-2811 - Do not attempt to send a failed message marked as deleted
* SES-2818 - Making sure we set the lastMessage in a thread properly, without using 'marked as deleted' messages
* SES-2464 - changed the behaviour to finish the convo activity but instead refresh the sarch on resume
* removing log
* SES-2464 - properly heading to home root when deleting a thread
* SES-2810 - Catering for missing config contacts vs local contacts
Making sure we deleted conversations when a contact is missing from the config while existing locally
* SES-2810 - Removing the screenshot privacy toggle
* SES-2813 - clickable only when there is a 'follow settings'
* SES-2815 - proper icon and spacing for deleted messages
* Simplified deletion dialog to be reused for note to self and the rest as only the labels change
* SES-2819 - Do not show a reaction on a deleted message
* Fixing up deletion details
Message view hides reactions completely if the message is marked as deleted
All messages can now show the 'Delete' long press option
Community messages should be removed completely not marked as deleted
* Revert "SES-2819 - Do not show a reaction on a deleted message"
This reverts commit 711e31a43a.
* Avoiding adding reactions if the message is marked as deleted
* Initial commit with high level structure for new message deletion logic
* Adding admin logic
* New dialog styles
* Matching existing dialog closer to new designs
* Using the theme attribute danger instead of a hardcoded colour
* Using classes for the dialogs
Also cleaned up older references to align with newer look
* Adding cancel handling
Cleaning unused code
* Handling local deletion with batch message deletion
* Reusing the 'delete locally'
* Delete on device should "marl the message as deleted", not remove it from the db directly
* Displaying "marked as deleted" messages
Split the `BASE_DELETED_TYPE` into two types:
BASE_DELETED_OUTGOING_TYPE and BASE_DELETED_INCOMING_TYPE
so we can differentiate them visually.
* Proper handling of merged code
* Removed temp bg color
* Making sure the deleted message view is visible
* Renaming functions for clarity
* Adding the ability to customise the text for the deleted control messages
* Removing code that was added back from merging dev back in
* Using the updated strings
* Toast confirmation on 'delete locally'
* Recreating xml dialogs in Compose and moved logic in VM
* Removing hardcoded strings
* Updated message deletion logic
Still need to finalise "note to self" and "legacy groups"
* Deletion logic rework
Moving away from promises
* More deletion logic
Hndling unsend request retrieval as per figma docs
* Making sure multi-select works as expectec
* Multi message handling
Sharing admin logic
* Deleting reactions when deleting a message
* Deleting reactions when deleting a message
* Grabbing server hash from notification data
* Fixed unit tests
* Handling deletion od "marked as deleted" messages
* Handling Control Messages longpress and deletion
* Back up handling of no map data for huawei notifications
Also rethemed the send buttona dn home plus button to have better ax contrast by standardising the colour displayed on the accent color to be the same as the one on the sent messages
* Removed test line
* Reworking the deletion dialogs
We removed the 'delete locally' dialog, instead we show the 'delete for everyone' with the second option disabled
* Outgoing messages can all be marked as 'delete for everyone'
Cleaned up invisible copy button on black bgs
* Adding a confirmation dialog when clearing emoji
* Message request text update
* Restyling menu items to not show in uppercase
* Proper hint for seach
* Do not show seconds when they're 0
* Making the change to "hidden recovery" reactive so it can be dynamically updated in the settings page.
This can be simplified once we make SharedPreferences widely accessible as Flows
---------
Co-authored-by: ThomasArtProcessors <71994342+ThomasArtProcessors@users.noreply.github.com>
* Initial commit with high level structure for new message deletion logic
* Adding admin logic
* New dialog styles
* Matching existing dialog closer to new designs
* Using the theme attribute danger instead of a hardcoded colour
* Using classes for the dialogs
Also cleaned up older references to align with newer look
* Adding cancel handling
Cleaning unused code
* Handling local deletion with batch message deletion
* Reusing the 'delete locally'
* Delete on device should "marl the message as deleted", not remove it from the db directly
* Displaying "marked as deleted" messages
Split the `BASE_DELETED_TYPE` into two types:
BASE_DELETED_OUTGOING_TYPE and BASE_DELETED_INCOMING_TYPE
so we can differentiate them visually.
* Proper handling of merged code
* Removed temp bg color
* Making sure the deleted message view is visible
* Renaming functions for clarity
* Adding the ability to customise the text for the deleted control messages
* Removing code that was added back from merging dev back in
* Using the updated strings
* Toast confirmation on 'delete locally'
* Recreating xml dialogs in Compose and moved logic in VM
* Removing hardcoded strings
* Updated message deletion logic
Still need to finalise "note to self" and "legacy groups"
* Deletion logic rework
Moving away from promises
* More deletion logic
Hndling unsend request retrieval as per figma docs
* Making sure multi-select works as expectec
* Multi message handling
Sharing admin logic
* Deleting reactions when deleting a message
* Deleting reactions when deleting a message
* Grabbing server hash from notification data
* Fixed unit tests
* Handling deletion od "marked as deleted" messages
* Handling Control Messages longpress and deletion
* Back up handling of no map data for huawei notifications
Also rethemed the send buttona dn home plus button to have better ax contrast by standardising the colour displayed on the accent color to be the same as the one on the sent messages
* Removed test line
* Reworking the deletion dialogs
We removed the 'delete locally' dialog, instead we show the 'delete for everyone' with the second option disabled
* Outgoing messages can all be marked as 'delete for everyone'
Cleaned up invisible copy button on black bgs
* PR feedback
* Updated huawei file and tested notifications
* Fixed SES-2802
Only force the priority to visible when going from not approved to approved
* Syncing state diaplays as sent
Syncing happens in the bg so the user doesn't need to know of it hence the status can display as "Sent" during the syncing phase.
Resyncing, in case it happens, can display the "Syncing" status as it would happen after a syncing error.
* Latest strings
---------
Co-authored-by: ThomasArtProcessors <71994342+ThomasArtProcessors@users.noreply.github.com>
When getting messages we check if the contact was marked as hidden and compare the timestamps of both the message and the config object to check whether to re-show the thread or not.
Making sure an approved message request sets the contact as visible. They could have been set to hidden if the contact had previously sent another message request which was then declined.
Upon sending another one we need to make sure the contact is set to visible once that request is approved.
SessionHero01
ThomasSession
Andrew
bemusementpark