Disable selecting message for post deprecated legacy groups (#950)

app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationActivityV2.kt

@@ -353,9 +353,7 @@ class ConversationActivityV2 : PassphraseRequiredActionBarActivity(), InputBarDe
                 handleSwipeToReply(message)
             },
             onItemLongPress = { message, position, view ->
-                if (!viewModel.isMessageRequestThread &&
+                if (!viewModel.isMessageRequestThread) {
-                    viewModel.canReactToMessages
-                ) {
                     showConversationReaction(message, view)
                 } else {
                     selectMessage(message, position)

app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationReactionOverlay.kt

@@ -552,11 +552,14 @@ class ConversationReactionOverlay : FrameLayout {
         val openGroup = lokiThreadDatabase.getOpenGroupChat(message.threadId)
         val userPublicKey = textSecurePreferences.getLocalNumber()!!
 
+        val isDeprecatedLegacyGroup = recipient.isLegacyGroupRecipient &&
+                deprecationManager.isDeprecated
+
         // control messages and "marked as deleted" messages can only delete
         val isDeleteOnly = message.isDeleted || message.isControlMessage
 
         // Select message
-        if(!isDeleteOnly) {
+        if(!isDeleteOnly && !isDeprecatedLegacyGroup) {
             items += ActionItem(
                 R.attr.menu_select_icon,
                 R.string.select,
@@ -565,10 +568,6 @@ class ConversationReactionOverlay : FrameLayout {
             )
         }
 
-
-        val isDeprecatedLegacyGroup = recipient.isLegacyGroupRecipient &&
-                deprecationManager.isDeprecated
-
         // Reply
         val canWrite = openGroup == null || openGroup.canWrite
         if (canWrite && !message.isPending && !message.isFailed && !message.isOpenGroupInvitation && !isDeleteOnly

app/src/main/java/org/thoughtcrime/securesms/conversation/v2/menus/ConversationActionModeCallback.kt

@@ -60,7 +60,6 @@ class ConversationActionModeCallback(
         }
 
 
-
         // Delete message
         menu.findItem(R.id.menu_context_delete_message).isVisible = !isDeprecatedLegacyGroup // can always delete since delete logic will be handled by the VM
         // Ban user