Fix/ip2 country out of memory (#1628)

* Avoiding to recall Ipv4Int on every loop

* Avoiding memory allocation since this is used in laarge sets

* Further improvements and updated the memory allocation avoiding code

* PR feedback

app/src/main/java/org/thoughtcrime/securesms/util/IP2Country.kt

@@ -5,46 +5,65 @@ import android.content.Context
 import android.content.Intent
 import android.content.IntentFilter
 import androidx.localbroadcastmanager.content.LocalBroadcastManager
-import org.session.libsignal.utilities.Log
 import com.opencsv.CSVReader
 import org.session.libsession.snode.OnionRequestAPI
+import org.session.libsignal.utilities.Log
 import org.session.libsignal.utilities.ThreadUtils
 import java.io.File
 import java.io.FileOutputStream
 import java.io.FileReader
+import java.util.SortedMap
+import java.util.TreeMap
 
 class IP2Country private constructor(private val context: Context) {
     private val pathsBuiltEventReceiver: BroadcastReceiver
     val countryNamesCache = mutableMapOf<String, String>()
 
-    private fun Ipv4Int(ip:String) = ip.takeWhile { it != '/' }.split('.').foldIndexed(0L) { i, acc, s ->
+    private fun Ipv4Int(ip: String): Int {
-        val asInt = s.toLong()
+        var result = 0L
-        acc + (asInt shl (8 * (3-i)))
+        var currentValue = 0L
+        var octetIndex = 0
+
+        for (char in ip) {
+            if (char == '.' || char == '/') {
+                result = result or (currentValue shl (8 * (3 - octetIndex)))
+                currentValue = 0
+                octetIndex++
+                if (char == '/') break
+            } else {
+                currentValue = currentValue * 10 + (char - '0')
+            }
         }
 
-    private val ipv4ToCountry by lazy {
+        // Handle the last octet
-        val file = loadFile("geolite2_country_blocks_ipv4.csv")
+        result = result or (currentValue shl (8 * (3 - octetIndex)))
-        val csv = CSVReader(FileReader(file.absoluteFile)).apply {
+
-            skip(1)
+        return result.toInt()
     }
 
-        csv.readAll()
+    private val ipv4ToCountry: TreeMap<Int, Int?> by lazy {
-                .associate { cols ->
+        val file = loadFile("geolite2_country_blocks_ipv4.csv")
-                    Ipv4Int(cols[0]) to cols[1].toIntOrNull()
+        CSVReader(FileReader(file.absoluteFile)).use { csv ->
+            csv.skip(1)
+
+            csv.asSequence().associateTo(TreeMap()) { cols ->
+                Ipv4Int(cols[0]).toInt() to cols[1].toIntOrNull()
+            }
         }
     }
 
-    private val countryToNames by lazy {
+    private val countryToNames: Map<Int, String> by lazy {
         val file = loadFile("geolite2_country_locations_english.csv")
-        val csv = CSVReader(FileReader(file.absoluteFile)).apply {
+        CSVReader(FileReader(file.absoluteFile)).use { csv ->
-            skip(1)
+            csv.skip(1)
-        }
+
-        csv.readAll()
+            csv.asSequence()
                 .filter { cols -> !cols[0].isNullOrEmpty() && !cols[1].isNullOrEmpty() }
                 .associate { cols ->
                     cols[0].toInt() to cols[5]
                 }
         }
+    }
 
     // region Initialization
     companion object {
@@ -95,9 +114,8 @@ class IP2Country private constructor(private val context: Context) {
         // return early if cached
         countryNamesCache[ip]?.let { return it }
 
-        val comps = ipv4ToCountry.asSequence()
+        val ipInt = Ipv4Int(ip)
-
+        val bestMatchCountry = ipv4ToCountry.floorEntry(ipInt)?.let { (_, code) ->
-        val bestMatchCountry = comps.lastOrNull { it.key <= Ipv4Int(ip)  }?.let { (_, code) ->
             if (code != null) {
                 countryToNames[code]
             } else {
@@ -127,3 +145,4 @@ class IP2Country private constructor(private val context: Context) {
     }
     // endregion
 }
+

app/src/main/java/org/thoughtcrime/securesms/util/ListUtil.java

@@ -2,10 +2,7 @@ package org.thoughtcrime.securesms.util;
 
 import androidx.annotation.NonNull;
 
-import com.annimon.stream.Stream;
-
 import java.util.ArrayList;
-import java.util.Collection;
 import java.util.List;
 
 public final class ListUtil {
@@ -21,16 +18,4 @@ public final class ListUtil {
 
     return chunks;
   }
-
-  @SafeVarargs
-  public static <T> List<T> concat(Collection<T>... items) {
-    //noinspection Convert2MethodRef
-    final List<T> concat = new ArrayList<>(Stream.of(items).map(Collection::size).reduce(0, (lhs, rhs) -> lhs+rhs));
-
-    for (Collection<T> list : items) {
-      concat.addAll(list);
-    }
-
-    return concat;
-  }
 }