fix logic error of isCaughtUp

src/org/thoughtcrime/securesms/notifications/OptimizedMessageNotifier.java

@@ -42,9 +42,13 @@ public class OptimizedMessageNotifier implements MessageNotifier {
   public void updateNotification(@NonNull Context context) {
     LokiPoller lokiPoller = ApplicationContext.getInstance(context).lokiPoller;
     LokiPublicChatManager lokiPublicChatManager = ApplicationContext.getInstance(context).lokiPublicChatManager;
-    Boolean isCaughtUp = false;
+    Boolean isCaughtUp = true;
-    if (lokiPoller != null && lokiPublicChatManager != null) {
+    if (lokiPoller != null) {
-      isCaughtUp = lokiPoller.isCaughtUp() && lokiPublicChatManager.areAllCaughtUp();
+      isCaughtUp = isCaughtUp && lokiPoller.isCaughtUp();
+    }
+
+    if (lokiPublicChatManager != null) {
+      isCaughtUp = isCaughtUp && lokiPublicChatManager.areAllCaughtUp();
     }
 
     if (isCaughtUp) {
@@ -58,9 +62,13 @@ public class OptimizedMessageNotifier implements MessageNotifier {
   public void updateNotification(@NonNull Context context, long threadId) {
     LokiPoller lokiPoller = ApplicationContext.getInstance(context).lokiPoller;
     LokiPublicChatManager lokiPublicChatManager = ApplicationContext.getInstance(context).lokiPublicChatManager;
-    Boolean isCaughtUp = false;
+    Boolean isCaughtUp = true;
-    if (lokiPoller != null && lokiPublicChatManager != null) {
+    if (lokiPoller != null) {
-      isCaughtUp = lokiPoller.isCaughtUp() && lokiPublicChatManager.areAllCaughtUp();
+      isCaughtUp = isCaughtUp && lokiPoller.isCaughtUp();
+    }
+
+    if (lokiPublicChatManager != null) {
+      isCaughtUp = isCaughtUp && lokiPublicChatManager.areAllCaughtUp();
     }
     
     if (isCaughtUp) {
@@ -74,9 +82,13 @@ public class OptimizedMessageNotifier implements MessageNotifier {
   public void updateNotification(@NonNull Context context, long threadId, boolean signal) {
     LokiPoller lokiPoller = ApplicationContext.getInstance(context).lokiPoller;
     LokiPublicChatManager lokiPublicChatManager = ApplicationContext.getInstance(context).lokiPublicChatManager;
-    Boolean isCaughtUp = false;
+    Boolean isCaughtUp = true;
-    if (lokiPoller != null && lokiPublicChatManager != null) {
+    if (lokiPoller != null) {
-      isCaughtUp = lokiPoller.isCaughtUp() && lokiPublicChatManager.areAllCaughtUp();
+      isCaughtUp = isCaughtUp && lokiPoller.isCaughtUp();
+    }
+
+    if (lokiPublicChatManager != null) {
+      isCaughtUp = isCaughtUp && lokiPublicChatManager.areAllCaughtUp();
     }
 
     if (isCaughtUp) {
@@ -90,9 +102,13 @@ public class OptimizedMessageNotifier implements MessageNotifier {
   public void updateNotification(@android.support.annotation.NonNull Context context, boolean signal, int reminderCount) {
     LokiPoller lokiPoller = ApplicationContext.getInstance(context).lokiPoller;
     LokiPublicChatManager lokiPublicChatManager = ApplicationContext.getInstance(context).lokiPublicChatManager;
-    Boolean isCaughtUp = false;
+    Boolean isCaughtUp = true;
-    if (lokiPoller != null && lokiPublicChatManager != null) {
+    if (lokiPoller != null) {
-      isCaughtUp = lokiPoller.isCaughtUp() && lokiPublicChatManager.areAllCaughtUp();
+      isCaughtUp = isCaughtUp && lokiPoller.isCaughtUp();
+    }
+
+    if (lokiPublicChatManager != null) {
+      isCaughtUp = isCaughtUp && lokiPublicChatManager.areAllCaughtUp();
     }
 
     if (isCaughtUp) {