Switch from secure indicator to insecure indicator

Instead of cluttering Signal messages with a little padlock,
let's highlight the insecurity of SMS messages instead.

// FREEBIE

res/layout/conversation_item_received.xml

@@ -113,15 +113,16 @@
                           android:orientation="horizontal"
                           android:gravity="left">
 
-                <ImageView android:id="@+id/secure_indicator"
+                <ImageView android:id="@+id/insecure_indicator"
-                           android:layout_width="wrap_content"
+                           android:layout_width="12dp"
-                           android:layout_height="wrap_content"
+                           android:layout_height="11dp"
                            android:layout_gravity="center_vertical"
-                           android:paddingRight="2dp"
+                           android:layout_marginRight="3dp"
-                           android:paddingEnd="4dp"
+                           android:layout_marginEnd="3dp"
-                           android:src="?menu_lock_icon_small"
+                           android:src="@drawable/ic_unlocked_white_18dp"
                            android:contentDescription="@string/conversation_item__secure_message_description"
                            android:visibility="gone"
+                           android:alpha=".65"
                            android:tint="?conversation_item_received_text_secondary_color"
                            android:tintMode="multiply"
                            tools:visibility="visible"/>
@@ -135,8 +136,10 @@
                         app:offset="0"
                         android:layout_gravity="center_vertical|end"
                         android:alpha=".65"
-                        android:layout_width="10dp"
+                        android:layout_width="8dp"
                         android:layout_height="11dp"
+                        android:layout_marginRight="3dp"
+                        android:layout_marginEnd="3dp"
                         android:visibility="gone"
                         tools:visibility="visible"/>
 

res/layout/conversation_item_sent.xml

@@ -154,19 +154,22 @@
                         android:layout_gravity="center_vertical|end"
                         android:alpha=".6"
                         android:layout_marginLeft="3dp"
-                        android:layout_width="10dp"
+                        android:layout_marginStart="3dp"
+                        android:layout_width="7dp"
                         android:layout_height="11dp"
                         android:visibility="gone"
                         tools:visibility="visible"/>
 
-                <ImageView android:id="@+id/secure_indicator"
+                <ImageView android:id="@+id/insecure_indicator"
-                           android:layout_width="wrap_content"
+                           android:layout_width="12dp"
-                           android:layout_height="wrap_content"
+                           android:layout_height="11dp"
-                           android:src="?menu_lock_icon_small"
+                           android:src="@drawable/ic_unlocked_white_18dp"
                            android:visibility="gone"
                            android:layout_gravity="center_vertical|end"
-                           android:paddingLeft="2dp"
+                           android:alpha=".6"
-                           android:tint="?conversation_item_sent_text_secondary_color"
+                           android:tint="@color/black"
+                           android:layout_marginLeft="3dp"
+                           android:layout_marginStart="3dp"
                            android:tintMode="multiply"
                            android:contentDescription="@string/conversation_item__secure_message_description"
                            tools:visibility="visible"/>

src/org/thoughtcrime/securesms/ConversationItem.java

@@ -117,7 +117,7 @@ public class ConversationItem extends LinearLayout
   private TextView           groupSender;
   private TextView           groupSenderProfileName;
   private View               groupSenderHolder;
-  private ImageView          secureImage;
+  private ImageView          insecureImage;
   private AvatarImageView    contactPhoto;
   private DeliveryStatusView deliveryStatusIndicator;
   private AlertView          alertView;
@@ -162,7 +162,7 @@ public class ConversationItem extends LinearLayout
     this.indicatorText           = (TextView)           findViewById(R.id.indicator_text);
     this.groupSender             = (TextView)           findViewById(R.id.group_message_sender);
     this.groupSenderProfileName  = (TextView)           findViewById(R.id.group_message_sender_profile);
-    this.secureImage             = (ImageView)          findViewById(R.id.secure_indicator);
+    this.insecureImage           = (ImageView)          findViewById(R.id.insecure_indicator);
     this.deliveryStatusIndicator = (DeliveryStatusView) findViewById(R.id.delivery_status);
     this.alertView               = (AlertView)          findViewById(R.id.indicators_parent);
     this.contactPhoto            = (AvatarImageView)    findViewById(R.id.contact_photo);
@@ -432,7 +432,7 @@ public class ConversationItem extends LinearLayout
   private void setStatusIcons(MessageRecord messageRecord) {
     indicatorText.setVisibility(View.GONE);
 
-    secureImage.setVisibility(messageRecord.isSecure() ? View.VISIBLE : View.GONE);
+    insecureImage.setVisibility(messageRecord.isSecure() ? View.GONE : View.VISIBLE);
     bodyText.setCompoundDrawablesWithIntrinsicBounds(0, 0, messageRecord.isKeyExchange() ? R.drawable.ic_menu_login : 0, 0);
     dateText.setText(DateUtils.getExtendedRelativeTimeSpanString(getContext(), locale, messageRecord.getTimestamp()));