Fix blocked contacts button (#1264)

app/src/main/java/org/thoughtcrime/securesms/preferences/BlockedContactsLayout.kt

@@ -1,9 +0,0 @@
-package org.thoughtcrime.securesms.preferences
-
-import android.content.Context
-import android.util.AttributeSet
-import android.widget.FrameLayout
-
-class BlockedContactsLayout @JvmOverloads constructor(
-    context: Context, attrs: AttributeSet? = null
-) : FrameLayout(context, attrs)

app/src/main/java/org/thoughtcrime/securesms/preferences/BlockedContactsPreference.kt

@@ -3,7 +3,6 @@ package org.thoughtcrime.securesms.preferences
 import android.content.Context
 import android.content.Intent
 import android.util.AttributeSet
-import android.view.View
 import androidx.preference.PreferenceCategory
 import androidx.preference.PreferenceViewHolder
 
@@ -16,8 +15,7 @@ class BlockedContactsPreference @JvmOverloads constructor(
         super.onBindViewHolder(holder)
 
         holder.itemView.setOnClickListener {
-            val intent = Intent(context, BlockedContactsActivity::class.java)
+            Intent(context, BlockedContactsActivity::class.java).let(context::startActivity)
-            context.startActivity(intent)
         }
     }
 }

app/src/main/res/layout/blocked_contacts_preference.xml

@@ -1,18 +1,15 @@
 <?xml version="1.0" encoding="utf-8"?>
-<org.thoughtcrime.securesms.preferences.BlockedContactsLayout xmlns:android="http://schemas.android.com/apk/res/android"
-    android:layout_width="match_parent"
-    android:layout_marginHorizontal="@dimen/large_spacing"
-    android:layout_marginVertical="@dimen/medium_spacing"
-    android:layout_height="wrap_content">
 <Button
+    xmlns:android="http://schemas.android.com/apk/res/android"
     android:contentDescription="@string/AccessibilityId_blocked_contacts"
     style="@style/Widget.Session.Button.Common.Borderless"
     android:layout_width="wrap_content"
     android:layout_height="wrap_content"
     android:paddingHorizontal="@dimen/medium_spacing"
+    android:layout_marginHorizontal="@dimen/large_spacing"
+    android:layout_marginVertical="@dimen/medium_spacing"
     android:text="@string/blocked_contacts_title"
     android:textColor="@color/destructive"
     android:textSize="16sp"
     android:textStyle="bold"
 />
-</org.thoughtcrime.securesms.preferences.BlockedContactsLayout>