Merge pull request #1886 from mcginty/mms-bad-pdu-logging

enable more verbose PDU parse logging

src/org/thoughtcrime/securesms/mms/MmsDownloadHelper.java

@@ -22,6 +22,7 @@ import android.util.Log;
 
 import java.io.IOException;
 import java.net.HttpURLConnection;
+import java.util.Arrays;
 
 import ws.com.google.android.mms.pdu.PduParser;
 import ws.com.google.android.mms.pdu.RetrieveConf;
@@ -88,7 +89,7 @@ public class MmsDownloadHelper extends MmsCommunication {
 
         if (pdu != null) break;
       } catch (IOException ioe) {
-        Log.w("MmsDownloadHelper", ioe);
+        Log.w(TAG, ioe);
       }
     }
 
@@ -99,6 +100,7 @@ public class MmsDownloadHelper extends MmsCommunication {
     RetrieveConf retrieved = (RetrieveConf)new PduParser(pdu).parse();
 
     if (retrieved == null) {
+      Log.w(TAG, "Couldn't parse PDU, raw server response: " + Arrays.toString(pdu));
       throw new IOException("Bad retrieved PDU");
     }
 

src/ws/com/google/android/mms/pdu/PduParser.java

@@ -83,8 +83,7 @@ public class PduParser {
      * The log tag.
      */
     private static final String LOG_TAG = "PduParser";
-    private static final boolean DEBUG = false;
+    private static final boolean LOCAL_LOGV = true;
-    private static final boolean LOCAL_LOGV = false;
 
     /**
      * Constructor.