PR feedback

app/src/main/java/org/thoughtcrime/securesms/attachments/DatabaseAttachmentProvider.kt

@@ -218,7 +218,7 @@ class DatabaseAttachmentProvider(context: Context, helper: SQLCipherOpenHelper)
     override fun markMessageAsDeleted(timestamp: Long, author: String, displayedMessage: String) {
         val database = DatabaseComponent.get(context).mmsSmsDatabase()
         val address = Address.fromSerialized(author)
-        val message = database.getMessageFor(timestamp, address) ?: return
+        val message = database.getMessageFor(timestamp, address) ?: return Log.w("", "Failed to find message to mark as deleted")
 
         markMessagesAsDeleted(
             messages = listOf(MarkAsDeletedMessage(

app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationActivityV2.kt

@@ -1316,7 +1316,7 @@ class ConversationActivityV2 : PassphraseRequiredActionBarActivity(), InputBarDe
             is VisibleMessageView -> messageView.messageContentView
             is ControlMessageView -> messageView.controlContentView
             else -> null
-        } ?: return
+        } ?: return Log.w(TAG, "Failed to show reaction because the messageRecord is not of a known type: $messageView")
 
         val messageContentBitmap = try {
             messageContentView.drawToBitmap()

app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationViewModel.kt

@@ -653,7 +653,9 @@ class ConversationViewModel(
                     it.copy(isMessageRequestAccepted = true)
                 }
             }
-            .onFailure {}
+            .onFailure {
+                Log.w("", "Failed to accept message request: $it")
+            }
     }
 
     fun declineMessageRequest() {