stop using listedPackage.IgnoredGoFiles
We used it to detect GOOS-specific packages and ignore their load errors without having to do a substring search. However, it turns out that repeatedly loading the string slice from gob files in the cache is rather slow, particularly since many Go packages have dozens of GOOS-specific files which can be ignored. │ old │ new │ │ cached-sec/op │ cached-sec/op vs base │ Build-8 340.3m ± 1% 335.8m ± 2% -1.32% (p=0.002 n=10) │ old │ new │ │ mallocs/op │ mallocs/op vs base │ Build-8 35.73M ± 0% 35.09M ± 0% -1.79% (p=0.000 n=10)pull/850/head
parent
8a7d91b684
commit
b38f42da0f
Loading…
Reference in New Issue