rename func and update docs on handleDirectives

We've been obfuscating all linknamed names for a while now,
so the part in the docs about "recording" is no longer true.

All it does is transform the directives to use obfuscated names.
Give it a better name and rewrite the docs.
pull/756/head
Daniel Martí 1 year ago
parent d5cbf2edca
commit 5fddfe1e61

@ -968,7 +968,7 @@ func transformCompile(args []string) ([]string, error) {
updateEntryOffset(file, entryOffKey()) updateEntryOffset(file, entryOffKey())
} }
} }
tf.handleDirectives(file.Comments) tf.transformDirectives(file.Comments)
file = tf.transformGoFile(file) file = tf.transformGoFile(file)
// newPkgPath might be the original ImportPath in some edge cases like // newPkgPath might be the original ImportPath in some edge cases like
// compilerIntrinsics; we don't want to use slashes in package names. // compilerIntrinsics; we don't want to use slashes in package names.
@ -1017,12 +1017,9 @@ func transformCompile(args []string) ([]string, error) {
return append(flags, newPaths...), nil return append(flags, newPaths...), nil
} }
// handleDirectives looks at all the comments in a file containing build // transformDirectives rewrites //go:linkname toolchain directives in comments
// directives, and does the necessary for the obfuscation process to work. // to replace names with their obfuscated versions.
// func (tf *transformer) transformDirectives(comments []*ast.CommentGroup) {
// Right now, this means recording what local names are used with go:linkname,
// and rewriting those directives to use obfuscated name from other packages.
func (tf *transformer) handleDirectives(comments []*ast.CommentGroup) {
for _, group := range comments { for _, group := range comments {
for _, comment := range group.List { for _, comment := range group.List {
if !strings.HasPrefix(comment.Text, "//go:linkname ") { if !strings.HasPrefix(comment.Text, "//go:linkname ") {

Loading…
Cancel
Save