update the state of a few TODOs related to upstream Go
The generics issue has been fixed for the upcoming Go 1.20. Include that version as a reminder for when we can drop Go 1.19. The fs.SkipAll proposal is also implemented for Go 1.20. The BinaryContentID comment was a little bit trickier. We did get stamped VCS information some time ago, but it only provides us with the current commit info and a dirty bit. That is not enough for our use of the build cache, because we want any uncommitted changes to garble to cause rebuilds. I don't think we'll get any better than using garble's own build ID. Reword the quasi-TODO to instead explain what we're doing and why.pull/589/head
parent
ac0945eaa5
commit
3c7141e801
Loading…
Reference in New Issue