reduce verbosity in the last change

Declare the ast.GenDecl node once,
which allows us to deduplicate and inline code.
resolveImportSpec doesn't need to be separate either.

We also don't need explicit panics for unexpected nils;
we can rely on nil checks inserted by the compiler.

Finally, move the bulk of the code outside of the scope.Names loop,
which unindents most of the logic.

While here, add a few more inline docs.

main.go

@@ -950,7 +950,7 @@ func transformCompile(args []string) ([]string, error) {
 			if flagTiny {
 				// strip unneeded runtime code
 				stripRuntime(basename, file)
-				tf.makeImportsUsed(file)
+				tf.useAllImports(file)
 			}
 			if basename == "symtab.go" {
 				updateMagicValue(file, magicValue())
@@ -1687,23 +1687,6 @@ func recordedAsNotObfuscated(obj types.Object) bool {
 	return ok
 }
 
-func (tf *transformer) resolveImportSpec(imp *ast.ImportSpec) *types.Package {
-	// Simple import has no ast.Ident and is stored in Implicits separately.
-	obj := tf.info.Implicits[imp]
-	if obj == nil {
-		obj = tf.info.Defs[imp.Name] // renamed or dot import
-	}
-	if obj == nil {
-		return nil
-	}
-
-	pkgObj, ok := obj.(*types.PkgName)
-	if !ok {
-		panic(fmt.Sprintf("unexpected object type for %s: %v", imp.Path.Value, obj))
-	}
-	return pkgObj.Imported()
-}
-
 // isSafeForInstanceType returns true if the passed type is safe for var declaration.
 // Unsafe types: generic types and non-method interfaces.
 func isSafeForInstanceType(typ types.Type) bool {
@@ -1721,93 +1704,71 @@ func isSafeForInstanceType(typ types.Type) bool {
 	return true
 }
 
-func (tf *transformer) makeImportsUsed(file *ast.File) {
+func (tf *transformer) useAllImports(file *ast.File) {
 	for _, imp := range file.Imports {
 		if imp.Name != nil && imp.Name.Name == "_" {
 			continue
 		}
 
-		pkg := tf.resolveImportSpec(imp)
+		// Simple import has no ast.Ident and is stored in Implicits separately.
-		if pkg == nil {
+		pkgObj := tf.info.Implicits[imp]
-			panic(fmt.Sprintf("import %s not found", imp.Path.Value))
+		if pkgObj == nil {
+			pkgObj = tf.info.Defs[imp.Name] // renamed or dot import
 		}
 
-		generated := false
+		pkgScope := pkgObj.(*types.PkgName).Imported().Scope()
-		scope := pkg.Scope()
+		var nameObj types.Object
-		for _, name := range scope.Names() {
+		for _, name := range pkgScope.Names() {
-			if !token.IsExported(name) {
+			if obj := pkgScope.Lookup(name); obj.Exported() && isSafeForInstanceType(obj.Type()) {
-				continue
+				nameObj = obj
-			}
+				break
-			obj := scope.Lookup(name)
-			if obj == nil {
-				panic(fmt.Sprintf("%s not found in %s", name, imp.Path.Value))
-			}
-			if !isSafeForInstanceType(obj.Type()) {
-				continue
 			}
+		}
+		if nameObj == nil {
+			// A very unlikely situation where there is no suitable declaration for a reference variable
+			// and almost certainly means that there is another import reference in code.
+			continue
+		}
+		spec := &ast.ValueSpec{Names: []*ast.Ident{ast.NewIdent("_")}}
+		decl := &ast.GenDecl{Specs: []ast.Spec{spec}}
 
-			nameIdent := ast.NewIdent(name)
+		nameIdent := ast.NewIdent(nameObj.Name())
-			getFullName := func() ast.Expr {
+		var nameExpr ast.Expr
-				if imp.Name == nil {
+		switch {
-					return &ast.SelectorExpr{
+		case imp.Name == nil: // import "pkg/path"
-						X:   ast.NewIdent(pkg.Name()),
+			nameExpr = &ast.SelectorExpr{
-						Sel: nameIdent,
+				X:   ast.NewIdent(pkgObj.Name()),
-					}
+				Sel: nameIdent,
-				}
-				if imp.Name.Name == "." {
-					return nameIdent
-				}
-				return &ast.SelectorExpr{
-					X:   ast.NewIdent(imp.Name.Name),
-					Sel: nameIdent,
-				}
 			}
-
+		case imp.Name.Name != ".": // import path2 "pkg/path"
-			var decl *ast.GenDecl
+			nameExpr = &ast.SelectorExpr{
-			switch obj.(type) {
+				X:   ast.NewIdent(imp.Name.Name),
-			case *types.Const:
+				Sel: nameIdent,
-				// const _ = <value>
-				decl = &ast.GenDecl{
-					Tok: token.CONST,
-					Specs: []ast.Spec{&ast.ValueSpec{
-						Names:  []*ast.Ident{ast.NewIdent("_")},
-						Values: []ast.Expr{getFullName()},
-					}},
-				}
-			case *types.Var, *types.Func:
-				// var _ = <value>
-				decl = &ast.GenDecl{
-					Tok: token.VAR,
-					Specs: []ast.Spec{&ast.ValueSpec{
-						Names:  []*ast.Ident{ast.NewIdent("_")},
-						Values: []ast.Expr{getFullName()},
-					}},
-				}
-			case *types.TypeName:
-				// var _ <type>
-				decl = &ast.GenDecl{
-					Tok: token.VAR,
-					Specs: []ast.Spec{&ast.ValueSpec{
-						Names: []*ast.Ident{ast.NewIdent("_")},
-						Type:  getFullName(),
-					}},
-				}
-			default:
-				continue // Skip *types.Builtin and other
 			}
-
+		default: // import . "pkg/path"
-			// Manually add a new variable for correct name obfuscation
+			nameExpr = nameIdent
-			tf.info.Uses[nameIdent] = obj
+		}
-			file.Decls = append(file.Decls, decl)
+
-			generated = true
+		switch nameObj.(type) {
-			break
+		case *types.Const:
+			// const _ = <value>
+			decl.Tok = token.CONST
+			spec.Values = []ast.Expr{nameExpr}
+		case *types.Var, *types.Func:
+			// var _ = <value>
+			decl.Tok = token.VAR
+			spec.Values = []ast.Expr{nameExpr}
+		case *types.TypeName:
+			// var _ <type>
+			decl.Tok = token.VAR
+			spec.Type = nameExpr
+		default:
+			continue // skip *types.Builtin and others
 		}
 
-		if !generated {
+		// Ensure that types.Info.Uses is up to date.
-			// A very unlikely situation where there is no suitable declaration for a reference variable
+		tf.info.Uses[nameIdent] = nameObj
-			// and almost certainly means that there is another import reference in code.
+		file.Decls = append(file.Decls, decl)
-			log.Printf("generate reference variable for %s failed", imp.Path.Value)
-		}
 	}
 }
 
@@ -1823,7 +1784,7 @@ func (tf *transformer) transformGoFile(file *ast.File) *ast.File {
 		file = literals.Obfuscate(obfRand, file, tf.info, tf.linkerVariableStrings)
 
 		// some imported constants might not be needed anymore, remove unnecessary imports
-		tf.makeImportsUsed(file)
+		tf.useAllImports(file)
 	}
 
 	pre := func(cursor *astutil.Cursor) bool {