Refactor querying & improve logging #26

This paves the way for room labels derived from more complete data.

Notes:

$KNOWN_PUBKEYS was intended to be alphabetically sorted

[04:22.671] [d] Server http://session.xanthus.uk[0/2] { pubkey: 9be4... }
[04:22.671] [i] Checking reachability for http://session.xanthus.uk first...
[04:22.671] [d] array (
  0 => 'midnight-madness',
  1 => 'catnamedivan',
)
[04:23.052] [d] Attempt #1 for http://session.xanthus.uk returned code 200.

I assume $this->room_hints should be sorted before further handling?

What about this TODO? https://lokilocker.com/gravel/sessioncommunities.online/src/branch/querying-refactor/php/fetch-servers.php#L98

That those are the only issues I have found shows what outstanding work you did with this refactor, thank you.

Notes: 1) `$KNOWN_PUBKEYS` was intended to be alphabetically sorted 2) ``` [04:22.671] [d] Server http://session.xanthus.uk[0/2] { pubkey: 9be4... } [04:22.671] [i] Checking reachability for http://session.xanthus.uk first... [04:22.671] [d] array ( 0 => 'midnight-madness', 1 => 'catnamedivan', ) [04:23.052] [d] Attempt #1 for http://session.xanthus.uk returned code 200. ``` I assume `$this->room_hints` should be sorted before further handling? 3) What about this TODO? https://lokilocker.com/gravel/sessioncommunities.online/src/branch/querying-refactor/php/fetch-servers.php#L98 That those are the only issues I have found shows what outstanding work you did with this refactor, thank you.

There's still the issue of the unsorted $this->room_hints, but that's not important in any way or form as far as I can tell.

Looking good otherwise. Consider this merged.

There's still the issue of the unsorted `$this->room_hints`, but that's not important in any way or form as far as I can tell. Looking good otherwise. Consider this merged.

Labels Milestones

Refactor querying & improve logging #26