You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
session-ios/SignalMessaging
Michael Kirk 6f8eddc955 unread indicator uses sortId
- removed timestamp parameter. This wasn't totally obvious, previously we were tracking two pieces of state

1. `unreadIndicator.firstUnseenTimestamp`:
    the first unseen timestamp for a conversation that exists in the database
2. `unreadIndicator.timestamp`:
    the timestamp of the first interaction *after* the unread indicator that fits in the loading window

We don't actually need to track `2` because it was only used in a comparison like:

   viewItem.interaction.timestampForSorting >= unreadIndicator.timestamp

But by definition, unreadIndicator.firstUnseenTimestamp is always less than or
equal to unreadIndicator.timestamp. Put into terms of the `sortId` corallary,
the sortId of the first unseen interaction in the database is always less than
or equal to the sortId of the first unseen interaction that fits in the loading
window.

In other words, there's no situation where

   viewItem.interaction.sortId >= unreadIndicator.firstUnseenSortId
7 years ago
..
Libraries/JSQMessagesViewController Use StoreKit for reviews 7 years ago
Models minimize diff senderTimestamp -> timestamp 7 years ago
ViewControllers Move more singletons to SSKEnvironment. 7 years ago
ViewModels replace thread.lastMessageDate/archivalDate -> thread.lastSortId, thread.archivedAsOfSortId 7 years ago
Views Merge tag '2.29.3.3' 7 years ago
attachments Merge remote-tracking branch 'origin/release/2.29.2' 7 years ago
categories Tweak gray 95. 7 years ago
contacts Rework creation of singletons. 7 years ago
environment benchmark migration 7 years ago
profiles minimize diff senderTimestamp -> timestamp 7 years ago
utils unread indicator uses sortId 7 years ago
viewControllers Clean up ahead of PR. 8 years ago
Info.plist Shared framework between app and extension 8 years ago
SignalMessaging-Prefix.pch Update assertions. 7 years ago
SignalMessaging.h Remove legacy Error backdating - no changes in functionality 7 years ago