Commit Graph

365 Commits (ff24e826c9af97d6bf81a48bd24a4b18b0a18b6d)

Author SHA1 Message Date
Michael Kirk 448936d156 BlockListCache
block manager synchronizes on self for coherent read/writes to blocking state
across threads, but we want to be able to have performant reads on the main
thread.
7 years ago
Michael Kirk b6eb1476cb Leave group when blocking it 7 years ago
Michael Kirk c6de8c579c WIP: Localizations 7 years ago
Michael Kirk eadb04efcc WIP: ContactViewHelper incorporates group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] ConversationViewHelper
   -[x] Track blocked groups
   -[ ] HomeView
   -[ ] ConversationView
   -[ ] Any others?
   -[ ] Rename? Extract BlockList cache?
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[x] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
7 years ago
Michael Kirk 236c17f65e WIP: group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[ ] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
7 years ago
Matthew Chen cc117b385c Modify environment accessors to use our 'shared' convention. 7 years ago
Matthew Chen 3a12446be8 Modify environment accessors to use our 'shared' convention. 7 years ago
Matthew Chen f9eab5cd24 Merge remote-tracking branch 'origin/release/2.29.2' 7 years ago
Michael Kirk c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
7 years ago
Matthew Chen ac4365e1c9 Add OWSThumbnailService. 7 years ago
Matthew Chen 9ab4da5c81 cherry-pick Merge branch 'charlesmchen/logSdp' 7 years ago
Matthew Chen fac7f6932f Rename TSGroupMetaMessage enum values. 7 years ago
Matthew Chen f473f60111 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen cc5a480baa Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen c0d486b1f1 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 3a50377902 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 0b5b74a901 Respond to CR. 7 years ago
Matthew Chen b4539328e1 Log call session description. 7 years ago
Matthew Chen 2d06c05a4f Log call session description. 7 years ago
Matthew Chen 713606271c Rename fail macros in Obj-C. 7 years ago
Matthew Chen 5b50e81b4f Rename fail macros in Swift. 7 years ago
Matthew Chen cf6f3841a8 Apply new Swift logging. 7 years ago
Michael Kirk bc2ba63c21 DRY refactor 7 years ago
Michael Kirk 37738c24c5 Allow menuActions + callBanner
// FREEBIE
7 years ago
Michael Kirk 82e559d11b Use swift macros for main thread assert 7 years ago
Michael Kirk 1743407cc2 Code cleanup per code review 7 years ago
Michael Kirk 3022f92925 Tweak tint for search bar icons in dark theme 7 years ago
Michael Kirk e435358bfd Revert "Add custom themed search bar."
This reverts commit 8daaef22da.
7 years ago
Matthew Chen 4971d40c75 Respond to CR. 7 years ago
Matthew Chen 9e21612298 Respond to CR. 7 years ago
Matthew Chen 6dd474d794 Theme quoted replies. 7 years ago
Matthew Chen a92fca5c13 Theme quoted replies. 7 years ago
Matthew Chen 8daaef22da Add custom themed search bar. 7 years ago
Matthew Chen 4ea5d9b849 Theme review. 7 years ago
Matthew Chen a76d488e8b Fix QA issues in theme. 7 years ago
Matthew Chen 26001e49d1 Unify log tags. 7 years ago
Michael Kirk 8829cdfb4b Toast view when tapped message doesn't exist, mark remotely sourced. 7 years ago
Michael Kirk c05700fd98 Log in OWSFail
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
7 years ago
Matthew Chen 8ecf6884c5 Remove "sending" color for outgoing messages. 7 years ago
Matthew Chen 5ef0b6d056 Refine theme. 7 years ago
Michael Kirk 2ea7e2b036 CR: clean up preferences 7 years ago
Michael Kirk 0bc03b0fd4 Move seed 7 years ago
Matthew Chen 25a98554b7 Intern JSQMessagesViewController. 7 years ago
Matthew Chen 48975eaac8 Respond to CR. 7 years ago
Michael Kirk d591fb7f2c Fix some compiler warnings 7 years ago
Michael Kirk 7a5f5476db rename to avoid confusion 7 years ago
Michael Kirk 24060c17d0 CR: proper width calculation for header view 7 years ago
Michael Kirk fef6c64bdc decrease header spacing from 32->28.
Previous spacing was based on applying the "full width" gutter spacing twice.
7 years ago
Michael Kirk 1a2428a4b0 CR: leave some wiggle room on max window height. 7 years ago
Michael Kirk bdc8181cbc hide menu view controller when resigning active
// FREEBIE
7 years ago
Michael Kirk dde2fd6f33 Hide menu window when vc dismisses.
Normally this isn't possible, just being paranoid.

// FREEBIE
7 years ago
Michael Kirk 82fdd5b883 Split out generic action sheet components
Keep the message specific components separte, so we could re-use the
MenuActionsViewController.
7 years ago
Michael Kirk 3a157d9df6 window level on iOS11
// FREEBIE
7 years ago
Michael Kirk 635c0275db stop observing db notifications while message actions are presented
This let's new messages appear after the message actions are dismissed without
complicating scroll state.
7 years ago
Michael Kirk 22fada2457 don't dismiss keyboard when presenting actions 7 years ago
Michael Kirk aa98963fd9 Abandonded: separate window pattern
Hiding the old window, caused keyboard to resign first responder.
7 years ago
Michael Kirk 6037a440c9 wire up window mgmt 7 years ago
Matthew Chen 8287076499 More design tweaks. 7 years ago
Matthew Chen 0c420ed28a Tweak appearance. 7 years ago
Matthew Chen 750b935122 Tweak appearance. 7 years ago
Matthew Chen 376e2cc1db Respond to CR. 7 years ago
Matthew Chen 35f058c46a Rework unread indicators. 7 years ago
Matthew Chen ecafe546b6 Rework unread indicators. 7 years ago
Matthew Chen 8d72bb032e Rework unread indicators. 7 years ago
Matthew Chen 8b3bdb88f3 Revert "Merge branch 'charlesmchen/tweakCalls'"
This reverts commit 3e0233ea60, reversing
changes made to 74ce3012cf.
7 years ago
Michael Kirk f22cb48f85 date break font/color to spec
// FREEBIE
7 years ago
Michael Kirk 28abf426f1 White status bar for call screen
Transition to VC controlled status bar style.
7 years ago
Michael Kirk 10ac7be03a prefer localizedUppercaseString for user facing text
// FREEBIE
7 years ago
Michael Kirk 76745bee5b failed background color to spec 7 years ago
Matthew Chen b92fc89986 Retweak date and unread messages breaks. 7 years ago
Matthew Chen a28a5251f6 Respond to CR. 7 years ago
Matthew Chen 4893b01907 Retweak colors. 7 years ago
Matthew Chen 4b448ed018 Retweak colors. 7 years ago
Matthew Chen bbd65d6433 Retweak colors. 7 years ago
Matthew Chen 929615ab0c Tweak sender avatar sizes. 7 years ago
Matthew Chen 1a9a5016fe Tweak calls. 7 years ago
Michael Kirk b301dba4ba cell height to spec 7 years ago
Matthew Chen dd078b106f Tweak message send failed indicator. 7 years ago
Matthew Chen 1412998b4a Rework isRTL. 7 years ago
Matthew Chen 39eac9129b Respond to CR. 7 years ago
Michael Kirk 5719aba91a separate icon vs. title color for toolbars 7 years ago
Michael Kirk 767f06b09f fixup status bar 7 years ago
Michael Kirk 104e63ded9 remove appearance juggling 7 years ago
Michael Kirk f8abe32ae9 more styling to new nav colors 7 years ago
Michael Kirk 5d6a988955 WIP navbar 7 years ago
Michael Kirk 16df4f589e conversation colors
// FREEBIE
7 years ago
Matthew Chen 35dc348551 Move conversation style. 7 years ago
Matthew Chen a34719ce69 Tweak color palette. 7 years ago
Matthew Chen f2153f888b Tweak color palette. 7 years ago
Matthew Chen cbc80abff1 Tweak color palette. 7 years ago
Matthew Chen 63b6276c25 Clear LRUCache in background. 7 years ago
Matthew Chen 08ca4fdb50 Lazy-load contact avatar data and images. Use NSCache for avatar images. 7 years ago
Matthew Chen b9e2963f47 Don't cache CNContact. 7 years ago
Matthew Chen 20b1a2606e Outage detection. 7 years ago
Matthew Chen 776b5abed1 Handle edge cases around unread indicator & contact offers. 7 years ago
Matthew Chen a51e9b78b0 Improve search query construction. 7 years ago
Matthew Chen 95ac17bb7e Merge tag '2.26.0.24' 7 years ago
Michael Kirk 0dec029a69 Don't mark as read when callscreen is active
// FREEBIE
7 years ago
Matthew Chen c8fee4efa7 Add swift logging to SSK. 7 years ago
Matthew Chen 44b23d44fd Respond to CR. 7 years ago
Matthew Chen 99677899b1 Respond to CR. 7 years ago
Matthew Chen f0c1805de9 Strip snippet formatting. 7 years ago
Matthew Chen 9639d3cbae Clean up ahead of PR. 7 years ago
Matthew Chen f4a559156c Style the search results. 7 years ago
Matthew Chen ebc5356a9f Respond to CR. 7 years ago
Matthew Chen 758913f959 Respond to CR. 7 years ago
Matthew Chen 4abd3f58cd Order the search results. 7 years ago
Matthew Chen 8164b893ad Respond to CR. 7 years ago
Matthew Chen 999e8c8e31 Respond to CR. 7 years ago
Matthew Chen 13e9f11b4e Open message search results. 7 years ago
Matthew Chen 27b6a5e5bb Open message search results. 7 years ago
Michael Kirk 549342c702 Show empty results text
// FREEBIE
7 years ago
Michael Kirk ecdaad06ff Handle no results
In line with other messaging apps, we intentionally don't show a "No Results"
cell. We simply don't display any cells. Though we could easily modify this in
the future.

// FREEBIE
7 years ago
Michael Kirk fff8474150 adapt to rebase conflicts 7 years ago
Michael Kirk f415827da6 Contact search results
// FREEBIE
7 years ago
Michael Kirk b3705196b3 remove unused code/comments 7 years ago
Michael Kirk 21788f5f93 Avatar, label fonts, resignFirstResponder on scroll
-[] Backend
  -[] indexes e5.25
    -[x] wire up results: Contacts / Conversations / Messages actual: 3hr
    -[x] group thread est: actual:
      -[x] group name actual: e.25
      -[x] group member name: e.25
      -[x] group member number: e.25
    -[ ] contact thread e.5
      -[ ] name
      -[ ] number
    -[x] messages e1
      -[x] content
-[] Frontend e10.75
  -[x] wire up VC's a.5
  -[x] show search results only when search box has content a.25
  -[] show search results: Contact / Conversation / Messages e2
   -[x] wire up matchs
   -[] style contact cell
   -[] style conversation cell
   -[] style messages cell
  -[] tapping thread search result takes you to conversation e1
  -[] tapping message search result takes you to message e1
  -[x] show snippet text for matched message e1
  -[] highlight matched text in thread e3
  -[] No Results page
7 years ago
Michael Kirk 3a03c4f74c WIP: message indexing 7 years ago
Michael Kirk f360bcfd35 Less confusing class names
-[] Backend
  -[] indexes e5.25
    -[x] wire up results: Contacts / Conversations / Messages actual: 3hr
    -[ ] group thread est: actual:
      -[x] group name actual: e.25
      -[ ] group member name: e.25
      -[ ] group member number: e.25
    -[ ] contact thread e.5
      -[ ] name
      -[ ] number
    -[ ] messages e1
      -[ ] content
-[] Frontend e10.75
  -[x] wire up VC's a.5
  -[x] show search results only when search box has content a.25
  -[] show search results: Contact / Conversation / Messages e2
   -[x] wire up matchs
   -[] style contact cell
   -[] style conversation cell
   -[] style messages cell
  -[] tapping thread search result takes you to conversation e1
  -[] tapping message search result takes you to message e1
  -[] show snippet text for matched message e1
  -[] highlight matched text in thread e3
  -[] go to next search result in thread e2
  -[] No Results page
  -[] Hide search unless pulled down
7 years ago
Michael Kirk a9e2834d9f WIP: FTS - rudimentary show results
-[] Backend
  -[] indexes e5.25
    -[x] wire up results: Contacts / Conversations / Messages actual: 3hr
    -[ ] group thread est: actual:
      -[x] group name actual: e.25
      -[ ] group member name: e.25
      -[ ] group member number: e.25
    -[ ] contact thread e.5
      -[ ] name
      -[ ] number
    -[ ] messages e1
      -[ ] content
-[] Frontend e10.75
  -[x] wire up VC's a.5
  -[x] show search results only when search box has content a.25
  -[] show search results: Contact / Conversation / Messages e2
   -[x] wire up matchs
   -[] style contact cell
   -[] style conversation cell
   -[] style messages cell
  -[] tapping thread search result takes you to conversation e1
  -[] tapping message search result takes you to message e1
  -[] show snippet text for matched message e1
  -[] highlight matched text in thread e3
  -[] go to next search result in thread e2
  -[] No Results page
  -[] Hide search unless pulled down
7 years ago
Michael Kirk ffea3a020f WIP: FTS - wired up Search VC
-[] Backend
  -[] indexes e5.25
    -[x] wire up results: Contacts / Conversations / Messages actual: 3hr
    -[ ] group thread est: actual:
      -[x] group name actual: e.25
      -[ ] group member name: e.25
      -[ ] group member number: e.25
    -[ ] contact thread e.5
      -[ ] name
      -[ ] number
    -[ ] messages e1
      -[ ] content
-[] Frontend e10.75
  -[x] wire up VC's a.5
  -[x] show search results only when search box has content a.25
  -[] show search results: Contact / Conversation / Messages e2
  -[] tapping thread search result takes you to conversation e1
  -[] tapping message search result takes you to message e1
  -[] show snippet text for matched message e1
  -[] highlight matched text in thread e3
  -[] go to next search result in thread e2
7 years ago
Michael Kirk 429af7854a WIP: Full Text Search
-[ ] indexes
  -[x] results: Contacts / Conversations / Messages
  -[ ] group thread
    -[x] group name
    -[ ] group member name
    -[ ] group member number
  -[ ] contact thread
    -[ ] name
    -[ ] number
  -[ ] messages
    -[ ] content
- [ ] show search results: Contact / Conversation / Messages
- [ ] tapping thread search result takes you to conversation
- [ ] tapping message search result takes you to message
- [ ] show snippet text for matched message
- [ ] highlight matched text in thread
- [ ] go to next search result in thread
7 years ago
Matthew Chen 3964b78ff7 Reduce usage of JSQ. 7 years ago
Matthew Chen 3cd6a33aa6 Fix build warnings. 7 years ago
Matthew Chen 4d8c764789 Migrate to Swift 4. 7 years ago
Matthew Chen 77b72b6b06 Migrate to Swift 4. 7 years ago
Matthew Chen 28e26e1f75 Migrate to Swift 4. 7 years ago
Matthew Chen 28f7142a59 Auto-migration to Swift 4. 7 years ago
Matthew Chen c71081c875 Respond to CR. 7 years ago
Matthew Chen fbd03a3fdc Apply design for call view back button. 7 years ago
Michael Kirk fc34a0643c CR: annotate device constants
// FREEBIE
7 years ago
Michael Kirk 20424d9a7e remove debug code, reorder for clarity
// FREEBIE
7 years ago
Michael Kirk 4c9808d1a1 Fix iPhoneX layout show status bar above call banner
// FREEBIE
7 years ago
Michael Kirk 3383c5e80c Fixup for iPhoneX
// FREEBIE
7 years ago
Michael Kirk 778e11c2c3 cleanup ahead of PR
// FREEBIE
7 years ago
Michael Kirk 6c7af671bc call banner above status bar for now 7 years ago
Michael Kirk 29d08545e2 Use OWSNavigationController instead of UINavigationController
- [ ] document picker
- [ ] camera picker
- [ ] image picker
- [ ] restore "confirm to go back" behavior (interactive pop gesture?)

// FREEBIE
7 years ago
Matthew Chen db1c8fd9f3 Respond to CR. 7 years ago
Matthew Chen f436fc19c2 Make contact share "bubble/card" reflect share contents. 7 years ago
Michael Kirk 41aa7eafe3 makeKeyAndVisible restores first responder, so no need to track it
ourselves.

This isn't *quite* as nice for the case when we want to restore a
textfield that was active before, but it much more simply covers the
more important case that we restore input accessory views after
backgrounding/foregrounding.

// FREEBIE
7 years ago
Michael Kirk a10ae1835e respond to code review
// FREEBIE
7 years ago
Matthew Chen 390c0bc201 Send fake contact shares. 7 years ago
Matthew Chen 0316a98eb8 Undo renaming of contactShare property of TSMessage. 7 years ago
Matthew Chen 0d8cfc5403 Rename contact share class to contact. 7 years ago
Matthew Chen 4b8a2fa8a3 Sketch out "contact share" model. 7 years ago
Michael Kirk 7a1d24a9ab Avatar updates when contact/profile/group photo changes
// FREEBIE
7 years ago
Matthew Chen 9275c67818 Rework outgoing message state. 7 years ago
Matthew Chen 7912598ccb Merge branch 'release/2.24.0' 7 years ago
Matthew Chen 08d36aa862 Add screen lock UI to SAE. 7 years ago
Michael Kirk eec7678979 Group's meta message defaults to "Delivery"
// FREEBIE
7 years ago