Commit Graph

1368 Commits (eb68c19472c1cfd59a1865daf78f8d46e11bda81)

Author SHA1 Message Date
Matthew Chen 4022ba1a16 Fix translation in crop editor's pan gesture. 5 years ago
Matthew Chen 72082edad8 Fix a visual bug that would sometimes occur while rendering settings switches. Thanks to Gunnar C. Pope for the bug report. 5 years ago
Michael Kirk f1623b6037 missing nullability text 5 years ago
Michael Kirk 7e5256856c render media+longText message 5 years ago
Michael Kirk b7989e9384 feature flag approval sending 5 years ago
Michael Kirk bc4260b444 Send long-text with other attachments 5 years ago
Michael Kirk a218d6c465 Send first chars of longtext in protobuf 5 years ago
Michael Kirk 680b844f3c Allow all windows to do landscape, fixes:
1. Remove undesirable animation from portrait->landscape when minimizizing in
   landscape and relaunching in landscape.

2. This also seems to fix the intermittently misplaced toolbar when launching
   in landscape. I believe this is a consequence of fix #1
5 years ago
Michael Kirk 7a4041cdde Cache dark theme preference
This is a hot path
5 years ago
Michael Kirk fabd3996c2 pop view if message is deleted
- use global ui database connection
5 years ago
Matthew Chen 9402e088b2 Apply design feedback from Myles. 5 years ago
Matthew Chen 93e09be18e Apply design feedback from Myles. 5 years ago
Matthew Chen aa8fd9e69c Remove old registration views. 6 years ago
Matthew Chen 8ecad88674 Move the accessibility identifier macros into UIUtil.h. 6 years ago
Matthew Chen 4d4b840787 Respond to CR. 6 years ago
Matthew Chen ef5cd5344e Fix the auto-format of phone numbers in the onboarding views. 6 years ago
Matthew Chen edf09c92f4 Rework "empty inbox" state. 6 years ago
Matthew Chen 1f922aa478 Sketch out the 'onboarding code verification' view. 6 years ago
Matthew Chen 05d63fd6b5 Update font sizes in onboarding views. 6 years ago
Matthew Chen 8cfe768e86 Update font sizes in onboarding views. 6 years ago
Matthew Chen b658866319 Sketch out the 'onboarding phone number' view. 6 years ago
Matthew Chen 2a4b9426c3 Sketch out the 'onboarding phone number' view. 6 years ago
Matthew Chen c0f907c441 Respond to CR. 6 years ago
Matthew Chen 69c5492fce Clean up ahead of PR. 6 years ago
Matthew Chen 331a013f8d Clean up ahead of PR. 6 years ago
Matthew Chen 618a3b1d47 Sketch out crop tool. 6 years ago
Matthew Chen 54c8c1f352 Sketch out the onboarding splash view. 6 years ago
Matthew Chen 2c0aa7a222 Sketch out the onboarding permissions view. 6 years ago
Matthew Chen 73b36c5400 Respond to CR. 6 years ago
Matthew Chen 6ac2dd7ea1 First draft of image editor's text tool. 6 years ago
Matthew Chen 3f8ea271b4 First draft of image editor's text tool. 6 years ago
Michael Kirk cc2e062b85 CR: clean up graphics context code 6 years ago
Michael Kirk 2323cc21f0 note-to-self avatar 6 years ago
Michael Kirk d29ce740cb Voice Note Lock 6 years ago
Matthew Chen ea547fa46a Merge tag '2.35.0.12' 6 years ago
Michael Kirk d88ffc4775 Notification titles for iOS10+ 6 years ago
Michael Kirk fe84275cce Respect audio preferences/throttling 6 years ago
Michael Kirk 1bfe691895 In app notifications for iOS10+
Extract shared notification presention/response

Implement adapters which use that logic for modern UNUserNotification and
legacy UINotifications
6 years ago
Matthew Chen 6bfe0f0418 Ensure 'link new device' view is portrait. 6 years ago
Matthew Chen 7a990ed1ff Ensure 'link new device' view is portrait. 6 years ago
Matthew Chen 6b5952abda Move work off main thread. 6 years ago
Matthew Chen 12e57ecd25 Improve background screenshots v. orientation. 6 years ago
Matthew Chen 4be302bbea Update link previews setting behavior. 6 years ago
Matthew Chen 77396e11fd Send sync messages with link previews preference. 6 years ago
Matthew Chen 910df7069c Link previews migration. 6 years ago
Matthew Chen 7f2ca60615 Link previews migration. 6 years ago
Matthew Chen 2b71c433ac Update appearance of draft quoted replies. 6 years ago
Matthew Chen ccb174120f Tweak conversation input toolbar layout. 6 years ago
Matthew Chen 39de96ac26 Re-enable landscape orientation; fix 'double activation' issue. 6 years ago
Matthew Chen c359f2b708 Replace "connecting/sonar ping" with "outbound ringing." 6 years ago
Matthew Chen c02d633272 Align draft view of link preview and draft view of quoted reply. 6 years ago
Matthew Chen 9149282e94 Resize link preview images if necessary. 6 years ago
Matthew Chen 4e7dbc486d Segment proxied content downloads. 6 years ago
Matthew Chen 82ceb044e3 Use link preview image when quote replying. 6 years ago
Matthew Chen 9b7ae86a6d Rework layout of conversation input toolbar. 6 years ago
Matthew Chen 6ff6ee2e2e Rework layout of conversation input toolbar. 6 years ago
Matthew Chen 3d757b492a Add link previews to conversation message bubbles. 6 years ago
Matthew Chen 8c7c9b27a2 Merge tag '2.34.0.26' 6 years ago
Michael Kirk 896a9f78f7 limit media message body to 2k chars 6 years ago
Michael Kirk 599a57e3a4 Pan horizontal to bulk select images 6 years ago
Michael Kirk 169581f12f show toast when selecting too many items 6 years ago
Matthew Chen 977ee9ffe9 Merge remote-tracking branch 'private/release/2.34.0' 6 years ago
Matthew Chen 2dcc79fbca Fix issues around link previews. 6 years ago
Matthew Chen 8e44bf554c Respond to CR. 6 years ago
Matthew Chen d775a70a89 Build link previews. 6 years ago
Matthew Chen 31ea64bdaf Build link previews. 6 years ago
Matthew Chen 7878c0fac8 Add feature flag for 'note to self'. 6 years ago
Michael Kirk 721f330296 warm non-signal accounts cache in the background 6 years ago
Matthew Chen debf2e7a95 Fix 'mutation during enumeration' and 'bad ordering' crashes. 6 years ago
Michael Kirk 0fb6dab020 avoid blocking write connection with long running read when building sync message 6 years ago
Michael Kirk 3c0982e0f9 Fix missing captionView when navigating via RailView 6 years ago
Michael Kirk 0c1b2e9f48 CR: remove unnecessary param, clearer code, comment typo 6 years ago
Michael Kirk 6e50a5353b rename for clarity 6 years ago
Matthew Chen be714399c7 Add feature flag for landscape orientation. 6 years ago
Matthew Chen eab3599ce9 Add feature flag for landscape orientation. 6 years ago
Michael Kirk b4908e71e9 Use FTS for compose picker search 6 years ago
Matthew Chen 635a644e2f Fix safe area insets in SAE. 6 years ago
Matthew Chen 50f9a089bf Fix navbar layout in share extension. 6 years ago
Matthew Chen a477e01a4a Apply LinkPreview model. 6 years ago
Matthew Chen efd1be30c7 Cull unknown migrations. 6 years ago
Michael Kirk 0e78f9912b bump migration version 6 years ago
Matthew Chen bf0d92acfb Landscape layout in gif picker. 6 years ago
Matthew Chen 4ab0c8fe58 Landscape orientation. 6 years ago
Matthew Chen 2ddde368ec Landscape orientation. 6 years ago
Matthew Chen 5adcbac5ef Landscape orientation. 6 years ago
Matthew Chen 460f160cbb Landscape orientation. 6 years ago
Michael Kirk 099b9f60c3 enable multisend 6 years ago
Michael Kirk 0ab326da92 Only show delete button on selected rail item 6 years ago
Matthew Chen c0922fc2c0 Remove LockInteractionController. 6 years ago
Michael Kirk 265552ae0e enable multisend in debug 6 years ago
Michael Kirk c690ac2710 allow deselecting tool 6 years ago
Michael Kirk a8200d6f4a Fix swipe between multi-images
gesture shouldn't be enabled until tool has been selected
6 years ago
Matthew Chen 5e3de84fdc Add feature flag for image editor. 6 years ago
Matthew Chen 9ab8bec2b1 Fix searching for 'note to self'. 6 years ago
Matthew Chen fc8fbebd97 Note to Self. 6 years ago
Matthew Chen 8aa68327e6 Add primitive color picker. 6 years ago
Matthew Chen a440f692ce Clean up image editor temp files. 6 years ago
Matthew Chen b24e8e4f81 Use autoreleasepool when rendering image editor output. 6 years ago
Matthew Chen 2b25d875bc Don't select a tool by default in image editor view. 6 years ago
Matthew Chen 5dcde44486 Image editor fixes. 6 years ago
Matthew Chen 17c3ba0580 Image editor fixes. 6 years ago
Michael Kirk 3151e6e1a3 move string extensions up 6 years ago
Michael Kirk df79fc9ed0 Move String+OWS into SSK
name Switcharoo String+OWS/String+SSK categories to reflect where they live.
6 years ago
Michael Kirk a0770c14c5 baseline perf test for migration 6 years ago
Michael Kirk af7ee5e1d1 address compiler breakage after rebase 6 years ago
Michael Kirk 45e572e82f assert monotonic order for migration 6 years ago
Michael Kirk 5671fd2520 Revert "Revert 'new sort id'."
This reverts commit ebae75af00.
6 years ago
Matthew Chen 35b6f6cf12 Respond to CR. 6 years ago
Matthew Chen db8bc58b6d Implement crop. 6 years ago
Matthew Chen 57f888a447 Add crop gesture. 6 years ago
Matthew Chen 03cbeb5fee Start working on crop. 6 years ago
Matthew Chen 2f95413bcf Use narrow change events in image editor. 6 years ago
Matthew Chen f224c2130a Suppress undo during strokes. 6 years ago
Matthew Chen cf1763e79d Suppress undo during strokes. 6 years ago
Matthew Chen 3d67c6574d Suppress undo during strokes. 6 years ago
Matthew Chen 9378ab2192 Add undo/redo buttons to image editor. 6 years ago
Matthew Chen bd40aacd53 Purge dynamic interactions from database. 6 years ago
Matthew Chen d1cf942f7e Respond to CR. 6 years ago
Matthew Chen 825826aa05 Reduce jitter with smoothing. 6 years ago
Matthew Chen b8775006bb Clean up ahead of PR. 6 years ago
Matthew Chen 794241963e Clean up ahead of PR. 6 years ago
Matthew Chen da13dc1d2e Clean up ahead of PR. 6 years ago
Matthew Chen bf734d5959 Clean up ahead of PR. 6 years ago
Matthew Chen 04cd6c3495 Clean up ahead of PR. 6 years ago
Matthew Chen 639dac4e26 Add stroke drawing to the image editor. 6 years ago
Matthew Chen b0e0c6e8c2 Replace edited attachments when sending. 6 years ago
Matthew Chen 2f7e99de46 Smooth stroke rendering. 6 years ago
Matthew Chen e2afe27f5e Add trivial test interaction to image editor. 6 years ago
Matthew Chen 0d81139be5 Debug scaffolding. 6 years ago
Matthew Chen 4752cb94f5 Add ImageEditorView. 6 years ago
Matthew Chen 04440ed1e6 Add ImageEditorStrokeItem. 6 years ago
Matthew Chen 8704ffe93c Sketch out image editor undo/redo. 6 years ago
Matthew Chen 57232683fc Sketch out image editor undo/redo. 6 years ago
Matthew Chen f95526bff7 Start sketching out image editor. 6 years ago
Matthew Chen 26a25f861b Start sketching out image editor. 6 years ago
Michael Kirk fd6a56b3af format bench in ms 6 years ago
Michael Kirk 6232b1ef67 CR: add debug asserts 6 years ago
Michael Kirk 81bc357bbb more robust handling of unsaved outgoing messages 6 years ago
Michael Kirk 668cc22af3 Perf: Insert outgoing message into conversation before save completes.
This was a huge savings - e.g. 50-70% of the time between tapping send and
rendering the message takes place in the save/postWriteTransaction blocks
6 years ago
Michael Kirk 67cc1027cc Fix compiler warnings 6 years ago
Michael Kirk ac2c9cc521 Benchmark Events by ID 6 years ago
Matthew Chen 19a2bfeaad More conversation viewmodel perf improvements. 6 years ago
Matthew Chen fea40d571c Move contact offers to Conversation view model. 6 years ago
Matthew Chen d717ee5411 Parse and apply profile fetches off main thread. 6 years ago
Michael Kirk 6ece45a2e4 toggle multisend feature flag 6 years ago
Michael Kirk c0cb7df10a rename hasEverHadMessage -> shouldThreadBeVisible 6 years ago
Michael Kirk b7ab036c04 warn_unused_result on AnyPromise methods 6 years ago
Matthew Chen 48bd0cfa06 Add missing retains to promises. 6 years ago
Michael Kirk 858ba6ef37 fix missing video thumbnails in approval view 6 years ago
Michael Kirk 3e48ed105d keyboard is always dark in attachment approval 6 years ago
Michael Kirk 2f92995cd6 Add placeholder text to message input field 6 years ago
Michael Kirk eb96eec94a Merge branch 'release/2.32.0' 6 years ago
Michael Kirk 34737567c2 fix voice over for settings bar button item 6 years ago
Michael Kirk de73c220da increment version canary 6 years ago
Michael Kirk 1a5c47df2f Fix SAE, limit max attachments 6 years ago
Matthew Chen d70aa4418f Merge branch 'release/2.32.0' 6 years ago
Matthew Chen 894fd1379c Fix spurious assert. 6 years ago
Matthew Chen aa4fea64cf Improve Profiles Debug UI. 6 years ago
Matthew Chen d6ca969c62 Backup local profile. 6 years ago
Matthew Chen c7f5047056 Handle iCloud status. 6 years ago
Michael Kirk 128bb9be8c Merge tag '2.32.0.17' 6 years ago
Michael Kirk 71ab5817eb fix captionview visibility 6 years ago
Matthew Chen c5744321ba Backup misc collections. 6 years ago
Matthew Chen 4556025566 Update migrations. 6 years ago
Michael Kirk 61758dcf05 Only show caption for multiple images 6 years ago
Michael Kirk 0ac8f13c0b remove redunant method, consolidate naming, adding array getter 6 years ago
Michael Kirk 6fdd5d1001 dont initializer pagerScrollView as sideEffect 6 years ago
Michael Kirk 9bcc6a6c57 show navbar for photo/album picker, not approval 6 years ago
Matthew Chen dcaaff7eac Add isRegisteredAndReady to TSAccountManager. 6 years ago
Matthew Chen 8110e0c765 Clean up usage of TSAccountManager. 6 years ago
Michael Kirk 26ca47b511 Avoid CaptionTextView animation glitch while dismissing MessageTextView 6 years ago
Michael Kirk 78c74d87bc Merge tag '2.32.0.16' 6 years ago
Michael Kirk 9317ee9c99 design comment 6 years ago
Michael Kirk e3120a5b87 cleanup keyboard animation code 6 years ago
Michael Kirk 0562619ca9 smaller margins between rail images, avoid choppy change as the margin updates
are not being animated smoothly.
6 years ago
Michael Kirk 55807f9a4d iPhoneX compatible keyboard animations 6 years ago
Michael Kirk 279694e704 keyboard animation cleanup 6 years ago
Michael Kirk 0808458392 fix caption dismiss animation/placeholder for multiline message body 6 years ago
Michael Kirk 4f1f09f231 Use snapshot view to avoid momentary missing bottomToolbar while switching
firstResponder from CaptionView to AttachmentApprovalViewController.
6 years ago
Michael Kirk 3bfda7ea81 Smooth kbd dismiss: avoid bouncing CaptionView due to quick transition of firstResponder 6 years ago
Michael Kirk b108f284bd WIP: hide caption keyboard
It's tricky because we're hopping from one first responder to another.

Specifically, from the CaptionView.textView, which shows the keyboard, to
making the AttachmentApprovalViewController first responder, which shows the
BottomToolbar message text field, so in short order, we're getting multiple
notifications.

User hit's "Done" with caption

- Point A - CaptionView is positioned at the top of the keyboard
- Hide keyboard (frame change details must be calculated by y offset, since willChanage notification doesn't "shrink" the keyboard frame, it just offsets it to be non-visible.
- Point B - caption view is positioned at the bottom of the screen, input accessory view not visible
- Show Keyboard (not actually showing the *keyboard* here, but rather the VC's input accessory view)
- Point C - caption view is positioned atop the input accessory view

We want to animated smoothly from A->C, skipping B. But how do we do that robustly? We could track something like "last known input accessory view height" and never present the captionView below that. But I'm worried it won't be very robust since the input accessory view can change height, e.g. text view grows with text content or dynamic text changes.
6 years ago
Michael Kirk 838012d1ec Caption length limit and label 6 years ago
Michael Kirk e0f7513df0 white tint for attachment approval textview cursors 6 years ago
Michael Kirk a946ec0056 new icon assets per design 6 years ago
Michael Kirk 8776dd1909 New "add caption" and "done" assets 6 years ago
Michael Kirk feb5a0c444 fix initial CaptionView layout glitch 6 years ago
Michael Kirk e65eeff0fd Keyboard should cover _Caption_ TextView when _Message_ TextView becomes first responder. 6 years ago
Michael Kirk 33750baf67 finally got dismiss-before-swipe 6 years ago
Michael Kirk dd82803a10 second abandoned attempt to require dismiss before page 6 years ago
Michael Kirk b98b3d1fdd WIP: require dismiss before swipe 6 years ago
Michael Kirk 706dd3d0c1 initial layout of keyboard is correct across pages 6 years ago
Michael Kirk 280664c763 WIP: keyboard 6 years ago
Michael Kirk eed2558050 Avoid glitch in keyboard dismiss.
iOS adjusts the inputAccessoryView's host input views layout margins when
popping/dismissing the keyboard, which causes a noticeable glitch.
6 years ago
Michael Kirk 8b5d1d9e69 Only add delete button once 6 years ago
Michael Kirk 28f8fc5911 per cr, avoid unnecessary 6 years ago
Michael Kirk fcc4b516a5 fix typo in logging 6 years ago
Michael Kirk 4f0092615a Support captions *and* independent message body 6 years ago
Michael Kirk cd88ef2bec CaptionView text field per page 6 years ago
Michael Kirk 79995cc52c rename captioning -> messageText
TODO
-[] caption field per photo, separate from album message
-[] caption field sticks to keyboard on becoming first responder
-[] swipe updates caption field (not album message)
-[] limit caption length to 240 chars
-[] add more asset

TODO picker
-[] Done becomes "next"
-[] shared navbar, album picker doesn't cover entire screen
-[] new selected checkmark asset
6 years ago
Michael Kirk 47affb81c0 Move gallery rail into input accessory view
TODO

-[] caption field per photo, separate from album message
-[] caption field sticks to keyboard on becoming first responder
-[] swipe updates caption field (not album message)
-[] limit caption length to 240 chars
-[] add more asset

TODO picker
-[] Done becomes "next"
-[] shared navbar, album picker doesn't cover entire screen
-[] new selected checkmark asset
6 years ago