Uniform logging, removing redundant logging wherever possible, to add
details about what kind of message was received.
In particular, with calls, when there are lots of messages going back
and forth, this makes it easier to make sense of what's being exchanged.
// FREEBIE
No need to use contactThread method to get recipient ID since we still
have the envelope.
And with that, it's pretty easy to justify getting rid of one of our now
barely used IncomingMessage initializers.
// FREEBIE
And run all non-cipher code on the main thread.
Note: Running encryption on the sessionCipher queue is more about
serializing access to session mutations than it is about any performance
gains.
// FREEBIE
From nameStringForPhoneIdentifier
To displayNameForPhoneIdentifier
* Add nullability descriptions
* Fix the mock object to adhere to new nullability rules
// FREEBIE
Motivation
----------
We were often swallowing errors or yielding generic errors when it would
be better to provide specific errors.
We also didn't create an attachment when attachments failed to send,
making it impossible to show the user what was happening with an
in-progress or failed attachment.
Primary Changes
---------------
- Funnel all message sending through MessageSender, and remove message sending
from MessagesManager.
- Record most recent sending error so we can expose it in the UI
- Can resend attachments.
- Update message status for attachments, just like text messages
- Extracted UploadingService from MessagesManager
- Saving attachment stream before uploading gives uniform API for send vs.
resend
- update status for downloading transcript attachments
- TSAttachments have a local id, separate from the server allocated id
This allows us to save the attachment before the allocation request. Which is
is good because:
1. can show feedback to user faster.
2. allows us to show an error when allocation fails.
Code Cleanup
------------
- Replaced a lot of global singleton access with injected dependencies to make
for easier testing.
- Never save group meta messages. Rather than checking before (hopefully) every
save, do it in the save method.
- Don't use callbacks for sync code.
- Handle errors on writing attachment data
- Fix old long broken tests that weren't even running. =(
- Removed dead code
- Use constants vs define
- Port flaky travis fixes from Signal-iOS
// FREEBIE
* Maps numbers to names in TSGroupModel
Use an injected ContactsManager to look up proper user names for phone numbers in [TSGroupModel getInfoStringAboutUpdateTo].
FixesWhisperSystems/Signal-iOS#757
* Supports custom messages for TSOutgoingMessage
This will enable Signal-iOS to push detailed information about TSGroupModel updates through SignalServiceKit and into the TSInfoMessage created by TSMessagesManager+sendMessages
// FREEBIE
In coordination with Desktop and Android, iOS will be using all-numeric
fingerprints, aka "Safety Numbers".
Furthermore, the concept of verifying one identity and then the other
has been removed. Instead we ask users to exchange a single number, or
scan a single QR code. These credentials are built by combining the
users identities.
// FREEBIE
Initially we don't have device messages for our remote device. We need to send the empty device list to get the updated list of remote devices.
Introduced lots of dependency injection to make MessagesManager more testable.
// FREEBIE
* Don't attempt to send a message unless we've successfully built a deveice-messages
* Only process message exception when we're done with retries.
// FREEBIE