Commit Graph

10024 Commits (e0f20bc8d587d6f029e54f4e458c79d824dc1c62)
 

Author SHA1 Message Date
Michael Kirk 61758dcf05 Only show caption for multiple images 6 years ago
Michael Kirk 0ac8f13c0b remove redunant method, consolidate naming, adding array getter 6 years ago
Michael Kirk 6fdd5d1001 dont initializer pagerScrollView as sideEffect 6 years ago
Michael Kirk f9b1b2f360 Merge branch 'mkirk/photo-picker-scroll-to-bottom' 6 years ago
Michael Kirk 69e8b187ad only scroll down once 6 years ago
Michael Kirk 1a43498c2e update masks for "always dark" media views 6 years ago
Michael Kirk 83c156f9e6 Scroll photo-picker to bottom 6 years ago
Michael Kirk e9ab2a8117 Merge branch 'mkirk/spurious-crash-logs' 6 years ago
Michael Kirk 7aad3a9e7a Avoid spurious crash reporting 6 years ago
Michael Kirk 2c344f6a5b Merge branch 'mkirk/photopicker-design' 6 years ago
Michael Kirk 9bcc6a6c57 show navbar for photo/album picker, not approval 6 years ago
Matthew Chen 753c88437f Merge branch 'charlesmchen/iCloudVsMultipleBackups' 6 years ago
Matthew Chen 1c012e9a23 Respond to CR. 6 years ago
Matthew Chen e23773ed2c Support multiple backups in single iCloud account. 6 years ago
Matthew Chen c86518e44c Support multiple backups in single iCloud account. 6 years ago
Matthew Chen df25301d57 Merge branch 'charlesmchen/longLivedBackup' 6 years ago
Matthew Chen 7fab42abf4 Use long-lived operations for CK backup. 6 years ago
Matthew Chen 0eafb8dc34 Use long-lived operations for CK backup. 6 years ago
Matthew Chen ba3a1863da Use long-lived operations for CK backup. 6 years ago
Matthew Chen 018fe6cb42 Merge branch 'charlesmchen/backupRestoreView' 6 years ago
Matthew Chen e3363ab9a1 Add isRegisteredAndReady to TSAccountManager. 6 years ago
Matthew Chen 8ad58e3357 Respond to CR. 6 years ago
Matthew Chen dcaaff7eac Add isRegisteredAndReady to TSAccountManager. 6 years ago
Matthew Chen 70b2280aa7 Add isRegisteredAndReady to TSAccountManager. 6 years ago
Matthew Chen 8110e0c765 Clean up usage of TSAccountManager. 6 years ago
Matthew Chen d44a8f9996 Sketch out the backup restore view. 6 years ago
Matthew Chen 156aa8419f Clean up ahead of PR. 6 years ago
Matthew Chen 4ee0958384 Sketch out the backup restore view. 6 years ago
Matthew Chen 56fe3663e6 Fix retain cycle in settings views. 6 years ago
Matthew Chen f40b81ca4c Sketch out the backup restore view. 6 years ago
Matthew Chen 03f598a130 Sketch out the backup restore view. 6 years ago
Matthew Chen 332f202a52 Sketch out the backup restore view. 6 years ago
Matthew Chen 5010b027b1 Sketch out the backup restore view. 6 years ago
Matthew Chen 5c0d98b83a Show 'restore backup' view after registration. 6 years ago
Michael Kirk b2d75eb1ae "Bump build to 2.33.0.0." 6 years ago
Michael Kirk d7f94b6d16 Merge branch 'mkirk/fix-resign-animation' 6 years ago
Michael Kirk 26ca47b511 Avoid CaptionTextView animation glitch while dismissing MessageTextView 6 years ago
Michael Kirk 78c74d87bc Merge tag '2.32.0.16' 6 years ago
Michael Kirk d9942aa5eb Merge branch 'mkirk/multisend-design' 6 years ago
Michael Kirk 9317ee9c99 design comment 6 years ago
Michael Kirk e3120a5b87 cleanup keyboard animation code 6 years ago
Michael Kirk 0562619ca9 smaller margins between rail images, avoid choppy change as the margin updates
are not being animated smoothly.
6 years ago
Michael Kirk 55807f9a4d iPhoneX compatible keyboard animations 6 years ago
Michael Kirk 279694e704 keyboard animation cleanup 6 years ago
Michael Kirk 0808458392 fix caption dismiss animation/placeholder for multiline message body 6 years ago
Michael Kirk 4f1f09f231 Use snapshot view to avoid momentary missing bottomToolbar while switching
firstResponder from CaptionView to AttachmentApprovalViewController.
6 years ago
Michael Kirk 3bfda7ea81 Smooth kbd dismiss: avoid bouncing CaptionView due to quick transition of firstResponder 6 years ago
Michael Kirk b108f284bd WIP: hide caption keyboard
It's tricky because we're hopping from one first responder to another.

Specifically, from the CaptionView.textView, which shows the keyboard, to
making the AttachmentApprovalViewController first responder, which shows the
BottomToolbar message text field, so in short order, we're getting multiple
notifications.

User hit's "Done" with caption

- Point A - CaptionView is positioned at the top of the keyboard
- Hide keyboard (frame change details must be calculated by y offset, since willChanage notification doesn't "shrink" the keyboard frame, it just offsets it to be non-visible.
- Point B - caption view is positioned at the bottom of the screen, input accessory view not visible
- Show Keyboard (not actually showing the *keyboard* here, but rather the VC's input accessory view)
- Point C - caption view is positioned atop the input accessory view

We want to animated smoothly from A->C, skipping B. But how do we do that robustly? We could track something like "last known input accessory view height" and never present the captionView below that. But I'm worried it won't be very robust since the input accessory view can change height, e.g. text view grows with text content or dynamic text changes.
6 years ago
Michael Kirk 838012d1ec Caption length limit and label 6 years ago
Michael Kirk e0f7513df0 white tint for attachment approval textview cursors 6 years ago