Commit Graph

544 Commits (caeb97b466676d5ece36a179e2aeb389c61e6eb9)

Author SHA1 Message Date
Michael Kirk 81268012e5 Better keyboard management.
- fixes problems on iOS11.2 where emoji keyboard sometimes obscures text
  input.
- better animation for interactive pan gesture when viewing message
  details
- more intuitive swipe-to-dismiss keyboard in conversation view
- converge on one mnethod for dismissing keyboard in conversation view

- [ ] Pop keyboard, then hit attachment, dismisses keyboard, which is
      fine, but the content should immediately scroll down with the
      keyboard, instead it stays up, and scrolls down only once the
      attachment action sheet has been dismissed.

// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf 6e2d9c8141 identity change vs. share extension
// FREEBIE
7 years ago
sdkjfhsdkjhfsdlkjhfsdf 8141843f27 comment typo 7 years ago
sdkjfhsdkjhfsdlkjhfsdf 92477c78b7 cleanup before PR 7 years ago
Michael Kirk bce18637f0 render attachments with captions
// FREEBIE
7 years ago
Michael Kirk e20f44024c WIP: Support sending attachment captions
Looks fine on other clients, but locally we don't display the caption.

// FREEBIE
7 years ago
Matthew Chen 05100b1143 Respond to CR. 7 years ago
Matthew Chen 6b0e3508a5 Respond to CR. 7 years ago
Matthew Chen 245304116f Respond to CR. 7 years ago
Matthew Chen 085f8a6f64 Clean up ahead of PR. 7 years ago
Matthew Chen 70926d7f10 Clean up ahead of PR. 7 years ago
Matthew Chen 6b58b4cbde Rework database view registration. 7 years ago
Matthew Chen fe67cd924c Rework database view registration. 7 years ago
Matthew Chen f88b954ab5 Clean up TSStorageManager usage. 7 years ago
Matthew Chen d3efb2e1c9 Clean up TSStorageManager usage. 7 years ago
Matthew Chen d52eba739d Clean up TSStorageManager usage. 7 years ago
Matthew Chen 85686d3144 Continue TSStorageManager refactor. 7 years ago
Matthew Chen 9a990b58e8 Respond to CR. 7 years ago
Matthew Chen 1163e76dee Clean up ahead of PR. 7 years ago
Matthew Chen 9815bca825 Clean up ahead of PR. 7 years ago
Matthew Chen 5dcf4b3bbc Clean up ahead of PR. 7 years ago
Matthew Chen 137fe6fb8b Pull out OWSStorage base class for TSStorageManager. 7 years ago
Matthew Chen a29c4ce5d6 Pull out OWSStorage base class for TSStorageManager. 7 years ago
Matthew Chen a572285ad2 Respond to CR. 7 years ago
Matthew Chen 2cc3752901 Improve background task logic. 7 years ago
Matthew Chen c3b6de4f83 Improve background task logic. 7 years ago
Matthew Chen f9ce34f553 Improve background task logic. 7 years ago
Matthew Chen 5adf98788d Use background task during message processing. 7 years ago
Matthew Chen df8ded90b8 Use background task during attachment downloads. 7 years ago
Michael Kirk 157bf00410 Merge branch 'hotfix/2.19.3' 7 years ago
Michael Kirk e78edcde87 Only clear cache when user pulls-to-refresh
// FREEBIE
7 years ago
Michael Kirk f4e471e0db SignalAccount cache perf improvments
- only persist models that have changed
- remove duplicate contact SignalAccounts
- ensure serial execution of buildAccounts
- only buildSignalAccounts when intersection succeeds

// FREEBIE
7 years ago
Matthew Chen 3643414da1 Respond to CR. 7 years ago
Matthew Chen f57c12f34d Update YapDatabase. 7 years ago
Matthew Chen 571840b1dc Update YapDatabase. 7 years ago
Matthew Chen 609536fcb1 Include build version in logging. 7 years ago
Michael Kirk 16448e2a0b Merge tag '2.19.3.0' 7 years ago
Michael Kirk 64e90d29fd CR: extract method, more asserts and annotations
// FREEBIE
7 years ago
Michael Kirk 336c92ddab remove cached display name machinery, cleanup
// FREEBIE
7 years ago
Michael Kirk 7ea4b85a2a Persist signal accounts (and their embedded Contact)
// FREEBIE
7 years ago
Michael Kirk 56f1bf0305 cleanup 7 years ago
Matthew Chen b9b3eb0541 Clean up ahead of PR. 7 years ago
Matthew Chen 429312523f Simplify OWSUserProfile's "apply changes" logic using model diffing. 7 years ago
Matthew Chen f684482c54 Don't emit "user profile changed" notifications if nothing changed. 7 years ago
Matthew Chen 97ce1a6675 Rework user profile saves; block SAE if no local user profile key. 7 years ago
Matthew Chen 791743a5f0 Fix order of operations in SAE setup. 7 years ago
Matthew Chen f148003fb3 Convert logTag to property. 7 years ago
Matthew Chen 99f0b9d3e8 Fix issues around statics. 7 years ago
Michael Kirk 0429836ff9 CR: rename keyWindow -> keyReferenceView, split long line
// FREEBIE
7 years ago
Michael Kirk eca19e5874 Reconcile MediaMessageView zoom behavior with AppExtension
Previously it was predicated on UIApplication.shared

// FREEBIE
7 years ago
Michael Kirk 3eceb86371 Show alert if we fail to build the attachment
// FREEBIE
7 years ago
Michael Kirk 89b9887f1d Make DeviceSleepManager extension compatible
// FREEBIE
7 years ago
Michael Kirk a58f1f385c Share a photo from photos app
Shows the conversation picker, and sends the attachment to that
conversation.

There's still a lot TODO

-[ ] resolve JSQ dependency
-[ ] properly wait for app to load
-[ ] dismiss share extension after send is complete
-[ ] support non jpeg file types
-[ ] Fix device sleep manager

// FREEBIE
7 years ago
Matthew Chen 69e0bcd308 Fix tests. 7 years ago
Matthew Chen f5353fc7d5 Clean up ahead of PR. 7 years ago
Matthew Chen 150f417a5e Clean up ahead of PR. 7 years ago
Matthew Chen 022b2f93dd Respond to CR. 7 years ago
Matthew Chen e94ef01d72 Respond to CR. 7 years ago
Matthew Chen 9da165b846 Continue conversion of app setup. 7 years ago
Matthew Chen ce899edf10 Respond to CR. 7 years ago
Matthew Chen b4e8df79da Migrate environment to SignalMessaging. 7 years ago
Matthew Chen a16058e477 Migrate environment to SignalMessaging. 7 years ago
Matthew Chen 6d87df88aa Migrate environment to SignalMessaging. 7 years ago
Matthew Chen c817aa51b3 Migrate environment to SignalMessaging. 7 years ago
Michael Kirk 06f52deaf9 address some additional compiler warnings 7 years ago
Michael Kirk 23d3006fd8 remove unused code
// FREEBIE
7 years ago
Michael Kirk 08c324f948 Fix compiler warnings around ambiguous macro redefinition.
LMK if there's a better way to do this, which doesn't involve requiring
modules.

// FREEBIE
7 years ago
Michael Kirk 2af818b3ba Make SignalMessaging AppExtension safe
// FREEBIE
7 years ago
Michael Kirk 0138777343 New @available syntax avoids compiler warnings
// FREEBIE
7 years ago
Michael Kirk f96b7bc27c CNContact doesn't exist before iOS9
// FREEBIE
7 years ago
Michael Kirk 0dec643b94 update header to match implementation atomicity
// FREEBIE
7 years ago
Michael Kirk 5e7ca89930 Proper function prototypes
// FREEBIE
7 years ago
Matthew Chen bf21d0c0ed Enable logging in SAE; rework log file management to include multiple log directories. 7 years ago
Michael Kirk 336d59a6ce restore chrono timestamp
make SSK compatible with c++ by using non-modular imports, which
requires disambiguating our ddLog variable.

// FREEBIE
7 years ago
Matthew Chen e7df2511a4 Register CrossProcessNotifier. 7 years ago
Matthew Chen 64762eb427 Observe YapDatabaseModifiedExternallyNotification. 7 years ago
Matthew Chen 62cf9b1dd5 Respond to CR. 7 years ago
Matthew Chen d17ccadea2 Use AppContext to resolve share extension FIXMEs. 7 years ago
Matthew Chen e712e8bfc4 Use AppContext to resolve share extension FIXMEs. 7 years ago
Matthew Chen 4c31d99498 Respond to CR. 7 years ago
Matthew Chen ffa69b3502 Add application context class. 7 years ago
Matthew Chen 8d4e9b4565 Respond to CR. 7 years ago
Matthew Chen 779e89fe74 Clean up ahead of PR. 7 years ago
Matthew Chen 7429e1968c Clean up ahead of PR. 7 years ago
Matthew Chen edaf65223a Migrate to shared data NSUserDefaults. 7 years ago
Matthew Chen cd11ec5698 Add app group, share keychain. Take a first pass at file migration to shared data directory. 7 years ago
Michael Kirk 336aa13520 Avoid overzealous assert
// FREEBIE
7 years ago
Michael Kirk 2072359a72 add todo 7 years ago
Michael Kirk e9796600c6 disable some asserts for now
// FREEBIE
7 years ago
Michael Kirk 961727814b Move pinning certificates into App
// FREEBIE
7 years ago
Michael Kirk a11d83187b WIP: Framework-friendly - compiles but crashes on launch
// FREEBIE
7 years ago
Michael Kirk c5b0f7cd01 framework compatible CocoaLumberjack import
With previous import style, the `LOG_ASYNC_ENABLED, LOG_LEVEL_DEF`
macros were not being defined.

@import style module includes are handled differently in ObjC++, causing
problems with out millisecondTimeStamp implementation. Rather than
address that problem head on, I simple reimplemented our millisecond
timestamp method in objective-c, removing our single ObjC++ file.

// FREEBIE
7 years ago
Michael Kirk 7894a58769 FIXME: Changes to get share extension compiling
This was a slash and burn approach, and breaks existing functionality.
We need to address all of these before merging.

// FREEBIE
7 years ago
Matthew Chen 829464baaf Remove concurrency limitations from signal service. 7 years ago
Matthew Chen ba88da60ca Use dedicated db connection for recipient identities. 8 years ago
Matthew Chen 9b4ac4073f Improve robustness around unknown country codes. 8 years ago
Matthew Chen d9fcfdeeb7 Fix deadlock when responding to contacts sync messages. 8 years ago
Matthew Chen 9b197fad03 Fix deadlock when responding to contacts sync messages. 8 years ago
Matthew Chen d8ae5841d6 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen b3d17ea192 Improving handling of edge cases in conversation view. 8 years ago
Matthew Chen 45c7d80d97 Improving handling of edge cases in conversation view. 8 years ago
Matthew Chen 6d4a05bbea Improving handling of edge cases in conversation view. 8 years ago
Matthew Chen 2642f6fcea Fix group creation. 8 years ago
Matthew Chen 21e9f57cbe Imitate Android's behavior of delaying local notifications based on incoming sync messages. 8 years ago
Matthew Chen 2d8a7b03d0 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen d7b0424c75 Don't back up profile pics, attachments or gifs.
// FREEBIE
8 years ago
Matthew Chen 2f84e0c426 Fix calling; be explicit about which messages should be saved. 8 years ago
Matthew Chen 19ba564f80 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 00feb14b10 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 5eea0347b5 Rework the "update with..." methods to avoid re-saving deleted models. 8 years ago
Matthew Chen 94b59c326e Rework the "update with..." methods to avoid re-saving deleted models. 8 years ago
Matthew Chen c6160a5a1e Rework the "update with..." methods to avoid re-saving deleted models. 8 years ago
Matthew Chen 69fa80b890 Don't resurrect zombies. 8 years ago
Matthew Chen fce52841f9 Don't resurrect zombies. 8 years ago
Matthew Chen 5c90bc72df Never request contacts permission if app is in the background. 8 years ago
Matthew Chen cc0e58365e Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 0abdbffe1f Improve handling of attachment edge cases. 8 years ago
Matthew Chen bac3bd4b68 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 518f15155a Respond to CR.
// FREEBIE
8 years ago
Matthew Chen efcd42012c Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 071dbd4414 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 8b65246619 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen e1b32315de Fix assert after registration.
// FREEBIE
8 years ago
Matthew Chen 5541be784f Fix build warnings from XCode 9. 8 years ago
Matthew Chen 6e840ff956 Fix build warnings from XCode 9. 8 years ago
Matthew Chen a6bfc0a60e Fix build warnings from XCode 9. 8 years ago
Matthew Chen 2d21e2ae2c Fix build warnings from XCode 9. 8 years ago
Matthew Chen da7338580c Merge tag '2.18.1.0' 8 years ago
Michael Kirk e82a3f3ddf respond to CR
// FREEBIE
8 years ago
Michael Kirk 8ef9e96b91 Avoid group-sync deadlock by making post-upload save async
// FREEBIE
8 years ago
Michael Kirk 98fd15fae7 Avoid groupsync deadlock - pass in transaction
// FREEBIE
8 years ago
Matthew Chen 8b6265f1b5 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 4d57402367 Ensure attachments always have a valid content type.
// FREEBIE
8 years ago
Matthew Chen e07a240ee5 Merge tag '2.18.0.9' 8 years ago
Michael Kirk 81cff837ae Include root certs from pki.goog
// FREEBIE
8 years ago
Michael Kirk 6c13d46be2 use manually specified censorship host
// FREEBIE
8 years ago
Michael Kirk 11e07370a9 more logging
// FREEBIE
8 years ago
Michael Kirk a30533e7b5 Add GTSGIAG3 to censorship circumvention trust store
openssl x509 -outform der -in GIAG3.pem -out GIAG3.crt

// FREEBIE
8 years ago
Michael Kirk 295646e5fa Rebase cleanup
// FREEBIE
8 years ago
Michael Kirk 0706edf42a Generate new registrationId on re-register
In order for others to know they should start a new session with us, we
need to change our registration id.

To achieve this, I consolidated all the Account related attributes on
TSAccountManager - luckily they were already in the proper collection, I
just moved the API to hang on the AccountManager instead of a TSStorage
category extension.

Also:

@synchronize access to `registrationId`

// FREEBIE
8 years ago
Michael Kirk 58d4c95362 Re-register without losing your messages in Debug-UI
// FREEBIE
8 years ago
Matthew Chen 1fa75ead5d Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 74096fc2c2 Don't send sync messages to self if no linked devices.
// FREEBIE
8 years ago
Matthew Chen db8a381960 Merge remote-tracking branch 'origin/release/2.18.0' 8 years ago
Michael Kirk cf9874302b Remove unecessary subdata for unpadded attachment
// FREEBIE
8 years ago
Michael Kirk ce51d2da3e Example (disabled) padding strategy for attachment sender
The padding strategy the sender uses can change without needing to
update the receiver, so long as we continue to record the unpadded
length of the attachment in the attachment pointer.

// FREEBIE
8 years ago
Michael Kirk cbbb376860 Handle receiving padded attachments
Don't send padded attachments yet.

// FREEBIE
8 years ago
Michael Kirk 259695a9fd Attachments require digest or show explanatory error.
// FREEBIE
8 years ago
Michael Kirk 6eeb78157a Include size in attachment pointer
// FREEBIE
8 years ago
Matthew Chen 3927815a35 Fix tests broken by the JSQ rewrite.
// FREEBIE
8 years ago
Matthew Chen bf8d694eb4 Rework attachment approval UI.
// FREEBIE
8 years ago
Matthew Chen d04f9111db Rework attachment approval UI.
// FREEBIE
8 years ago
Michael Kirk 68e755ade9 Merge branch 'release/2.18.0' 8 years ago
Michael Kirk 0cd56d4bcc On iOS11 doc picker requires system appearance.
Otherwise nav items are illegible.

// FREEBIE
8 years ago
Matthew Chen 4dabb71815 Fix "can't send same GIF twice" issue.
// FREEBIE
8 years ago
Matthew Chen fb4d43d542 Fix "can't send same GIF twice" issue.
// FREEBIE
8 years ago
Matthew Chen e3868df69a Move write of incoming messages off main thread.
// FREEBIE
8 years ago
Matthew Chen 8704722f90 Don't start expiration of incoming messages until attachments are downloaded.
// FREEBIE
8 years ago
Matthew Chen 227fd5280d Resize conversation view cells as necessary.
// FREEBIE
8 years ago
Michael Kirk 0f859d6b20 Merge branch 'release/2.18.0' 8 years ago
Michael Kirk 3080cb512b Compose View: collation index and group search
- Include table index for contacts
- Fix extra spacing in OWS table view
- Separate search results into contact/invite sections
- Include groups in search results when composing new message
- Compose Screen search matches on group member names

// FREEBIE
8 years ago
Matthew Chen fb408f980c Remove JSQ.
// FREEBIE
8 years ago
Michael Kirk b2efb722d2 Log timestamp of sent messages
This is really helpful when cross referencing debug logs with the
recipient. (We already log timestamps on the receiving side).

// FREEBIE
8 years ago
Michael Kirk 9a7e3cb9d8 Register for manual message fetching when unable to obtain push tokens
// FREEBIE
8 years ago
Michael Kirk df15c904bc Rework push registration
== Account Registration ==

Not complete until push tokens are uploaded

== Remote Notifications Registration ==

Extracted from PushManager

- wait for notification-settings registration to complete before
  requesting push tokens, otherwise it's possible token requests will
  be ignored.

- Less state required for push notification callbacks, specifically, we
  no longer need to ensure we've created a promise before the
  registration delegate methods get called.

- no more TOCFuture in Signal-iOS (still in SSK for now). It's not in
  cases of inexplicable behavior - one a recently, push notification
  premature free, in redphone, and more popular use, and I've seen two
  futures inexplicably being nil.  Instead, let's consolidate around
  PromiseKit for popularly used, maintained, strongly-typed futures.

- separate logic for registering for vanilla push/voip notifications
  (few dependencies) from responding to UILocalNotifications (lots of
  dependencies). Ultimately I'd like to consolidate the remaining
  UILocalNotifications logic with the existing NotificationsManager

== Misc ==

more debug logging
more uniform logging
remove stale logic around newly registered user

// FREEBIE
8 years ago
Michael Kirk 703d4df9e5 Avoid phantom notifications for group info requests
// FREEBIE
8 years ago
Joshua Lund 8ff14a3f6a Enable censorship circumvention in Qatar.
// FREEBIE
8 years ago
Matthew Chen 0c46b770e9 Ignore group info requests if sender and recipient aren't both known group members.
// FREEBIE
8 years ago
Matthew Chen 13a6657991 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 2a5a0929e6 Create & access groups more carefully.
// FREEBIE
8 years ago
Matthew Chen 380ed0f82b Create & access groups more carefully.
// FREEBIE
8 years ago
Matthew Chen a31b1aeea6 Respond to "sync block list" request.
// FREEBIE
8 years ago
Michael Kirk 462a6e4456 Persist read receipts to proper collection
// FREEBIE
8 years ago
Michael Kirk 2125dbe72c CR: Avoid potential transaction nesting
also clean up description method

// FREEBIE
8 years ago
Michael Kirk 5d62741a3c Sync read receipt configuration upon set
// FREEBIE
8 years ago
Michael Kirk ab5b090338 Sync read receipt config to linked devices
// FREEBIE
8 years ago
Michael Kirk be197621ac Add read receipts field/configuration protos
Also converge with Android protos where possible

// FREEBIE
8 years ago
Michael Kirk a2421d5b3e Fix "unknown attachment" notifications
The transaction in which the attachments were created hasn't been
committed yet.

// FREEBIE
8 years ago
Matthew Chen 08e560f969 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 0a081f7dcc Use longer delay when batch processing incoming messages.
// FREEBIE
8 years ago
Matthew Chen 69c9a5a49b Use longer delay when batch processing incoming messages.
// FREEBIE
8 years ago
Matthew Chen 46d2b7a891 Refine read receipt processing cycle.
// FREEBIE
8 years ago
Matthew Chen 6b3c0377cf Refine read receipt processing cycle.
// FREEBIE
8 years ago
Matthew Chen c3dca21a69 More thread safety fixes.
// FREEBIE
8 years ago
Matthew Chen 65957c932d Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 8b15dba4e7 Fix "mark as read on linked device".
// FREEBIE
8 years ago
Matthew Chen facbc56062 Move more work off the main thread.
// FREEBIE
8 years ago
Matthew Chen 9573e0e16d Move more work off the main thread.
// FREEBIE
8 years ago
Matthew Chen 1df1144e43 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 33376f66d2 Simplify processing of messages from linked devices.
// FREEBIE
8 years ago
Matthew Chen 9b5affb390 Send silent messages where appropriate.
// FREEBIE
8 years ago
Matthew Chen d557817bb4 Format message statuses with date if possible.
// FREEBIE
8 years ago
Matthew Chen 834ad3f8e1 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 01bda556c8 Fix class rename.
// FREEBIE
8 years ago
Matthew Chen 6b8c9b6bcf Iterate the names of the incoming message queue extensions.
// FREEBIE
8 years ago
Matthew Chen eec0efa3c8 Fix class rename.
// FREEBIE
8 years ago
Matthew Chen a4d285f50d Respond to CR.
// FREEBIE
8 years ago
Matthew Chen aa7329013d Handle new-style delivery receipts.
// FREEBIE
8 years ago
Matthew Chen 25c40ea3cf Handle new-style delivery receipts.
// FREEBIE
8 years ago
Matthew Chen ee13084d5c Respond to CR.
// FREEBIE
8 years ago