Commit Graph

704 Commits (c88ce07f660308bdda286b035bd373f1e109feda)

Author SHA1 Message Date
Michael Kirk c88ce07f66 CR: Clean up comments, use property setter instead of ivar
// FREEBIE
7 years ago
Michael Kirk eb140a6839 Timer info messages *before* the message which changed the timer
// FREEBIE
7 years ago
Michael Kirk a9e7c5e879 Cleanup: simplify migration, remove unused code
// FREEBIE
7 years ago
Michael Kirk 754549adf1 Start timer for expiring message based on when read receipt was sent
// FREEBIE
7 years ago
Michael Kirk dfb2a034af Use explicit transactions.
- Start expiration within scope of existing transaction when we're
  already in a transaction

// FREEBIE
7 years ago
Michael Kirk b7625689cb Simplify reasoning around disappearing messages
1. Max duration between runs is now a separate timer we set up once and
   don't touch, so we can separate any potential bugs in scheduling logic.
2. When we want to "run now" we just run now, rather than going through
   the scheduler.
3. Detect if messages aren't being deleted in a timely way.

// FREEBIE
7 years ago
Michael Kirk 57ae2b173f Clarify existing functionality, but no change in behavior
rename vars
use clearer date comparison method

// FREEBIE
7 years ago
Matthew Chen eb51ea42e3 Merge remote-tracking branch 'origin/hotfix/2.23.4' 7 years ago
Michael Kirk 66f028a3b3 Update nullability
If object is nil, which it can be, Swift freaks out, since we'd promised
it would never be nil.

// FREEBIE
7 years ago
Matthew Chen 85cb78ddfe Add mainWindow property to app context. 7 years ago
Matthew Chen 5ce39337ed Handle malformed protos. 7 years ago
Michael Kirk c926ca10a5 Update nullability
If object is nil, which it can be, Swift freaks out, since we'd promised
it would never be nil.

// FREEBIE
7 years ago
Matthew Chen 9c93099515 Fix incomplete asserts. 7 years ago
Matthew Chen 6caa5b87b6 Add more asserts around thread in SAE. 7 years ago
Michael Kirk e554884ab3 Use profile name in quoted messages, fix "multi account" label
// FREEBIE
7 years ago
Matthew Chen 829cfd0428 Reduce oversize text size. 7 years ago
Matthew Chen 45892e822b Move 'background' check in message processing logic off main thread. 7 years ago
Michael Kirk b2b70258f2 Make our protos backwards compatible with Signal-Android
Android doesn't have a flags field (yet?). We should make sure our
existing fields align with theirs.

// FREEBIE
7 years ago
Michael Kirk bd8e03fe8a Fix spurious "Group Updated" message
Regression introduced in Message factory method refactor (not in the wild).

// FREEBIE
7 years ago
Matthew Chen d95f2bdc66 Respond to CR. 7 years ago
Matthew Chen d561ba4c62 Reduce 0xdead10cc crashes. 7 years ago
Matthew Chen db6f1326bb Fix previews of oversize text messages. 7 years ago
Matthew Chen 83a470d441 Fix previews of oversize text messages. 7 years ago
Matthew Chen abba24988c Rework how dates are formatted in home view. 7 years ago
Michael Kirk d94709e13f Show label when captioning limit has been reached.
// FREEBIE
7 years ago
Michael Kirk 6b6f4f9336 Limit caption length
// FREEBIE
7 years ago
Matthew Chen c269add62f Respond to CR. 7 years ago
Matthew Chen 76995e4594 Enforce quoted reply edge cases. 7 years ago
Matthew Chen 6a07599e00 Respond to CR. 7 years ago
Matthew Chen 65015e686f Tap on quoted replies. 7 years ago
Michael Kirk 81b2b57703 CR: add comments, make atomic
// FREEBIE
7 years ago
Michael Kirk 88d6a83954 Add assertion canary so we know to re-test syncing once desktop
supports sending quoted replies

// FREEBIE
7 years ago
Michael Kirk 02efbd3069 Fix blip where thumbnail is initially missing from outgoing message
// FREEBIE
7 years ago
Michael Kirk 90486aa49c Inline method with one caller, fix formatting
// FREEBIE
7 years ago
Michael Kirk 8e4c6b8af6 Update protos for voice messages
// FREEBIE
7 years ago
Michael Kirk 941b7ec1bc clarify method signature
// FREEBIE
7 years ago
Michael Kirk c56e8acc51 QuotedReplyModel from SSK->SignalMessaging
// FREEBIE
7 years ago
Michael Kirk 1d4c0624be Clarify variable names
// FREEBIE
7 years ago
Michael Kirk a9459757f0 Lingering var renames QuotedReplyDraft -> QuotedReplyModel
// FREEBIE
7 years ago
Michael Kirk f1714bf252 Handle synced quotes
// FREEBIE
7 years ago
Michael Kirk 622f6bdf21 OrphanDataCleaner vs. QuotedAttachment thumbnails
// FREEBIE
7 years ago
Michael Kirk 4399967e99 Comment cleanup, remove unnecessary includes
// FREEBIE
7 years ago
Michael Kirk fa2e1ba89b Fetch thumbnail when not available locally
// FREEBIE
7 years ago
Michael Kirk 42f454b075 Generate thumbnail when quoted attachment is available locally
// FREEBIE
7 years ago
Michael Kirk 351f9ea263 Simplify attachment processor
We've accepted all attachment types for a long while now.

// FREEBIE
7 years ago
Michael Kirk 3252866727 remove unused params
// FREEBIE
7 years ago
Michael Kirk cb5d3d4f85 Use QuotedReplyModel to access attachment data
This view model loads the attachment when it's build.

// FREEBIE
7 years ago
Michael Kirk 3334f2a063 tentative proto changes
// FREEBIE
7 years ago
Michael Kirk 51a4298c14 WIP: Send attachment info in protobuf (no thumbnails yet)
// FREEBIE
7 years ago
Michael Kirk 55c6d99d98 populate draft toolbar
// FREEBIE
7 years ago