Matthew Chen
3f7d23e043
Fix two hotspots in contact parsing and contact syncing.
...
// FREEBIE
9 years ago
Matthew Chen
535fc566a5
Rework handling of phone number names.
...
// FREEBIE
9 years ago
Matthew Chen
0c4351a908
Use SignalAccount class to sync contacts.
...
// FREEBIE
9 years ago
Michael Kirk
d7c7fff679
Fix some compiler warnings
...
* explicit optional usage in strings
* remove some unused StringUtil code
* swiftlint affected files
* more concise optional casting (and avoid a `!`)
Compiler warnings: 343 -> 318
(Actually most of these are in external libs, but 115 remain in Signal/SSK)
// FREEBIE
9 years ago
Matthew Chen
45ae8fb067
Respond to CR.
...
// FREEBIE
9 years ago
Matthew Chen
2bc1d44cd2
Respond to CR.
...
// FREEBIE
9 years ago
Matthew Chen
1b99671e0e
Clean up ahead of PR.
...
// FREEBIE
9 years ago
Matthew Chen
325134c6e8
Clean up ahead of PR.
...
// FREEBIE
9 years ago
Matthew Chen
363d84fd2d
Update “new conversation” view to use OWSTableView, contacts view helper, etc.
...
// FREEBIE
9 years ago
Matthew Chen
dcdfcb0a6f
Insist upon an "ordered" TCP data channel for delivery reliability.
...
// FREEBIE
9 years ago
Matthew Chen
1444cfc630
Merge remote-tracking branch 'origin/hotfix/2.11.2'
9 years ago
Michael Kirk
a056c1e052
Check for signalContact vs. AB setup.
...
Same intent as previous check but more to the point, and doesn't
require tracking additional state.
// FREEBIE
9 years ago
Michael Kirk
364f416a69
Block editing contact if user has denied contact permissions
...
// FREEBIE
9 years ago
Michael Kirk
b24cf29189
don't request contacts until necessary
...
Most commonly this will be after hitting the "compose" button
But also we'll do it in the SignalViewController once you've received a
message.
- get rid blocking contacts nag
- use Contacts framework simplifies logic
- remove dead AB code
// FREEBIE
9 years ago
Matthew Chen
33415eaa0f
Respond to CR.
...
// FREEBIE
9 years ago
Matthew Chen
ae7934c117
Update appearance of audio and generic attachment adapters.
...
// FREEBIE
9 years ago
Matthew Chen
800715a5e0
Remove waveform from audio message bubbles.
...
// FREEBIE
9 years ago
Michael Kirk
93801e8d29
only show count when there is more than 1 of the same type
...
// FREEBIE
9 years ago
Michael Kirk
4b6bfa4c4c
"home", "other" and "work" instead of "Unknown" phone label
...
// FREEBIE
9 years ago
Michael Kirk
2f05dcc2c5
fix crash when viewing undisplayable text
...
(can't init attributed string with nil)
// FREEBIE
9 years ago
Matthew Chen
0f85284b82
Fix speakerphone vs. WebRTC AND Fix CallService edge cases.
...
// FREEBIE
9 years ago
Michael Kirk
1b66e0ba26
Fix crash when placing call
...
// FREEBIE
9 years ago
Matthew Chen
147107d76c
Fix database deadlock in contacts manager.
...
// FREEBIE
9 years ago
Matthew Chen
4bc98dba58
Rework the scaling and cropping of group avatars.
...
// FREEBIE
9 years ago
Matthew Chen
26f69b0063
Respond to CR.
...
// FREEBIE
9 years ago
Matthew Chen
f71ec9f7cb
Respond to CR.
...
// FREEBIE
9 years ago
Matthew Chen
2bec1db541
Respond to CR.
...
// FREEBIE
9 years ago
Matthew Chen
ad11c50c1b
Reworking observation of Contact and SignalAccount changes.
...
// FREEBIE
9 years ago
Matthew Chen
994aec0d86
Add SignalAccount class.
...
// FREEBIE
9 years ago
Matthew Chen
6801963a1b
Add SignalAccount class.
...
// FREEBIE
9 years ago
Matthew Chen
93700f1044
Extract labels for phone numbers.
...
// FREEBIE
9 years ago
Matthew Chen
42768294ee
Extract labels for phone numbers.
...
// FREEBIE
9 years ago
Matthew Chen
cb9d96be00
Clean up ahead of PR.
...
// FREEBIE
9 years ago
Matthew Chen
da7dd1b128
Clean up debug scaffolding.
...
// FREEBIE
9 years ago
Matthew Chen
f5cd39ea35
Apply ContactsViewHelper to SelectThreadViewController.
...
// FREEBIE
9 years ago
Matthew Chen
61f59067b6
Improve contact-related views.
...
* Add support for contacts with more than one Signal account using ContactAccount class.
* Use OWSTableViewController in contact-related views.
* Let users add non-contacts to groups.
* Improve the "new group" and "edit group" views.
* Add utility methods for displaying alerts.
* Warn users before discarding unsaved changes in "edit group" view.
* Pull out "contact view helper" to de-duplicate common logic among contact-related views.
* Pull out "group view helper" to de-duplicate common logic among group-related views.
* Pull out new base class for view used to add accounts to groups or the block list.
// FREEBIE
9 years ago
Michael Kirk
a1eef6fde5
Remove invalid assert in case of legitimately stacking unicode
...
This assert was being falsely triggered by legitimate unicode.
The current state of affairs (unchanged by this PR) is that all
diacriticals will be stripped from a message that also contains e.g. 3
flags in a sequence.
// FREEBIE
9 years ago
Michael Kirk
faa797c743
Fix crash when placing call
...
// FREEBIE
9 years ago
Matthew Chen
d06f358a23
Don't unwrap with ! in CallService.
...
// FREEBIE
9 years ago
Matthew Chen
6ae3a5395e
Skip attachment approval dialog for image and video shot by camera.
...
// FREEBIE
9 years ago
Michael Kirk
700bd6e08a
Fix build, remove unnecessary return
...
Fixup 27e55d2906
// FREEBIE
9 years ago
Michael Kirk
3a0f84cf36
Avoid crash in CallService
...
Rather than force unwrapping (`!`), use guards/implicit unwrapping to
handle the failure gracefully.
// FREEBIE
9 years ago
Michael Kirk
94b95367f1
Actually *use* the delay time to enqueu the retry
...
Also, use a consistent type (double) rather than a mishmash of float and
CGFloat.
// FREEBIE
9 years ago
Michael Kirk
adbc6eb71a
style cleanup
...
// FREEBIE
9 years ago
Michael Kirk
4d5d808675
Ensure push token update job runs to completion
...
Promises must be retained.
// FREEBIE
9 years ago
Michael Kirk
48971478dd
Allow importing of any file that's not a directory
...
// FREEBIE
9 years ago
Michael Kirk
1b61c3b0ce
fix attachment-import error alert presentation
...
// FREEBIE
9 years ago
Matthew Chen
2cc3232c01
Fix presentation of “open with Signal” errors.
...
// FREEBIE
9 years ago
Matthew Chen
c08e6e0fc6
Ignore “open with Signal” if there is an ongoing call.
...
// FREEBIE
9 years ago
Matthew Chen
782140d367
Respond to CR.
...
// FREEBIE
9 years ago