Commit Graph

10738 Commits (c2aee429b19d0d692f2ea4ce2bc2fca40d482156)
 

Author SHA1 Message Date
Matthew Chen 83309616be "Bump build to 2.34.0.21." 6 years ago
Matthew Chen a372e00ab3 Merge branch 'charlesmchen/tapAlbumWithFailedImage2' into release/2.34.0 6 years ago
Matthew Chen e91195385b Respond to CR. 6 years ago
Matthew Chen 04a300784f Respond to CR. 6 years ago
Matthew Chen 42762ad907 Allow taps in albums with failed images. 6 years ago
Matthew Chen b6e28adfe3 Merge branch 'charlesmchen/inputToolbarMarginsVsRotation3' into release/2.34.0 6 years ago
Matthew Chen b8e2cb6267 Respond to CR. 6 years ago
Matthew Chen 18c890bb95 Fix input toolbar margins issue. 6 years ago
Michael Kirk 8d87449986 Merge branch 'mkirk/eagerly-load-rail' into release/2.34.0 6 years ago
Michael Kirk 7fddb35715 eagerly load entire album to populate rail 6 years ago
Matthew Chen 4b3c43eed6 Merge branch 'charlesmchen/linkPreviews3' 6 years ago
Matthew Chen 55d634d403 Update Cocoapods. 6 years ago
Matthew Chen f13c1de738 Respond to Cr. 6 years ago
Matthew Chen 55376975f5 Add link preview parsing and validation logic. 6 years ago
Matthew Chen 74ccee26a8 Merge branch 'charlesmchen/linkPreviews2' 6 years ago
Matthew Chen 45b93cc4b4 Respond to CR. 6 years ago
Michael Kirk 101d17cfeb Merge branch 'mkirk/video-select' into release/2.34.0 6 years ago
Matthew Chen a477e01a4a Apply LinkPreview model. 6 years ago
Matthew Chen 4eb05e369d Add LinkPreview model. 6 years ago
Matthew Chen 631de58b06 Merge branch 'charlesmchen/linkPreviews1' 6 years ago
Matthew Chen aa916965d0 Update protos to reflect link previews. 6 years ago
Matthew Chen 5a529567aa Update protos to reflect link previews. 6 years ago
Matthew Chen 76f410b2b7 Update protos to reflect link previews. 6 years ago
Michael Kirk a497e44cef Fix iCloud download 6 years ago
Michael Kirk 59e037986a Show error when image request fails 6 years ago
Michael Kirk 623c2574d0 Merge branch 'mkirk/dont-select-unless-batch' 6 years ago
Michael Kirk 5fdb88ddf4 Don't add to selection unless in batch select mode
Fixes:

- choose attachment > media library
- tap image A
- tap back
- tap select
- select images B, C
- tap Done
- see image A, B, and C in the rail, but should just see image B and C
6 years ago
Michael Kirk 2df6ae2cfd Merge branch 'mkirk/scroll-to-bottom-when-switching-albums' 6 years ago
Michael Kirk 924b8b18ba Scroll to bottom when switching albums
Fixes

1. start on "All Photos" which has many pages of content

You're at the bottom, as expected.

2. switch to "Video", which is much shorter

You're at the bottom, as expected.

3. Switch back to "All Photos"

Now you're unexpectedly in the middle of the content somewhere - at whatever
offset the "Videos" content height was.

Note that changes to "scrollToBottom". For some reason calling scroll to bottom
with infinity works fine initially, but subsequent calls hang. Because we only
used the "infinity" hack to account for the fact that we didn't have accurate
safeAreaInsets before `viewDidAppear`, we can accurately use safeAreaInsets
after that point (like here, when switching albums).
6 years ago
Matthew Chen ff2fdcb7e1 Merge branch 'mkirk/fix-conversion' 6 years ago
Michael Kirk 119f309787 Fixup database conversion vis a vis SQLCipher4 6 years ago
Matthew Chen 96fffb92cc Merge tag '2.33.1.0' 6 years ago
Michael Kirk ed15e5cc4a Update YapDB to fix DB conversion logic 6 years ago
Matthew Chen 433ef08235 "Bump build to 2.34.0.14." 6 years ago
Matthew Chen fba26653c8 "Bump build to 2.34.0.13." 6 years ago
Matthew Chen a8ba8b668f Merge branch 'charlesmchen/imagePickingFixes' 6 years ago
Matthew Chen 63aa71c318 Respond to CR. 6 years ago
Matthew Chen 6c38f8d14c Only complete media loads once. 6 years ago
Matthew Chen 6b100e80e2 Only enter batch select mode if user uses "add more" button. 6 years ago
Matthew Chen 3e36dcf91f Merge branch 'charlesmchen/conversationRotationVsScrollContinuity' 6 years ago
Matthew Chen d32372ec26 Respond to CR. 6 years ago
Matthew Chen 9dda2fa8c0 Improve scroll state continuity during conversation view rotations. 6 years ago
Matthew Chen 1fc90974fc Merge branch 'charlesmchen/honorAlbumSelectionOrder' 6 years ago
Matthew Chen 9051191bab Honor album selection order. 6 years ago
Matthew Chen af81404e45 Merge branch 'mkirk/remain-landscape-after-media-dismiss' 6 years ago
Michael Kirk 0f85e52ecf Remain landscape after media dismiss
Now that we support landscape everywhere, there's no need to force portrait upon leaving media.
6 years ago
Matthew Chen c5cd52db06 Merge branch 'charlesmchen/cullUnknownMigrations' 6 years ago
Matthew Chen efd1be30c7 Cull unknown migrations. 6 years ago
Michael Kirk 162a4894e3 Merge branch 'mkirk/remove-feature-flag' 6 years ago
Michael Kirk 371ff08d45 remove legal terms feature flag 6 years ago