Commit Graph

1331 Commits (b77528ca0a86a49e4e589b2724e2ddd2ad1e4833)

Author SHA1 Message Date
Matthew Chen b77528ca0a Fix asserts & logging. 6 years ago
Matthew Chen 0125535d4d Pull out SignalCoreKit. 6 years ago
Matthew Chen ebae75af00 Revert 'new sort id'. 6 years ago
Matthew Chen 3c22d0b0c8 Swift exit(). 6 years ago
Michael Kirk e3e6c31612 fix hang on conversation load 6 years ago
Michael Kirk 79add78d51 Merge branch 'release/2.30.1' 6 years ago
Matthew Chen bb5c9ff106 Respond to CR. 6 years ago
Matthew Chen c0f4254599 Mark CDS feature flag for removal. 6 years ago
Matthew Chen 0884598a3a Fix CDS cookie handling. 6 years ago
Matthew Chen c368aabf9c Fix the "de-register" logic. 6 years ago
Matthew Chen b10bf441c4 Add note about curl cookie support. 6 years ago
Matthew Chen 370c96af53 Enable CDS in contact intersection. 6 years ago
Matthew Chen 43d0b9b9bf Fix misnamed method. 6 years ago
Matthew Chen b6a14ea014 Fix the CDS version checking. 6 years ago
Matthew Chen bcb882f5aa Update CDS URLs. 6 years ago
Matthew Chen b3ad6e27dc Rework conversation message bubble colors; add "conversation colors" class. 6 years ago
Matthew Chen 8db4595bdc Rework group avatars to reflect conversation colors. 6 years ago
Michael Kirk fe7d69e9c6 Update thread's sorting order based on whatever the currently last message is 6 years ago
Michael Kirk 02692e42bd remove addressed TODO's 6 years ago
Michael Kirk 3240e0d9d0 Be explicit about receivedAt time
We were often using `timestampForLegacySorting`, which is convoluted for when
we actually just want received time.

In some sense this is a superficial change, but it's part of auditing that
we've completed moved away from timestampForLegacySorting.
6 years ago
Michael Kirk 6bfd0f29ed mark self-sent messages as read as soon as it was created 6 years ago
Michael Kirk c0c973de1c Sort gallery finder by sortId 6 years ago
Michael Kirk b281b37637 replace thread.lastMessageDate/archivalDate -> thread.lastSortId, thread.archivedAsOfSortId
Update migration accordingly

Date shown on home view cell is message.receivedAt
6 years ago
Michael Kirk 90aa593dcd sortId vs. Read status 6 years ago
Michael Kirk 089c4f09ea bump all views which rely on message sorting 6 years ago
Michael Kirk ab55e85304 step 1: timestampForSorting audit, change signature
No change in functionality in this commit, I just broke the signature to have a
systematic audit of the callsites. Added TODO's with the plan for each call.
6 years ago
Michael Kirk e1a46d85fb investigation shows we don't use this timestamp for call error messages 6 years ago
Michael Kirk df61316495 minimize diff senderTimestamp -> timestamp 6 years ago
Michael Kirk 00d0d1e002 Remove legacy Error backdating - no changes in functionality
Historically we would backdate the SN change messages, but since adopting
non-blocking SN changes long ago, they're already sorted properly by creation
time, so backdating has been unnecessary for a while.

I also audited that all other error messages are saved directly after creation.

I applied deprecation attributes as appropriate as I audited.
6 years ago
Michael Kirk 550e7ba63b Create disappearing message update info messages before messages they affect
Since we're no longer sorting by timestamp we have to ensure we save the update
info message before we save any affected message, e.g. in the case of implicit
updates.
6 years ago
Michael Kirk eef1368ad3 Timestamp audit step1: change signature
There is no change in functionality in this commit.

Apart from clarifying what the timestamp means (it's the timestamp of the
*sender*), this intentionally breaks all the call sites, so I could have a sane
way to thoroughly audit wherever we're passing in timestamps, to see where
we're depending on them to affect sort order.

For the sake of a cleaner diff of meaningful changes, instead of "fixing"
everything in this commit, I've just added comments and renamed signatures.
6 years ago
Michael Kirk a60d8eb161 WIP: migration / autoincrement logic
TODO:

-[ ] contact offer
-[ ] verify all paths that utilized timestampForSorting, e.g. make sure SN appear before the message they affect, etc.
-[x] Monotonic ID
-[x] New extension which sorts by id
-[x] Migration
  -[ ] batch migration?
6 years ago
Matthew Chen 72562920ed Fix author conversation colors. 6 years ago
Michael Kirk bccb633b6c fix release compile 6 years ago
Matthew Chen 8910f1f65a Enable conversation colors. 6 years ago
Matthew Chen 98630cca50 Respond to CR; add db utility methods to test base classes. 6 years ago
Matthew Chen 559c496ae5 Clean up. 6 years ago
Matthew Chen 66fc389fba Get SSK tests building and running. 6 years ago
Matthew Chen 87836f506b Move more singletons to SSKEnvironment. 6 years ago
Matthew Chen 39ebdf0921 Log curl command for failed requests in debug builds. 6 years ago
Matthew Chen 15b52db8bf Respond to CR. 6 years ago
Matthew Chen 29bb69032a DRY up the debounce of db extension version increment. 6 years ago
Matthew Chen e8186a7005 Fix rebase breakage. Make environment properties mutable in tests. 6 years ago
Matthew Chen 3b2c5bfc7b Modify mock environments to register all db views. 6 years ago
Matthew Chen 83e6484156 Respond to CR. Rework how OWSUploadOperation's networkManager property. 6 years ago
Matthew Chen edcedd2845 Remove selfRecipient method. 6 years ago
Matthew Chen e1db60c1c0 Rework creation of singletons. 6 years ago
Matthew Chen 4ad7ca79b7 Respond to CR. 6 years ago
Matthew Chen e8eac9f30b Clean up ahead of PR. 6 years ago
Matthew Chen b883209f91 Refine logging. 6 years ago