Commit Graph

229 Commits (af4faaa60191b4a043b387e0f186f9ad94d1903a)

Author SHA1 Message Date
Matthew Chen 25ab52caf2 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 865d9d7b96 Add "is uploaded" property to attachment streams.
// FREEBIE
9 years ago
Matthew Chen e4636e8336 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 958dbd199b Minor clean up.
// FREEBIE
9 years ago
Matthew Chen f40629ffa0 Improve alignment between socket state and socket manager state.
// FREEBIE
9 years ago
Michael Kirk 8f1412d502 comment constant time compare per code review
// FREEBIE
9 years ago
Michael Kirk 452110b687 Include digest in attachments
- constant time compare
- free buffer passed to NSData

// FREEBIE
9 years ago
Matthew Chen e05b687438 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 270a10a62a Add UTIType methods to MIMETypeUtil.
// FREEBIE
9 years ago
Michael Kirk 1e6925ebc1 Fix crash-on-launch for older installs
populating the de-duping index assumes authorId is always set for
incoming messages, but this was not always the case.

// FREEBIE
9 years ago
Michael Kirk a92158ef16 CR: fix register `async` where specified
* fix thread test
* add IncomingMessageFinder test
* use constants
* clearer comments

// FREEBIE
9 years ago
Michael Kirk b389bb3bb8 Code cleanup.
No need to use contactThread method to get recipient ID since we still
have the envelope.

And with that, it's pretty easy to justify getting rid of one of our now
barely used IncomingMessage initializers.

// FREEBIE
9 years ago
Michael Kirk 975726e022 Dedupe incoming messags
// FREEBIE
9 years ago
Matthew Chen 52bb939fc1 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 71b804ba52 Add and honor the “CallKit Privacy” setting.
// FREEBIE
9 years ago
Matthew Chen 2741fd4bdc Enable WebRTC-based audio and video calls by default.
// FREEBIE
9 years ago
Matthew Chen 254a247ba0 Revert "Add WebRTC setting."
This reverts commit 0f45f292a1.

// FREEBIE
9 years ago
Michael Kirk 14a104b1b2 fix tests, and off by one in keeping old, accepted keys
// FREEBIE
9 years ago
Matthew Chen c72e8f8e2f Merge remote-tracking branch 'origin/release/2.7.1'
// FREEBIE
9 years ago
Matthew Chen 686fe679bd Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 7bd4d26532 Add “received at” timestamp to all TSMessages so that they may be sorted properly.
// FREEBIE
9 years ago
Matthew Chen f974706396 Clean up the prekeys.
// FREEBIE
9 years ago
Matthew Chen 8acc496a39 Clean up the prekeys.
// FREEBIE
9 years ago
Matthew Chen 54736426f9 Avoid crashes when signed prekey lookup fails.
// FREEBIE
9 years ago
Matthew Chen 351a010fe0 Clean up prekey usage.
// FREEBIE
9 years ago
Matthew Chen 821c96cc6b Mark "attempting out" messages as "unsent" on app launch.
// FREEBIE
9 years ago
Matthew Chen df4b0616e8 Improve rate-limiting error message in registration and code verification views.
// FREEBIE
9 years ago
Michael Kirk e0688e16a7 Clean up prekey logic.
// FREEBIE
9 years ago
Michael Kirk e1949893f2 Avoid deadlock when marking self-sent messages as read.
Fetching the localNumber invokes another transaction, which can
result in deadlock if called during an existing transaction.

// FREEBIE
9 years ago
Matthew Chen 4d055757de Fix the .pch used by this pod to reflect the changes from the last PR.
// FREEBIE
9 years ago
Matthew Chen 284212b3fe Move OWSDispatch.h to the PCH.
// FREEBIE
9 years ago
Matthew Chen 90b85c0605 Improve the call status messages in conversation view.
// FREEBIE
9 years ago
Michael Kirk bc1af80733 Log when we mark a message as read locally
This is in pursuit of some now (for me) un-reproducible behavior where
messages on some clients were being immediately marked as read.

// FREEBIE
9 years ago
Michael Kirk 311d80fb2e Missed calls increment unread counter/badge
This affects:
- per-thread badge in the inbox view
- app badge when viewed from springboard.

// FREEBIE
9 years ago
Matthew Chen df1b3418d2 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 6d356e4b67 Automatically mark as read any messages sent by current user from another device.
// FREEBIE
9 years ago
Michael Kirk 92a69e8e65 Repsond to CR w/ @cmchen.
* Added docs
* added asserts to TSEnv accessors

// FREEBIE
9 years ago
Michael Kirk 80fb58231e Merge remote-tracking branch 'origin/master' into mkirk/webrtc
// FREEBIE
9 years ago
Michael Kirk c68073fdb1 proper error code for NOTFOUND
// FREEBIE
9 years ago
Michael Kirk 7b1b706e2a Include reusable localized text in recipient-not-found error
This way we can use it for calls as well.

// FREEBIE
9 years ago
Matthew Chen 18e144f8bd Respond to CR.
// FREEBIE
9 years ago
Matthew Chen ddbc4819f1 Rework concurrency in the signaling logic.
// FREEBIE
9 years ago
Michael Kirk 104645f97b Safely pass exception across dispatch bounds
// FREEBIE
9 years ago
Michael Kirk 6521a80c44 Lookup methods yield SignalRecipient (#102)
Let's us remove some otherwise redundant code to look up the recipient
from their ID.

// FREEBIE
9 years ago
Michael Kirk fe3ec457fa Disable resetting unreadable storage
Until we have better data on why this occurs, we don't want to risk
blowing users message archive.

// FREEBIE
9 years ago
Matthew Chen 5da4b3d122 Add assert macro that can be used in free functions.
// FREEBIE
9 years ago
Michael Kirk cf6f107f1e Merge remote-tracking branch 'origin/master' into mkirk/webrtc
Get session corruption fixes

// FREEBIE
9 years ago
Michael Kirk f4a46fce08 Merge remote-tracking branch 'origin/master' into mkirk/webrtc 9 years ago
Michael Kirk 5d863418ea Narrow the scope of code run on SessionCipher queue
And run all non-cipher code on the main thread.

Note: Running encryption on the sessionCipher queue is more about
serializing access to session mutations than it is about any performance
gains.

// FREEBIE
9 years ago
Michael Kirk 3216fd3714 Prevent session corruption by using same queue for encrypt vs. decrypt
// FREEBIE
9 years ago
Michael Kirk b5429595ac Better logging per CR
// FREEBIE
9 years ago
Michael Kirk a45ab9fe40 We need to know if the DB password is accessible *before* we init the db
So method can't be *on* the instance.

// FREEBIE
9 years ago
Michael Kirk dd1aa26827 Prevent destroying user database after resetting device.
// FREEBIE
9 years ago
Michael Kirk 8f81015730 Remove Cuba from domain fronting.
Google hosted domain fronting doesn't work in Cuba due to export
restrictions. OTOH there are reports of Signal working just fine without
domain fronting in Cuba.

// FREEBIE
9 years ago
Matthew Chen 305541d03b Merge branch 'feature/fixWebsocket2' into mkirk/webrtc 9 years ago
Matthew Chen 79095ecfb8 Fix web socket issue.
// FREEBIE
9 years ago
Matthew Chen ffb199bcd1 Respond to CR.
// FREEBIE
9 years ago
Matthew Chen 08ba42c563 Update SignalRecipient with “is WebRTC enabled” property from service.
// FREEBIE
9 years ago
Matthew Chen 0f45f292a1 Add WebRTC setting.
// FREEBIE
9 years ago
Michael Kirk d1aa253f87 WebRTC calling
* Stun server request
* settable TextSecureEnv
* nullability annotations for TSCall
* Better debug logging for message sending
* fixup tests and expiration time

// FREEBIE
9 years ago
Michael Kirk d7149c60dd unique error code for rate-limit
// FREEBIE
9 years ago
Matthew Chen c5cf79c399 Detect, warn about and try to recover from database password retrieval and database load errors.
// FREEBIE
9 years ago
Matthew Chen 2a55075e6c Add stub for analytics.
// FREEBIE
9 years ago
Matthew Chen 6192351725 Remove Iran from censorship circumvention. Current approach isn't sufficient.
// FREEBIE
9 years ago
Matthew Chen c22085c1ab Add class to track app version.
// FREEBIE
9 years ago
Matthew Chen 19e4b2c3a2 Revert "Remove Iran from censorship circumvention. Current approach isn't sufficient."
This reverts commit 374b45146d.
9 years ago
Matthew Chen 374b45146d Remove Iran from censorship circumvention. Current approach isn't sufficient.
// FREEBIE
9 years ago
Matthew Chen f470979434 Add asserts to .pch.
// FREEBIE
9 years ago
Matthew Chen 5b87af9bc6 Respond to CR, fix build break.
// FREEBIE
9 years ago
Matthew Chen c3af5bc742 Fix the UAE Google domain.
// FREEBIE
9 years ago
Matthew Chen cc78978be5 Update fronting to use country-specific Google domains.
// FREEBIE
9 years ago
Matthew Chen 566c6e15d1 Add asserts header.
// FREEBIE
9 years ago
Matthew Chen 2438bd16c5 Add Iran, Oman, Cuba to censorship list.
// FREEBIE
9 years ago
Matthew Chen 52762a1be9 Clean up.
// FREEBIE
9 years ago
Michael Kirk 78515377b1 Censorship circumvention in Egypt and UAE
* domain fronting
* non-websocket message fetching
* alternate pinning policy for google hosted reflector server

// FREEBIE
9 years ago
Michael Kirk b1ebfa9873 Revert "WIP: Censorship circumvention in Egypt and UAE"
This reverts commit f1ade83c3f.

No quite ready yet.
9 years ago
Michael Kirk f1ade83c3f WIP: Censorship circumvention in Egypt and UAE
* non-websocket message fetching

// FREEBIE
9 years ago
Michael Kirk 5ccbd4ca6d Bail if we can't build a database.
* Something is irrecoverably wrong at this point.
* Constantize error names

// FREEBIE
9 years ago
Sam Vevang f8bb46c46c check for errors in the keychain password retrieval
// FREEBIE
9 years ago
Michael Kirk 3eeb6c55d3 Use correct recipient ID when using sync message even if no contact
thread with self exists.

// FREEBIE
9 years ago
Michael Kirk 4c2a062fb4 provide custom copy for unauthorized messages
This happens when someone has registered their number on another device.

// FREEBIE
9 years ago
Michael Kirk edebd14d42 Ignore messages with unknown Envelope.Contents
// FREEBIE
9 years ago
Michael Kirk 745a5a2769 return immutable identifiers
// FREEBIE
9 years ago
Michael Kirk 7036c63392 Compatible with libphonenumber 0.9.1
// FREEBIE
9 years ago
Russ Shanahan 7125028159 Rename an OWSContactsManager method
From nameStringForPhoneIdentifier
  To displayNameForPhoneIdentifier

* Add nullability descriptions

* Fix the mock object to adhere to new nullability rules

// FREEBIE
9 years ago
Russ Shanahan 34ffce89f5 Only calculate fullName once, & sortable fullnames (#67)
1. Adds caching of the calculated fullName value
   (which will slightly improve performance)
2. Incorporates fullNames that respect the first-name-first
   rules of the currently unmerged PR #22
3. Adds two new fullName properties that can be used
   for sorting comparators
4. Move the comparator into the model object for easy testing

Includes tests to ensure that the first name first and last name
first sorts are behaving as expected.

// FREEBIE
9 years ago
Michael Kirk 3083e2929c OWSContact from CNContact
Used in new contact picker for the Signal invite flow 

* populate emails
* nullability annotations

// FREEBIE
9 years ago
Michael Kirk df756423f2 Ignore unknown group messages
otherwise when (e.g.) android adds a new group type they'll be shown as
empty bubbles.

// FREEBIE
9 years ago
Michael Kirk 1ba082356a Explicitly include newlines in numeric fingerprint
More straight forward than fudging / verifying different layout widths.

// FREEBIE
9 years ago
Michael Kirk e53422f765 Configurable safety number blocking enabled by default
// FREEBIE
9 years ago
Michael Kirk 60a39f93c6 Remove phone numbers from scannable QR Code
Initially they were there to offer richer error messages when the wrong
code was scanned.

However, we found that people were posting them publicly,
misunderstanding the QR codes to be a kind of personal identifier.

For one, this isn't useful because the QR codes, like safety numbers,
are unique *per* conversation. So they aren't useful in a generic sense.
And secondly this is bad because the QR code contains both parties phone
numbers.

// FREEBIE
9 years ago
Michael Kirk 70e536ca8f Privacy preferences for blocking identity change
// FREEBIE
9 years ago
Michael Kirk 725153307e Add some nullability annotations (#62)
* fix compiler warnings about info message initializers

// FREEBIE
9 years ago
Michael Kirk b0343ee1d1 Only fetch PreKey once.
Previously we were retrying as if it might succeed, and running into
rate-limit errors.

Also, added a specific rate limit error message.

// FREEBIE
9 years ago
Michael Kirk 1ebb82f987 Contacts don't have safety numbers until they've exchanged keys.
// FREEBIE
9 years ago
Michael Kirk 2e06bb148f Send group message so long as at least one recipient is found
Previously we were haulting if even one recipient was unregistered.

// FREEBIE
9 years ago
Michael Kirk ebeae2608d Fix crash on messaging unregistered user
// FREEBIE
9 years ago
Michael Kirk 027fa10730 Only dispatch async at top level.
Previously each method was dispatching it's callbacks async. This is a
waste of code, processing, and makes crash logs impenetrable.

// FREEBIE
9 years ago
Michael Kirk b4c504f61d EndSessionMessage notifies remote side of reset session
Otherwise they'll send us messages we can't decrypt.

Also: Log and fail when message doesn't send due to no thread being specified.

// FREEBIE
9 years ago
Michael Kirk 47cad611e5 Fix register w/o background fetch & stale push tokens
* Separate account registration from push token registration
* Provide better errors when validation fails (e.g. numbers don't match, numbers blank)
* More logging during registration
* Call success after setting phone number to avoid any future race condition

  This isn't currently causing problems, but it's unexpected that we'd
  mutate the state *after* calling a callback which might inuitively rely
  on that state.

* Don't throw exception off thread when device keys 404's
* Better async startup handling
  - move processing off main thread
  - reduce code duplication
  - don't wrap it in a transaction in the future case where we want to
    further access the DB

// FREEBIE
9 years ago