Commit Graph

4571 Commits (a3b698730e610fa7fd43a30ec068bfcdbfe693c4)
 

Author SHA1 Message Date
Michael Kirk f3f0d591ea Revert "Add workaround for bug in iOS 11.1 beta around hit area of custom back buttons."
This reverts commit 7c82f6d448.

This wasn't helping our crash rate, and on my device, as of iOS11.1B2,
the button is easily tappable, not detectably different from prior iOS
releases.
8 years ago
Michael Kirk 66ab4e2549 Merge tag '2.16.2.0' into release/2.18.0 8 years ago
Michael Kirk 2d10080c33 Merge tag '2.17.1.1' into release/2.18.0 8 years ago
Michael Kirk 68e755ade9 Merge branch 'release/2.18.0' 8 years ago
Matthew Chen e427d25c5a Bump build to 2.18.0.3.
// FREEBIE
8 years ago
Matthew Chen 8fdc980cad Update l10n strings.
// FREEBIE
8 years ago
Matthew Chen bdb2890801 Merge branch 'charlesmchen/gifProxy' into release/2.18.0 8 years ago
Matthew Chen c11b82ba30 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen bfde3142ca Merge branch 'charlesmchen/fixMarkAsRead' 8 years ago
Matthew Chen 9274d7fd9b Fix proxying of Giphy requests.
// FREEBIE
8 years ago
Michael Kirk 0cd56d4bcc On iOS11 doc picker requires system appearance.
Otherwise nav items are illegible.

// FREEBIE
8 years ago
Michael Kirk b6c9a2a67f Merge branch 'mkirk/gif-data' into release/2.18.0 8 years ago
Michael Kirk 64c7c40b81 CR: add shadow to activity indicator
// FREEBIE
8 years ago
Michael Kirk 2af99eb710 Allow canceling GIF download
// FREEBIE
8 years ago
Michael Kirk 891cc6ee0d CR: better method names
// FREEBIE
8 years ago
Michael Kirk 6eaa49593d preview vs. sending have independent resolution min
// FREEBIE
8 years ago
Michael Kirk 688810c267 CR: Enforce "one time only" with a bool, not a cell ref
Since cell's can be re-used, at a later point, we might not be
referencing the data we intend. Since all we want to do is enforce a
"one time only" check, just use a bool.

// FREEBIE
8 years ago
Michael Kirk 591cba6468 fix comment typos
// FREEBIE
8 years ago
Michael Kirk a01de44917 Fix intermittent crash
// FREEBIE
8 years ago
Michael Kirk 6db5895269 dismiss keyboard when scrolling after auto-search
// FREEBIE
8 years ago
Michael Kirk be51776d82 Fix mask appearing partially above search bar
// FREEBIE
8 years ago
Michael Kirk 37177de7cb Make sure user knows what they're picking
Abort selection until *some* kind of asset has been downloaded.

// FREEBIE
8 years ago
Michael Kirk e4ad169d71 Show retryable error alert when fetching GIF fails
// FREEBIE
8 years ago
Michael Kirk 3939e8a6ac Download picked GIF faster: cancel pending request
// FREEBIE
8 years ago
Michael Kirk b8ce636afc Show loading screen while selected GIF downloads
// FREEBIE
8 years ago
Michael Kirk ddf2fe21a1 Download smaller GIF for previews.
Previously we were downloading a full sized GIF for each cell, which can
take dozens of seconds on a slower connection. Now we download a smaller
GIF for the picker view, and only download the full sized GIF for the
selected cell.

Some stats:

Before:

Scenario: search "Cat" and no scrolling, no picking
~10 MB

Scenario: search "Cat" and no scrolling, then pick
~10 MB

Scenario: search "Cat" and scroll 3 screens, no picking
~30 MB

Scenario: search "Cat" and scroll 3 screens, then pick
~30 MB

After:

Scenarios: search "Cat" and no scrolling, no picking
~1.0 MB (savings 90%)

Scenarios: search "Cat" and no scrolling, then pick
~3.5 MB (savings 65%)

Scenarios: search "Cat" and scroll 3 screens, no picking
~3.0 MB (savings 90%)

Scenarios: search "Cat" and scroll 3 screens, then pick
~5.5 MB (savings 81%)

// FREEBIE
8 years ago
Michael Kirk 2a4c6506fb log giphy data usage in debug
// FREEBIE
8 years ago
Matthew Chen 7fa7d5d526 Fix "mark as read."
// FREEBIE
8 years ago
Matthew Chen 21cdaeed0f Merge branch 'charlesmchen/cleanupConversationView' 8 years ago
Matthew Chen b0aa84e420 Clean up conversation view.
// FREEBIE
8 years ago
Matthew Chen bc6b5d088b Merge branch 'charlesmchen/reloadAndLayoutChurn' 8 years ago
Matthew Chen d355b45bae Reduce relayout and reload churn; respond to dynamic type changes.
// FREEBIE
8 years ago
Matthew Chen c2608785e1 Reduce relayout and reload churn; respond to dynamic type changes.
// FREEBIE
8 years ago
Matthew Chen 385d7c0c77 Merge branch 'charlesmchen/textInputVsLeaveConversationView' 8 years ago
Matthew Chen 4dc6934fc7 End text editing if we leave conversation view.
// FREEBIE
8 years ago
Matthew Chen 27d8af6940 Merge branch 'charlesmchen/linkifyTextMessages' 8 years ago
Matthew Chen bd5639baaf Linkify text messages.
// FREEBIE
8 years ago
Matthew Chen 98433272b0 Merge branch 'charlesmchen/fixMessageCellLayout' 8 years ago
Matthew Chen bf80e6dd36 Fix broken message cell layout.
// FREEBIE
8 years ago
Matthew Chen 990fd1cca9 Merge branch 'charlesmchen/autoLoadMore' 8 years ago
Matthew Chen 45ba79d296 Auto-load more message if user scrolls near the top of the conversation.
// FREEBIE
8 years ago
Matthew Chen 7249a04a80 Merge branch 'charlesmchen/fixMessageInjection' 8 years ago
Matthew Chen 1ad3add1d5 Fix message injection.
// FREEBIE
8 years ago
Matthew Chen 1529ded433 Merge branch 'charlesmchen/resetKeyboardAfterSend' 8 years ago
Matthew Chen c7097db939 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen f28abbc2a1 Revert from numeric to default keyboard after message send.
// FREEBIE
8 years ago
Matthew Chen 4dabb71815 Fix "can't send same GIF twice" issue.
// FREEBIE
8 years ago
Matthew Chen 31941de1bf Merge branch 'charlesmchen/sendGifTwice' 8 years ago
Matthew Chen fb4d43d542 Fix "can't send same GIF twice" issue.
// FREEBIE
8 years ago
Michael Kirk 9eb4909185 bump build
// FREEBIE
8 years ago