Commit Graph

4481 Commits (a30533e7b593a6a7c8a3e9e0d0f4e5ce888590c3)
 

Author SHA1 Message Date
Michael Kirk 891cc6ee0d CR: better method names
// FREEBIE
7 years ago
Michael Kirk 6eaa49593d preview vs. sending have independent resolution min
// FREEBIE
7 years ago
Michael Kirk 688810c267 CR: Enforce "one time only" with a bool, not a cell ref
Since cell's can be re-used, at a later point, we might not be
referencing the data we intend. Since all we want to do is enforce a
"one time only" check, just use a bool.

// FREEBIE
7 years ago
Michael Kirk 591cba6468 fix comment typos
// FREEBIE
7 years ago
Michael Kirk a01de44917 Fix intermittent crash
// FREEBIE
7 years ago
Michael Kirk 6db5895269 dismiss keyboard when scrolling after auto-search
// FREEBIE
7 years ago
Michael Kirk be51776d82 Fix mask appearing partially above search bar
// FREEBIE
7 years ago
Michael Kirk 37177de7cb Make sure user knows what they're picking
Abort selection until *some* kind of asset has been downloaded.

// FREEBIE
7 years ago
Michael Kirk e4ad169d71 Show retryable error alert when fetching GIF fails
// FREEBIE
7 years ago
Michael Kirk 3939e8a6ac Download picked GIF faster: cancel pending request
// FREEBIE
7 years ago
Michael Kirk b8ce636afc Show loading screen while selected GIF downloads
// FREEBIE
7 years ago
Michael Kirk ddf2fe21a1 Download smaller GIF for previews.
Previously we were downloading a full sized GIF for each cell, which can
take dozens of seconds on a slower connection. Now we download a smaller
GIF for the picker view, and only download the full sized GIF for the
selected cell.

Some stats:

Before:

Scenario: search "Cat" and no scrolling, no picking
~10 MB

Scenario: search "Cat" and no scrolling, then pick
~10 MB

Scenario: search "Cat" and scroll 3 screens, no picking
~30 MB

Scenario: search "Cat" and scroll 3 screens, then pick
~30 MB

After:

Scenarios: search "Cat" and no scrolling, no picking
~1.0 MB (savings 90%)

Scenarios: search "Cat" and no scrolling, then pick
~3.5 MB (savings 65%)

Scenarios: search "Cat" and scroll 3 screens, no picking
~3.0 MB (savings 90%)

Scenarios: search "Cat" and scroll 3 screens, then pick
~5.5 MB (savings 81%)

// FREEBIE
7 years ago
Michael Kirk 2a4c6506fb log giphy data usage in debug
// FREEBIE
7 years ago
Matthew Chen 4dabb71815 Fix "can't send same GIF twice" issue.
// FREEBIE
7 years ago
Michael Kirk 9eb4909185 bump build
// FREEBIE
7 years ago
Matthew Chen a7195e4040 Merge branch 'charlesmchen/refineGifSearch' into release/2.18.0 7 years ago
Matthew Chen a386ac5685 Respond to CR.
// FREEBIE
7 years ago
Matthew Chen b90e9fcd64 Skip redundant GIF searches.
// FREEBIE
7 years ago
Matthew Chen 33d3c4123a Progressive GIF search shouldn't dismiss keyboard.
// FREEBIE
7 years ago
Michael Kirk 2716f50399 Bump version
// FREEBIE
7 years ago
Michael Kirk 6e12b9c898 Fix trailing edge of group member listing
// FREEBIE
7 years ago
Michael Kirk 90468135c3 Merge branch 'mkirk/compose-cr-fixups' into release/2.18.0 7 years ago
Michael Kirk ab05bd32e8 compose search cleanup per code review
// FREEBIE
7 years ago
Michael Kirk a76b1f52b0 Merge branch 'mkirk/show-entire-message' into release/2.18.0 7 years ago
Michael Kirk 9ae4a26eb1 Message details shows entire message
When viewing a longer message, to avoid the risk of the user not being
aware they can scroll down, we scroll to the last couple lines of the
message, ensuring they can see the meta-data.

// FREEBIE
7 years ago
Michael Kirk 0a19e0715a Merge branch 'mkirk/fix-invite-sms' into release/2.18.0 7 years ago
Michael Kirk 038ca0d6a9 Fix invite via SMS in search
- whispersystems.org -> signal.org
- nav color was wrong since iOS10
- update search results after clearing post SMS invite

// FREEBIE
7 years ago
Michael Kirk 69ee9cbcfa Merge branch 'mkirk/pull-to-refresh-inbox' into release/2.18.0 7 years ago
Michael Kirk 6a65ee6def Pull to refresh on homeview fetches messages.
This is useful when you're using censorship circumvention and unable to
receive push notifications.

// FREEBIE
7 years ago
Michael Kirk e47d15d086 Merge branch 'mkirk/revamp-compose' into release/2.18.0 7 years ago
Michael Kirk 3080cb512b Compose View: collation index and group search
- Include table index for contacts
- Fix extra spacing in OWS table view
- Separate search results into contact/invite sections
- Include groups in search results when composing new message
- Compose Screen search matches on group member names

// FREEBIE
7 years ago
Matthew Chen 866be07434 Bump build to 2.17.1.1.
// FREEBIE
7 years ago
Matthew Chen 1967e2aa6a Merge branch 'charlesmchen/backButtonVsiOS11.1Beta' into hotfix/2.17.1 7 years ago
Matthew Chen 7c82f6d448 Add workaround for bug in iOS 11.1 beta around hit area of custom back buttons.
// FREEBIE
7 years ago
Michael Kirk 796be18c56 enable gif picker
// FREEBIE
7 years ago
Michael Kirk 12b674ffb5 Merge branch 'mkirk/log-sent-timestamps' 7 years ago
Michael Kirk b2efb722d2 Log timestamp of sent messages
This is really helpful when cross referencing debug logs with the
recipient. (We already log timestamps on the receiving side).

// FREEBIE
7 years ago
Michael Kirk af4a4c436a Merge branch 'mkirk/call-timeout' 7 years ago
Michael Kirk dd5a19d1fd Suspend while answering shows "Missed Call"
When awakened by a voip push, we get some arbitrary amount of background
time to connect the call (in practice this is ~30s) before the app is
suspended.

Though we were properly terminating the call upon being suspended, we
were not notifying the user that they had missed a call.

// FREEBIE
7 years ago
Michael Kirk a434a381f7 Merge branch 'hotfix/2.17.1' 7 years ago
Michael Kirk 23b8560b79 sync translations
// FREEBIE
7 years ago
Michael Kirk 2cc59dc166 bump version
// FREEBIE
7 years ago
Michael Kirk 875297f1a3 Merge branch 'charlesmchen/profileSaveDeadlock' into hotfix/2.17.1 7 years ago
Matthew Chen 44051bd7e7 Avoid deadlock in profile manager.
// FREEBIE
7 years ago
Michael Kirk 97d99e5c2d Merge branch 'mkirk/push-notification-fixups' 7 years ago
Michael Kirk 9a7e3cb9d8 Register for manual message fetching when unable to obtain push tokens
// FREEBIE
7 years ago
Michael Kirk df15c904bc Rework push registration
== Account Registration ==

Not complete until push tokens are uploaded

== Remote Notifications Registration ==

Extracted from PushManager

- wait for notification-settings registration to complete before
  requesting push tokens, otherwise it's possible token requests will
  be ignored.

- Less state required for push notification callbacks, specifically, we
  no longer need to ensure we've created a promise before the
  registration delegate methods get called.

- no more TOCFuture in Signal-iOS (still in SSK for now). It's not in
  cases of inexplicable behavior - one a recently, push notification
  premature free, in redphone, and more popular use, and I've seen two
  futures inexplicably being nil.  Instead, let's consolidate around
  PromiseKit for popularly used, maintained, strongly-typed futures.

- separate logic for registering for vanilla push/voip notifications
  (few dependencies) from responding to UILocalNotifications (lots of
  dependencies). Ultimately I'd like to consolidate the remaining
  UILocalNotifications logic with the existing NotificationsManager

== Misc ==

more debug logging
more uniform logging
remove stale logic around newly registered user

// FREEBIE
7 years ago
Michael Kirk b916e14abc Merge branch 'mkirk/silent-group-info-request' 7 years ago
Michael Kirk 703d4df9e5 Avoid phantom notifications for group info requests
// FREEBIE
7 years ago
Matthew Chen 0431d1813d Merge branch 'charlesmchen/giphyAPIKey' 7 years ago