Commit Graph

880 Commits (a17873291bf160eb2596aef0ede5576cc84504a7)
 

Author SHA1 Message Date
Michael Kirk 753c445bfc [SSK] Update libphonenumber
// FREEBIE
8 years ago
Russ Shanahan e7126f8c60 Less confusing "#" avatar for unknown Contact instead of "+"
For consistency with the Android and Desktop client behavior.

* Show a placeholder avatar when no image, initials (#1512)

  If all we know about the user is their phone number, their avatar image
  is rendered as a placeholder. Previously, it would render the first few
  characters of their phone number as if they were initials (eg. "+")

* Rename, extend OWSContactsManager methods (#1512)

  Rename from: nameStringForPhoneIdentifier
           to: displayNameForPhoneIdentifier

  Also, add:
  - (BOOL)nameExistsForPhoneIdentifier:(NSString *)identifier;

  Which reports whether there's any "name" for a contact.

* Remove unused typedefs

  These aren't used in the project anymore, and they were causing
  compiling warnings due to a lack of nullability indication.

* Resolve some OWSContactsManager nullability warnings

  Did a pass through all of the existing nullability warnings in
  OWSContactsManager. Tried to pick descriptors that best reflected the
  behavior of the methods.

// FREEBIE
8 years ago
Michael Kirk fb508470d9 Bump build
// FREEBIE
8 years ago
Michael Kirk 1dcd1830e6 Fix crash in group member listing
Restore contactsComparator which is still being used in the group member
listing

partial revert of 81e1ec4b9e

// FREEBIE
8 years ago
Michael Kirk 273b3a3ac7 Update translations
// FREEBIE
8 years ago
Michael Kirk a84bff3c64 bump build
// FREEBIE
8 years ago
Thomas Guillet e58de07af7 Prevent going to the "Background Notifications" when tapping "Notification Sounds" 8 years ago
Michael Kirk e6f0130f35 Fix peek from inbox (#1509)
fixes #1506

// FREEBIE
8 years ago
RiseT f29a0fe49b Change safety number strings to be singular
// FREEBIE
8 years ago
Michael Kirk 942353cba2 Fix crash on "show safety numbers" in group thread
// FREEBIE
8 years ago
Michael Kirk 5a0141003d "No Contacts" screen uses new invite flow
fixes #1501

// FREEBIE
8 years ago
Russ Shanahan 81e1ec4b9e Compare both first and last names when sorting (#1487)
If two names have the same last name, ensure we fall back on the
first name when sorting them.

// FREEBIE
8 years ago
Michael Kirk d6e9745956 Bump version
// FREEBIE
8 years ago
Michael Kirk f0461891e0 Convert Localizable.strings tools to UTF-8 (#1420)
- Update translations
- Updated transifex scripts to convert appropriately
- Run script from any dir
- Check that target directories exist
- We're currently not pulling any strings from JSQMVC

UTF-8 is preferred since we can see diffs in GH and have sane merges.

// FREEBIE
8 years ago
Josh Schneier 896dd026d2 Remove DJWActionSheet 8 years ago
Josh Schneier f686fc9a87 Style refactor to reduce rightward drift
// FREEBIE
8 years ago
Michael Kirk ed29b154b8 update translations
// FREEBIE
8 years ago
Michael Kirk f30c733ef3 Custom contact picker for invite flow
Preferred to the system contact picker because:
1. removes "group" clutter from header, unlikely to be used much.
2. can select while searching
3. fixes unified contact problem where e.g.
   If only one of your contact has a phone number, they appear disabled
   when choosing to invite via messaging, even though the other linked
   contact *does* have a phone number.
4. label users w/o email so it's clearer why they can't be selected

Also:

* Twitter share-image was too tall

// FREEBIE
8 years ago
Michael Kirk f9a60b622d Use cleaner signal link in invite email
// FREEBIE
8 years ago
Michael Kirk 7120ca1192 Make sure we're laying out contact cell after assigning avatar
// FREEBIE
8 years ago
Michael Kirk 2bac3e4280 Better fit for "delete account" button on iPhone5
- move invite button faaaaaaaar away from the "delete account" button.

// FREEBIE
8 years ago
Michael Kirk 0aa226f3d1 [SSK] If a new message type is introduced, ignore it
rather than printing an empty bubble.

// FREEBIE
8 years ago
Michael Kirk 06ca3c9290 Mail and Message invite flow
* Spruce up compose contact-picker
- Fix random sorting for contacts missing first or last name
- Add Avatar to contact picker
- de-dupe contacts

Better copy for INVALID_MESSAGE error.

// FREEBIE
8 years ago
Michael Kirk bed5250397 remove redunant method
// FREEBIE
8 years ago
Josh Schneier c0c71fe261 Switch back to the default keyboard after sending 8 years ago
Michael Kirk 584118a9fc compare safety numbers with clipboard (#1475)
* Compare safety numbers with clipboard

// FREEBIE
8 years ago
Michael Kirk de7752ab20 Revert 50abf4d02d
The real problem was addressed (or, worked around) here:
1eb234e8ba

// FREEBIE
8 years ago
Igor Ranieri Elland a0dc5950fc Automatically adjust message bubble text size on dynamic text changes. (#1469)
* Automatically adjust message bubble text size on dynamic text changes.

- Addresses part of #1453.

* Renamed dynamic text notification handler method.
8 years ago
Mike 40c3a01b3e Update README with link to development guide
The results of #1442 should probably be referenced in the README.

FREEBIE
8 years ago
Igor Ranieri Elland e67af9d52b Make settings modal.
- Issue raised in #1453.
8 years ago
Thomas Guillet f1b4bd772c Prevent bogus message emission on group deletion
Only send a message if the local number is part of the group

* Fix error on empty group #1449
* Fix an unlogged issue about notification sent to group members even is the local user already quit the group
8 years ago
Russ Shanahan 087f753979 Voiceover fix- Do not read "no messages" text when it's hidden (#1437) FREEBIE 8 years ago
Russ Shanahan b40f6acd01 Voiceover fix: Message author read as thread name (#1437) FREEBIE
There was a bug in voiceover mode. When reading messages, Voiceover
would read out "message author: message content" for each chat bubble,
but the message author was always the name of the chat. So if it was
a contact chat, every message would be read as if from the other party,
and if it was a group chat, every message would be from the title of
the group.

This patch looks up the display name for the given signal id so
Voiceover reads the correct name for each message. It will read "Me" if
the message is outgoing.
8 years ago
Michael Kirk 89451013d9 Bump build target
// FREEBIE
8 years ago
Malcolm Hall 5213822e77 Update BUILDING.md
Added required instructions for building under a different team.
8 years ago
Michael Kirk 88d9ef987f Share dialog for Safety Numbers
// FREEBIE
8 years ago
Michael Kirk 9b2c03793c [SSK] explicit newlines in safety numbers
// FREEBIE
8 years ago
Michael Kirk d76f26e43b Bump version.
This might look like a typo, but due to earlier flubbing the build
number, we need a larger build number to be able to upload, until the
next release at which point we can resume a sane bundle version number.

// FREEBIE
8 years ago
Michael Kirk ee29fff0da [SSK] Default to blocking changed Safety Numbers
// FREEBIE
8 years ago
Michael Kirk eb995cb389 revert to tracking longform build
We use this to determine which legacy migrations to run.

Also, soften the "your device is too old" behavior to just exit, rather
than blow away the users installation. Ouch!

* bump version

// FREEBIE
8 years ago
Michael Kirk 7cae804217 Update translations, bump build.
// FREEBIE
8 years ago
Michael Kirk f8da3132f4 Bump build
// FREEBIE
8 years ago
Michael Kirk c5be8f2d88 Don't include phone number in scannable safety number QR code
also fixes #1455

// FREEBIE
8 years ago
Michael Kirk d3c2f44aeb Exclude extra data detectors.
Data detectors work by matching local text against a series of local
matchers. No network activity is required. Some of the data detectors
are really useful (e.g. a link, or being able to copy a phone number).

Some aren't very useful, e.g. pop culture references, and seeing things
underlined is giving people the false impression that their data is
being inspected remotely.

// FREEBIE
8 years ago
Michael Kirk fbcf5fbf07 Properly assign global contacts updater to environment
broken in 33f6a95520

// FREEBIE
8 years ago
Michael Kirk ddeadafc3b Don't show own addressbook info in settings
Some folks get the wrong idea and think Signal Service knows their name,
when really, we were just showing them the entry for the registered
phone number in their address book.

In any case, presumably the user already knows their name, so we don't
need to remind them.

// FREEBIE
8 years ago
Michael Kirk 7bcf5190b4 Address some lingering emoji cropping
This is an expedient, but not good, "fix". Some messages are going to
have extra space at the bottom of the bubble. But, for the time being,
that's preferable to getting messages clipped.

// FREEBIE
8 years ago
Michael Kirk 01a3ef015f Don't show permissions pop-up until user has seen contact disclaimer (#1456)
// FREEBIE
8 years ago
Michael Kirk 3bbdd13fbe Bump version
// FREEBIE
8 years ago
Michael Kirk c2aa17e362 Changed Safety numbers no longer block communication
When your partner changes their identity key (e.g. by reinstalling),
you'll see a notice alongside their message, but it will no longer
prevent the message from showing. aka "non blocking".

Existing users will be opted into the previous blocking behavior.

This is configurable for all users in Settings > Privacy.

// FREEBIE
8 years ago