Commit Graph

1361 Commits (9c9545b4088cec57a47bc7c79c342e0b29b17d4b)

Author SHA1 Message Date
Michael Kirk 1fae83a777 respect any CDN headers (eg Host for front) 5 years ago
Matthew Chen a3efb58d15 Respond to CR. 5 years ago
Matthew Chen 517a550593 Further improve "first responder" behavior in the image editor. 5 years ago
Matthew Chen eb5cf3978c Fix first responder issue in image editor. 5 years ago
Matthew Chen db958f4a01 Preserve caption text of edited images. 5 years ago
Matthew Chen d9760b6bbc Fix bug around layer ordering when rendering image editor output. 5 years ago
Matthew Chen 5973c326de Ensure new text items are on the canvas. 5 years ago
Michael Kirk f8244eeefe Fix SAE crash for iOS9 5 years ago
Michael Kirk 58d99a480f Notify iOS9 users occasionally that iOS10 will soon be required 5 years ago
Matthew Chen 3ce3f9faaa Add accessibilityIdentifiers to conversation settings view. 5 years ago
Matthew Chen f073dd9a52 Add accessibilityIdentifiers to conversation settings view. 5 years ago
Matthew Chen 4188993fc5 Add accessibilityIdentifiers to 'new contact thread' view. 5 years ago
Matthew Chen 95e125d55e Simplify usage of accessibilityIdentifiers. 5 years ago
Matthew Chen 2d854406a1 Add accessibilityIdentifiers to home view. 5 years ago
Michael Kirk ed6b461662 search icon 5 years ago
Matthew Chen a7ae79aaad Ignore keyboard notifications while the view is disappearing or has disappeared. 5 years ago
Matthew Chen 558b5f5816 Tap to dismiss caption editor. 5 years ago
Matthew Chen 4ea608cd45 Ensure status bar is hidden in image editor subviews. 5 years ago
Michael Kirk e3cc8bb101 Keep results bar visible when dismissing keyboard or returning to view. 5 years ago
Michael Kirk 3850ca29b0 Bigger hack to fix problem with lesser hack.
There were two symptoms to this bad "leave app while dismissing keyboard"
state...

The first, most noticeable symptom was that the main window no longer respected
the device orientation. This was caused by UIKit temporarily disabling
autorotate during an interactive keyboard dismissal, and not cleaning up after
itself when we hid the window mid dismissal due to our screen protection
feature. This was solved previously in: ca0a555f8

The second symptom remained, and is solved by this commit. Wherein after
getting in this bad state, the interactive keyboard dismiss function behaves
oddly. Normally when interactively dismissing the keyboard in a scroll view,
the keyboard top follows your finger, until you lift up your finger, at which
point, depending on how close you are to the bottom, the keyboard should
completely dismiss, or cancel and return to its fully popped position. In the
degraded state, the keyboard would follow your finger, but when you lifted your
finger, it would stay where your finger left it, it would not complete/cancel
the dismiss.

The solution is, instead of only re-enabling autorotate, to use a higher level
private method which is called upon complete/cancellation of the interactive
dismissal. The method, `UIScrollToDismissSupport#finishScrollViewTransition`,
as well as re-enabling autorotate, does some other work to restore the UI to
it's normal post interactive-keyboard-dismiss gesture state.

For posterity here's the decompiled pseudocode:

```
/* @class UIScrollToDismissSupport */
-(void)finishScrollViewTransition {
    *(int8_t *)&self->_scrollViewTransitionFinishing = 0x0;
    [self->_controller setInterfaceAutorotationDisabled:0x0];
    [self hideScrollViewHorizontalScrollIndicator:0x0];
    ebx = *ivar_offset(_scrollViewNotificationInfo);
    [*(self + ebx) release];
    *(self + ebx) = 0x0;
    esi = *ivar_offset(_scrollViewForTransition);
    [*(self + esi) release];
    *(self + esi) = 0x0;
    return;
}
```
5 years ago
Matthew Chen 908fe1d0c9 Apply presentAlert() throughout codebase. 5 years ago
Matthew Chen 882dd16d7c Apply presentAlert() throughout codebase. 5 years ago
Matthew Chen c9d62f47cc Respond to CR. 5 years ago
Matthew Chen 1a80f0c293 Add accessibility identifiers to privacy popups and subviews. 5 years ago
Matthew Chen cb5ce42e76 Add accessibility identifiers to privacy popups and subviews. 5 years ago
Matthew Chen f37a3059fa Add accessibility identifiers to debug log popups. 5 years ago
Matthew Chen 81508e9d02 Add accessibility identifiers to settings popups. 5 years ago
Matthew Chen d7b1e65a71 Add accessibility identifiers to blocklist popups. 5 years ago
Matthew Chen f1520d760e Add accessibility identifiers to other settings views. 5 years ago
Matthew Chen b48e204b90 Add accessibility identifiers to notification settings views. 5 years ago
Matthew Chen 931d249677 Modify OWSFlatButton to propagate the accessibility identifier to wrapper button. 5 years ago
Matthew Chen 41a3c95831 Add missing accessibility ids in block list view. 5 years ago
Matthew Chen 8bcc19e36c Add missing accessibility ids in block list view. 5 years ago
Matthew Chen 52d6aa69b8 Improve measurement of image editor text layers. 5 years ago
Michael Kirk 0b638f4831 link checks 5 years ago
Michael Kirk 78ce3583ed fix rotation issue 5 years ago
Matthew Chen 050a9676f6 Add accessibility identifiers to select recipient views. 5 years ago
Matthew Chen c3857e5dff Add accessibility identifiers to select recipient views. 5 years ago
Matthew Chen 79d6384bc9 Add accessibility identifiers to privacy settings view. 5 years ago
Matthew Chen c37f425d5f Reduce logging. 5 years ago
Matthew Chen 3795fd1381 Enable image editor in production. 5 years ago
Matthew Chen 441c784146 Add preview view to the color palette control. 5 years ago
Michael Kirk 284357137f Photo/Movie Capture 5 years ago
Matthew Chen 684cebf2df Respond to CR. 5 years ago
Matthew Chen a48c3d8d20 Ensure attachment approval becomes first responder if app returns from background. 5 years ago
Matthew Chen f9445359d9 Fix layout glitch related to attachment approval input accessory background. 5 years ago
Matthew Chen a559b61056 Fix keyboard return behavior in attachment approval. 5 years ago
Matthew Chen 660f35147f Hide status bar in image editor modals. 5 years ago
Matthew Chen 25e7818f56 Ensure proper z-ordering of item layers. 5 years ago
Matthew Chen d824c49c07 Respond to CR. 5 years ago