Michael Kirk
249a3fcabc
Show proper setting for CallKitPrivacy
...
// FREEBIE
8 years ago
Michael Kirk
845c286b43
bump version
...
// FREEBIE
8 years ago
Michael Kirk
742f8cf902
Avoid unnecessariy flashing avatars
...
Make avatar building sync
Tests on a iPhone5 with 1k threads, 3k contacts show no noticeable lag.
Profiling shows ~4% of usage goes to contact avatar building, but once
cached, even that goes towards zero.
// FREEBIE
8 years ago
Michael Kirk
092578045e
[DEBUG-UI] create fake contact threads
...
// FREEBIE
8 years ago
Matthew Chen
63e20cd8bb
Sketch out profile manager.
...
// FREEBIE
8 years ago
Matthew Chen
74009a3207
Modify l10n string extraction script to reflect SSK move.
...
// FREEBIE
8 years ago
Matthew Chen
3c3bd3c914
Tweaks to registration views.
...
// FREEBIE
8 years ago
Matthew Chen
1e002f7ef2
Bump build from to 2.15.0.4.
...
// FREEBIE
8 years ago
Matthew Chen
a0eead37c7
Ensure size of message mappings range increases monotonically.
...
// FREEBIE
8 years ago
Michael Kirk
a196693425
Make sure DB views are ready before kicking processing job
...
// FREEBIE
8 years ago
Michael Kirk
6a5c6a9fc9
didBecomeActive kicks the processing queue
...
// FREEBIE
8 years ago
Matthew Chen
31d65c3d77
Fix RTL alignment of message footers.
...
// FREEBIE
8 years ago
Michael Kirk
feb1061c04
Fix spinner layout on iphone5
...
// FREEBIE
8 years ago
Matthew Chen
43f451e236
Remove errant assert.
...
// FREEBIE
8 years ago
Matthew Chen
5acb3714e9
Add debug UI to enable manual censorship circumvention.
...
// FREEBIE
8 years ago
Matthew Chen
75c7cc4abf
Add debug UI to enable manual censorship circumvention.
...
// FREEBIE
8 years ago
Matthew Chen
d22e29ec09
Include local number when creating debug groups.
...
// FREEBIE
8 years ago
Matthew Chen
8f17730d9b
Modify “create groups” debug UI to use current 1:1 contact.
...
// FREEBIE
8 years ago
Matthew Chen
653f7faca8
Add debug UI for creating groups.
...
// FREEBIE
8 years ago
Matthew Chen
1c3dd8cac4
Bump build from to 2.15.0.3.
...
// FREEBIE
8 years ago
Matthew Chen
1890039165
Hide empty conversations in home view.
...
// FREEBIE
8 years ago
Matthew Chen
103a7fab36
Hide empty conversations in home view.
...
// FREEBIE
8 years ago
Matthew Chen
6dff283de4
Update l10n strings.
...
// FREEBIE
8 years ago
Matthew Chen
75fb55e018
Merge tag '2.14.1.2'
...
// FREEBIE
8 years ago
Matthew Chen
bca736a2b7
Merge tag '2.13.4.0'
...
// FREEBIE
8 years ago
Matthew Chen
3f805d31d5
Bump build from to 2.15.0.2.
...
// FREEBIE
8 years ago
Matthew Chen
dd13119f12
Add more instrumentation to CallService.
...
// FREEBIE
8 years ago
Matthew Chen
904515994f
Add more instrumentation to CallService.
...
// FREEBIE
8 years ago
Matthew Chen
465711c2cb
Add script to extract and gather analytics event names.
...
// FREEBIE
8 years ago
Matthew Chen
f1807cd709
Add script to extract and gather analytics event names.
...
// FREEBIE
8 years ago
Matthew Chen
0cf9c01af2
Add script to extract and gather analytics event names.
...
// FREEBIE
8 years ago
Matthew Chen
8aff95c44e
Add script to extract and gather analytics event names.
...
// FREEBIE
8 years ago
Matthew Chen
b4f348ad14
Add script to extract and gather analytics event names.
...
// FREEBIE
8 years ago
Matthew Chen
31ab9a00da
Add script to extract and gather analytics event names.
...
// FREEBIE
8 years ago
Matthew Chen
6858a1e944
Fix assert in conversation view around nil title.
...
// FREEBIE
8 years ago
Matthew Chen
803e91c3ce
Fix assert in conversation view around nil title.
...
// FREEBIE
8 years ago
Matthew Chen
4ac7600c07
Respond to CR.
...
// FREEBIE
8 years ago
Matthew Chen
d4af62adcc
Instrument registration happy path with analytics.
...
// FREEBIE
8 years ago
Matthew Chen
f973af5a83
Streamline analytics properties.
...
// FREEBIE
8 years ago
Matthew Chen
013bf62f7c
Streamline analytics properties.
...
// FREEBIE
8 years ago
Michael Kirk
3f4dcecf15
ensure blocking keychange message has identityKey before proceeding
...
This is increasingly irrelevant due to recent safety number changes, but
legacy clients with old messages can still run into this.
FIXES: https://github.com/WhisperSystems/Signal-iOS/issues/2346
// FREEBIE
8 years ago
Michael Kirk
4d8429186d
Store undecrypted envelopes before doing any processing.
...
This lets us clear the server side queue immediately, and paves the way
for retry, give up logic.
// FREEBIE
8 years ago
Matthew Chen
f4fc6de6ed
Bump build from to 2.15.0.1.
...
// FREEBIE
8 years ago
Matthew Chen
d80f470c2c
Respond to CR.
...
// FREEBIE
8 years ago
Matthew Chen
2e7fe5cfd5
Rework database observation in home and message views.
...
// FREEBIE
8 years ago
Matthew Chen
1f1a681180
Rework database observation in home and message views.
...
// FREEBIE
8 years ago
Matthew Chen
c1139a3a28
Fix many leaks in the view controllers.
...
// FREEBIE
8 years ago
Matthew Chen
f0cecfad11
Surface memory leaks by logging the deallocation of view controllers.
...
// FREEBIE
8 years ago
Matthew Chen
511cbbeaaf
Make it easier to tap-to-edit group names in new group and update group vies.
...
// FREEBIE
8 years ago
Matthew Chen
863fd27abe
Respond to CR.
...
// FREEBIE
8 years ago
Matthew Chen
8e51b5ade1
Clean up ahead of PR.
...
// FREEBIE
8 years ago
Matthew Chen
958a8b4c80
Instrument CallService.
...
// FREEBIE
8 years ago
Matthew Chen
90945609e5
Bump version to 2.15.0.0.
...
// FREEBIE
8 years ago
Matthew Chen
9587aab37b
Instrument network errors.
...
// FREEBIE
8 years ago
Matthew Chen
117bca7c48
Instrument errors in app delegate.
...
// FREEBIE
8 years ago
Michael Kirk
c74a5c0740
CR: strong reference to migration job, clarify variable
...
// FREEBIE
8 years ago
Michael Kirk
a5f067936c
migration to fix any half-registered users
...
// FREEBIE
8 years ago
Matthew Chen
97772a32ff
Respond to CR.
...
// FREEBIE
8 years ago
Matthew Chen
9eaeba9af3
Address yet another edge cases around pasteboards that contain both textual and non-textual content, e.g. a gif and the URL of that gif.
...
// FREEBIE
8 years ago
Matthew Chen
ceb243b30b
Always reload home view table when changing grouping.
...
// FREEBIE
8 years ago
Matthew Chen
03aacbd682
[SSK] Try applying national prefixes when parsing phone numbers.
...
// FREEBIE
8 years ago
Matthew Chen
fdac0305cb
Update analytics macros.
...
// FREEBIE
8 years ago
Matthew Chen
14621e1288
Respond to CR.
...
// FREEBIE
8 years ago
Matthew Chen
34f7cd1a47
Clean up ahead of PR.
...
// FREEBIE
8 years ago
Matthew Chen
02c510691c
Adapt number formatting to RTL.
...
// FREEBIE
8 years ago
Matthew Chen
5edec99fd6
Adapt number formatting to RTL.
...
// FREEBIE
8 years ago
Matthew Chen
04fb3642b2
Remove .xib for home view cells; adapter home view to RTL.
...
// FREEBIE
8 years ago
Matthew Chen
eaacac9d8b
DRY up common table cell patterns.
...
// FREEBIE
8 years ago
Matthew Chen
96fd5e11e5
Adapt more UI elements to RTL.
...
// FREEBIE
8 years ago
Matthew Chen
c799e18c74
Adapt voice messages UI to RTL.
...
// FREEBIE
8 years ago
Matthew Chen
8005cf0227
Adapt conversation settings view to RTL.
...
// FREEBIE
8 years ago
Matthew Chen
d4e62efce5
Adapt call view to RTL.
...
// FREEBIE
8 years ago
Matthew Chen
e2125978de
Adapt "new group" and "update group" views to RTL.
...
// FREEBIE
8 years ago
Matthew Chen
693e74e868
Adapt conversation settings view to RTL.
...
// FREEBIE
8 years ago
Matthew Chen
656cc47de5
Adapt registration views to RTL.
...
// FREEBIE
8 years ago
Matthew Chen
d4f012fbb7
Fix contact table cell and “add to block list” view.
...
// FREEBIE
8 years ago
Matthew Chen
e15432720c
Add arabic translation; begin work on right-to-left layout.
...
// FREEBIE
8 years ago
Michael Kirk
e52248fe39
Localize JSQMessagesViewController within Signal
...
// FREEBIE
8 years ago
Michael Kirk
18ff072763
bump build
...
// FREEBIE
8 years ago
Michael Kirk
be731b7b2a
sync translations
...
// FREEBIE
8 years ago
Michael Kirk
3cbab3fe34
bump build
...
// FREEBIE
8 years ago
Matthew Chen
a9ce1cde2f
Simplify CallViewController.
...
// FREEBIE
8 years ago
Matthew Chen
149c64ce49
Refine call service.
...
// FREEBIE
8 years ago
Michael Kirk
46ddaa9cae
fix: unregistered user shows "add to contacts"
...
// FREEBIE
8 years ago
Michael Kirk
17b1b70726
Remove verification debug UI
...
There is a more true-to-life way to set verification state - mark
someone as verified or default via the SN UI.
If they are marked as verified, you can mark them as no-longer-verified
by toggling a keychange in the debug UI
// FREEBIE
8 years ago
Michael Kirk
df0cf76603
Assert that mapping is set whenever accessing
...
// FREEBIE
8 years ago
Michael Kirk
1c9ce5eaf3
CR: Don't just build, but present, alert controller
...
// FREEBIE
8 years ago
Michael Kirk
5c66e5584c
Adding to existing contact requires contact access
...
Previously we'd show an empty "list" of existing contacts.
// FREEBIE
8 years ago
Matthew Chen
8b60765627
Respond to CR.
...
// FREEBIE
8 years ago
Matthew Chen
81a4ebdaf5
Apply OWSTableViewController to more views.
...
// FREEBIE
8 years ago
Matthew Chen
dc3f07cb54
Apply OWSTableViewController to more views.
...
// FREEBIE
8 years ago
Michael Kirk
7c6d900314
sync translations
...
// FREEBIE
8 years ago
Michael Kirk
33e9f2e62e
bump version
...
// FREEBIE
8 years ago
Michael Kirk
f027d400ba
Bump build
...
// FREEBIE
8 years ago
Michael Kirk
2d23e365cb
sync translations
...
// FREEBIE
8 years ago
Michael Kirk
9287b8560c
clean up comments per code review
...
// FREEBIE
8 years ago
Michael Kirk
fb5c17a6b4
minimize sound overlap
...
Because there is some asynchrony involved, there may be a blip during
the switch between sounds/audio sessions
// FREEBIE
8 years ago
Michael Kirk
e3faddedbc
Disallow bluetooth when user has opted for local receiver
...
// FREEBIE
8 years ago
Michael Kirk
524ba80b75
WIP: have ensureAudioSession set preferred input
...
Call it all the time, but only mutate the AVAudioSession when necessary
TODO
Can't switch to iPhone
// FREEBIE
8 years ago
Michael Kirk
220cd345f6
add comments
...
// FREEBIE
8 years ago
Michael Kirk
ba97ff3f5f
Label tweaks for device listing
...
// FREEBIE
8 years ago
Matthew Chen
d36e60b0e9
Respond to CR.
...
// FREEBIE
8 years ago
Matthew Chen
b6264383d3
Add possible fixes for the ‘empty home view’ issue.
...
// FREEBIE
8 years ago
Matthew Chen
90dabe1c81
Add possible fixes for the ‘empty home view’ issue.
...
// FREEBIE
8 years ago
Matthew Chen
f52814bb70
Add possible fixes for the ‘empty home view’ issue.
...
// FREEBIE
8 years ago
Matthew Chen
3f805cd4cd
Add possible fixes for the ‘empty home view’ issue.
...
// FREEBIE
8 years ago
Matthew Chen
5e58079e13
Update l10n strings.
...
// FREEBIE
8 years ago
Matthew Chen
5633982262
Bump build from to 2.14.0.3.
...
// FREEBIE
8 years ago
Michael Kirk
b8ec353d77
Use recommended approach for speakerphone mode
...
From: https://developer.apple.com/library/content/qa/qa1754/_index.html
Q: Can you explain the difference between calling the AVAudioSession method overrideOutputAudioPort: with the value AVAudioSessionPortOverrideSpeaker and using the category option AVAudioSessionCategoryOptionDefaultToSpeaker with setCategory:withOptions:error:.
A: The difference is that setting the AVAudioSessionPortOverride by calling overrideOutputAudioPort: is more transient than using the category option AVAudioSessionCategoryOptionDefaultToSpeaker.
Important: The use of both AVAudioSessionPortOverrideSpeaker and AVAudioSessionCategoryOptionDefaultToSpeaker are only applicable to the AVAudioSessionCategoryPlayAndRecord category.
Calling overrideOutputAudioPort: and setting the AVAudioSessionPortOverride to AVAudioSessionPortOverrideSpeaker is a way of temporarily overriding the output to play to the speaker. Any route change or interruption will cause the audio to be routed back to its normal route, following the last-in wins rule. Think of using overrideOutputAudioPort: in terms of what you might use to implement a Speakerphone button where you want to be able to toggle between the speaker (AVAudioSessionPortOverrideSpeaker) and the normal output route (AVAudioSessionPortOverrideNone).
Note: This property is intended to allow 3rd party applications to mimic the behavior of a Speakerphone button and therefore may change the input route as well as output route. For example, setting the AVAudioSessionPortOverride to AVAudioSessionPortOverrideSpeaker while a headset is plugged in will cause the route to change to built-in mic / built-in speaker.
// FREEBIE
8 years ago
Michael Kirk
fa42b4a45b
Respect disappearing message timer from lockscreen
...
// FREEBIE
8 years ago
Matthew Chen
6c61e6040c
Fix another call view leak.
...
// FREEBIE
8 years ago
Matthew Chen
90ad83d494
Bump build from to 2.14.0.2.
...
// FREEBIE
8 years ago
Michael Kirk
90c2324f99
pixel cleanup in bluetooth speaker image
...
// FREEBIE
8 years ago
Michael Kirk
b495b23420
more cleanup and commenting
...
// FREEBIE
8 years ago
Michael Kirk
03f1bbca62
Move state from CallViewController -> Call
...
I think whenever reasonable we prefer to consodlidate state on the call
// FREEBIE
8 years ago
Michael Kirk
4e11e90ebb
cleanup
...
- remove dead code
- rename vars
- add coments
// FREEBIE
8 years ago
Michael Kirk
a59eb25aef
extract dismiss string -> CommonStrings.dismissButton
...
// FREEBIE
8 years ago
Michael Kirk
20a8e72198
disable audio source images until we have icons
...
// FREEBIE
8 years ago
Michael Kirk
9bd68ed490
WIP: bluetooth shows audio route button instead of speakerphone
...
// FREEBIE
TODO
NEED
-[ ] icon in route picker
-[ ] commit cleanup
NICE
-[ ] present action sheet automatically when making outgoing bluetooth call
-[ ] left align icons
-[ ] audio is paused when switching between video mode (maybe existing behavior, not sure)
-[ ] Copy: iPhone/iPad/iPod instead of "iPhone Microphone"
DONE
-[x] remove "receiver" from options while in video mode
-[x] show available audio routes
-[x] select available audio routes
-[x] notification if availabe inputs change so we can update call screen
mid call with available BT route
-[x] include speakerphone in choices
-[x] Enabled button shows active speakerphone. Should still show
bluetooth picker.
-[x] toggle back and forth between audio devices
-[x] hide audio route button in video mode if no BT available
-[x] Fixed: When on speakerphone - switching to video mode goes back to bluetooth.
-[x] Fixed: When switching to video w/ bluetooth device connected there is no
audio picker.
-[x] respect speakerphone/BT selection when in or toggling to/from video
-[x] do not hide audio route button when in video mode and bluetooth
connected
-[x] Show which is currently selected audio route
-[x] switching to speakerphone no longer works
-[x] switching *back* to bluetooth no longer works
-[x] add proper bluetooth button for audio calls
-[x] add proper bluetooth button for video calls
8 years ago
Michael Kirk
109cb6cdb6
rename for clarity
...
// FREEBIE
8 years ago
Matthew Chen
ce048e21d2
Bump build from to 2.14.0.1.
...
// FREEBIE
8 years ago
Matthew Chen
ac616d6936
Reject the “call connected” promise immediately when clearing a call.
...
// FREEBIE
8 years ago
Matthew Chen
a58c71f4b8
Fix leak of call view.
...
// FREEBIE
8 years ago
Michael Kirk
b82aedc3a0
Assertion failures for unexpected promise state
...
These don't currently result in failed calls, but we should at least
know about it in debug.
// FREEBIE
8 years ago
Michael Kirk
438635393b
Don't send ICE updates until after the CallOffer has been sent.
...
This ensures message ordering for clients that can't handle out of order
call messages (legacy iOS and Android).
Even when we revert the previous commit, to send ICE Updates sooner,
we'll want to keep this (until we're confident all clients can receive
out of order call messages)
// FREEBIE
8 years ago
Michael Kirk
d910da0157
Partial revert of: Send ICE updates immediately - 2dcfb4e3b8
...
That change makes it more likely that the remote client will receive an
ICE update before their peer connection client is set.
We want to ship the robustness fix (waitForPeerConnection in
handleRemoteAddedIceCandidate) before we have the caller start sending
ICE updates immediately, in a future release.
At that time, we can simply revert this commit.
// FREEBIE
8 years ago
Michael Kirk
2067697ed4
Add comment and clearer tests per CR
...
// FREEBIE
8 years ago
Michael Kirk
4f1ee98489
scrub any data that slips through to logs
...
Similar to phone number scrubbing, we leave a short prefix of the data
to help with debugging without leaking much data.
// FREEBIE
8 years ago
Matthew Chen
b7c2512eac
Respond to CR.
...
// FREEBIE
8 years ago
Matthew Chen
81555d1225
Add “new contact” and “add to existing contact” buttons in 1:1 conversation settings view.
...
// FREEBIE
8 years ago
Matthew Chen
1e67bb52e3
Respond to CR.
...
// FREEBIE
8 years ago
Matthew Chen
2202fe70fe
Fix broken tests.
...
// FREEBIE
8 years ago
Matthew Chen
f584c4b434
Fix broken tests.
...
// FREEBIE
8 years ago
Matthew Chen
0b28285deb
Fix broken tests.
...
// FREEBIE
8 years ago
Matthew Chen
69ba2811db
Run orphan cleanup on startup.
...
// FREEBIE
8 years ago
Michael Kirk
d15da6e6d4
fix bubble calculator tests
...
// FREEBIE
8 years ago
Michael Kirk
82180f6a97
fix compilation problems
...
// FREEBIE
8 years ago
Matthew Chen
c9355630c7
Respond to CR.
...
// FREEBIE
8 years ago
Matthew Chen
d639d6557e
Add owsFail free function for swift.
...
// FREEBIE
8 years ago
Matthew Chen
669e0644ea
Respond to CR.
...
// FREEBIE
8 years ago
Matthew Chen
5cf0441f55
Add a reminder that you are in archive view.
...
// FREEBIE
8 years ago
Matthew Chen
54a5b960c7
Add a reminder that you are in archive view.
...
// FREEBIE
8 years ago
Matthew Chen
8f3b837a65
Add a reminder that you are in archive view.
...
// FREEBIE
8 years ago
Matthew Chen
2e727a24b5
Convert home view to programmatic layout.
...
// FREEBIE
8 years ago
Michael Kirk
5223104566
respect system sort order for contacts
...
// FREEBIE
8 years ago
Matthew Chen
b19dd648d2
Bump build number to v2.14.0.0.
...
// FREEBIE
8 years ago
Michael Kirk
2dcfb4e3b8
Send ICE updates immediately.
...
Now that SN changes do not block incoming messages, the caller does not
need to enqueue outgoing ICE updates.
However this introduces the possibility that the call recipient could
recieve an ICE update before their peerConnectionClient is set up - so
now we ensure that call service waits for it's peerConnectionClient
before processing incoming ICE updates.
// FREEBIE
8 years ago
Matthew Chen
1a400f8414
Respond to CR.
...
// FREEBIE
8 years ago
Matthew Chen
b6531a8b5d
If two users call each other at the same time, ensure they both see “busy”.
...
// FREEBIE
8 years ago
Michael Kirk
f681712ea0
Code Cleanup
...
- make some logging clearer
- remove noisy unhelpful logging
- clearer method names
// FREEBIE
8 years ago