Commit Graph

2569 Commits (8f9311a6ac5ffcb5cc15b01826b391d59ebcbbcd)

Author SHA1 Message Date
Michael Kirk 0cd56d4bcc On iOS11 doc picker requires system appearance.
Otherwise nav items are illegible.

// FREEBIE
8 years ago
Michael Kirk 64c7c40b81 CR: add shadow to activity indicator
// FREEBIE
8 years ago
Michael Kirk 2af99eb710 Allow canceling GIF download
// FREEBIE
8 years ago
Michael Kirk 891cc6ee0d CR: better method names
// FREEBIE
8 years ago
Michael Kirk 6eaa49593d preview vs. sending have independent resolution min
// FREEBIE
8 years ago
Michael Kirk 688810c267 CR: Enforce "one time only" with a bool, not a cell ref
Since cell's can be re-used, at a later point, we might not be
referencing the data we intend. Since all we want to do is enforce a
"one time only" check, just use a bool.

// FREEBIE
8 years ago
Michael Kirk 591cba6468 fix comment typos
// FREEBIE
8 years ago
Michael Kirk a01de44917 Fix intermittent crash
// FREEBIE
8 years ago
Michael Kirk 6db5895269 dismiss keyboard when scrolling after auto-search
// FREEBIE
8 years ago
Michael Kirk be51776d82 Fix mask appearing partially above search bar
// FREEBIE
8 years ago
Michael Kirk 37177de7cb Make sure user knows what they're picking
Abort selection until *some* kind of asset has been downloaded.

// FREEBIE
8 years ago
Michael Kirk e4ad169d71 Show retryable error alert when fetching GIF fails
// FREEBIE
8 years ago
Michael Kirk 3939e8a6ac Download picked GIF faster: cancel pending request
// FREEBIE
8 years ago
Michael Kirk b8ce636afc Show loading screen while selected GIF downloads
// FREEBIE
8 years ago
Michael Kirk ddf2fe21a1 Download smaller GIF for previews.
Previously we were downloading a full sized GIF for each cell, which can
take dozens of seconds on a slower connection. Now we download a smaller
GIF for the picker view, and only download the full sized GIF for the
selected cell.

Some stats:

Before:

Scenario: search "Cat" and no scrolling, no picking
~10 MB

Scenario: search "Cat" and no scrolling, then pick
~10 MB

Scenario: search "Cat" and scroll 3 screens, no picking
~30 MB

Scenario: search "Cat" and scroll 3 screens, then pick
~30 MB

After:

Scenarios: search "Cat" and no scrolling, no picking
~1.0 MB (savings 90%)

Scenarios: search "Cat" and no scrolling, then pick
~3.5 MB (savings 65%)

Scenarios: search "Cat" and scroll 3 screens, no picking
~3.0 MB (savings 90%)

Scenarios: search "Cat" and scroll 3 screens, then pick
~5.5 MB (savings 81%)

// FREEBIE
8 years ago
Michael Kirk 2a4c6506fb log giphy data usage in debug
// FREEBIE
8 years ago
Matthew Chen 7fa7d5d526 Fix "mark as read."
// FREEBIE
8 years ago
Matthew Chen b0aa84e420 Clean up conversation view.
// FREEBIE
8 years ago
Matthew Chen d355b45bae Reduce relayout and reload churn; respond to dynamic type changes.
// FREEBIE
8 years ago
Matthew Chen c2608785e1 Reduce relayout and reload churn; respond to dynamic type changes.
// FREEBIE
8 years ago
Matthew Chen 4dc6934fc7 End text editing if we leave conversation view.
// FREEBIE
8 years ago
Matthew Chen bd5639baaf Linkify text messages.
// FREEBIE
8 years ago
Matthew Chen bf80e6dd36 Fix broken message cell layout.
// FREEBIE
8 years ago
Matthew Chen 45ba79d296 Auto-load more message if user scrolls near the top of the conversation.
// FREEBIE
8 years ago
Matthew Chen 1ad3add1d5 Fix message injection.
// FREEBIE
8 years ago
Matthew Chen c7097db939 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen f28abbc2a1 Revert from numeric to default keyboard after message send.
// FREEBIE
8 years ago
Matthew Chen 4dabb71815 Fix "can't send same GIF twice" issue.
// FREEBIE
8 years ago
Matthew Chen fb4d43d542 Fix "can't send same GIF twice" issue.
// FREEBIE
8 years ago
Michael Kirk 9eb4909185 bump build
// FREEBIE
8 years ago
Matthew Chen f3102e2761 Fix presentation animation of new "attachment approval" state of input toolbar.
// FREEBIE
8 years ago
Matthew Chen 0fe76aaab8 Move "attachment approval" into input toolbar.
// FREEBIE
8 years ago
Matthew Chen 298a4aa108 Simplify and fix edge cases around menu controller.
// FREEBIE
8 years ago
Matthew Chen 06eb794db6 Simplify and fix edge cases around long pressing on system message cells.
// FREEBIE
8 years ago
Matthew Chen 37841d9b67 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 4a94d039e8 Restore the input toolbar's placeholder text.
// FREEBIE
8 years ago
Matthew Chen c47573334b Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 3b945a9da2 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 88c874e4e6 Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen 257f8249bf Cull cached cell media outside a load window.
// FREEBIE
8 years ago
Matthew Chen 65efa7f836 Lazy load, eagerly unload & cache cell media.
// FREEBIE
8 years ago
Matthew Chen e77292c2a9 Add contentWidth property to ConversationViewCell.
// FREEBIE
8 years ago
Erik Strottmann d7f24e4808 Increase profile disclosure compression resistance
Prevents disclosure indicator in profile row of settings from collapsing
when the profile name is too long.

Fixes #2515.

// FREEBIE
8 years ago
Matthew Chen b269c72acb Respond to CR.
// FREEBIE
8 years ago
Matthew Chen f36ecbdfa6 Button locations in input toolbar should reflect RTL.
// FREEBIE
8 years ago
Matthew Chen cec614706e Button locations in input toolbar should reflect RTL.
// FREEBIE
8 years ago
Matthew Chen 2ec8522355 Fix the input toolbar.
// FREEBIE
8 years ago
Matthew Chen b9f6bbb369 Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen 163e66dd4f Restore "load more messages" functionality.
// FREEBIE
8 years ago
Matthew Chen ccb37bfac3 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen ae550fa960 Add actions to debug UI to inject fake incoming messages.
// FREEBIE
8 years ago
Matthew Chen ed350f8ea6 Add vertical scroll indicator to conversation view.
// FREEBIE
8 years ago
Matthew Chen a386ac5685 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen b90e9fcd64 Skip redundant GIF searches.
// FREEBIE
8 years ago
Matthew Chen 33d3c4123a Progressive GIF search shouldn't dismiss keyboard.
// FREEBIE
8 years ago
Matthew Chen 032ec59d1c Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 01691b7ade Ensure attachment masking is updated to reflect cell relayout.
// FREEBIE
8 years ago
Matthew Chen 212d5dd112 Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen ae27d062f6 Clamp content aspect ratio.
// FREEBIE
8 years ago
Matthew Chen b6a61afd5c Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen 46dc0acdfb Fix media cropping.
// FREEBIE
8 years ago
Matthew Chen 132d5b3408 Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen e91599d986 Restore message cell footers.
// FREEBIE
8 years ago
Matthew Chen 3723a4845f Restore message cell footers.
// FREEBIE
8 years ago
Matthew Chen c2f07bb3d8 Restore message cell footers.
// FREEBIE
8 years ago
Matthew Chen 227fd5280d Resize conversation view cells as necessary.
// FREEBIE
8 years ago
Matthew Chen f7bd813c9f Restore the date headers to the conversation view cells.
// FREEBIE
8 years ago
Michael Kirk 2716f50399 Bump version
// FREEBIE
8 years ago
Michael Kirk 6e12b9c898 Fix trailing edge of group member listing
// FREEBIE
8 years ago
Michael Kirk 603a7d2639 Merge branch 'release/2.18.0' 8 years ago
Michael Kirk ab05bd32e8 compose search cleanup per code review
// FREEBIE
8 years ago
Michael Kirk 0f859d6b20 Merge branch 'release/2.18.0' 8 years ago
Michael Kirk 9ae4a26eb1 Message details shows entire message
When viewing a longer message, to avoid the risk of the user not being
aware they can scroll down, we scroll to the last couple lines of the
message, ensuring they can see the meta-data.

// FREEBIE
8 years ago
Michael Kirk 038ca0d6a9 Fix invite via SMS in search
- whispersystems.org -> signal.org
- nav color was wrong since iOS10
- update search results after clearing post SMS invite

// FREEBIE
8 years ago
Michael Kirk 6a65ee6def Pull to refresh on homeview fetches messages.
This is useful when you're using censorship circumvention and unable to
receive push notifications.

// FREEBIE
8 years ago
Michael Kirk 3080cb512b Compose View: collation index and group search
- Include table index for contacts
- Fix extra spacing in OWS table view
- Separate search results into contact/invite sections
- Include groups in search results when composing new message
- Compose Screen search matches on group member names

// FREEBIE
8 years ago
Matthew Chen 866be07434 Bump build to 2.17.1.1.
// FREEBIE
8 years ago
Matthew Chen 7c82f6d448 Add workaround for bug in iOS 11.1 beta around hit area of custom back buttons.
// FREEBIE
8 years ago
Matthew Chen 49501a5d1b Respond to CR.
// FREEBIE
8 years ago
Matthew Chen b1624d6818 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen b833976b77 Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen 5621fe893c Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen fb408f980c Remove JSQ.
// FREEBIE
8 years ago
Michael Kirk 796be18c56 enable gif picker
// FREEBIE
8 years ago
Michael Kirk dd5a19d1fd Suspend while answering shows "Missed Call"
When awakened by a voip push, we get some arbitrary amount of background
time to connect the call (in practice this is ~30s) before the app is
suspended.

Though we were properly terminating the call upon being suspended, we
were not notifying the user that they had missed a call.

// FREEBIE
8 years ago
Michael Kirk a434a381f7 Merge branch 'hotfix/2.17.1' 8 years ago
Michael Kirk 23b8560b79 sync translations
// FREEBIE
8 years ago
Michael Kirk 2cc59dc166 bump version
// FREEBIE
8 years ago
Matthew Chen 44051bd7e7 Avoid deadlock in profile manager.
// FREEBIE
8 years ago
Michael Kirk 9a7e3cb9d8 Register for manual message fetching when unable to obtain push tokens
// FREEBIE
8 years ago
Michael Kirk df15c904bc Rework push registration
== Account Registration ==

Not complete until push tokens are uploaded

== Remote Notifications Registration ==

Extracted from PushManager

- wait for notification-settings registration to complete before
  requesting push tokens, otherwise it's possible token requests will
  be ignored.

- Less state required for push notification callbacks, specifically, we
  no longer need to ensure we've created a promise before the
  registration delegate methods get called.

- no more TOCFuture in Signal-iOS (still in SSK for now). It's not in
  cases of inexplicable behavior - one a recently, push notification
  premature free, in redphone, and more popular use, and I've seen two
  futures inexplicably being nil.  Instead, let's consolidate around
  PromiseKit for popularly used, maintained, strongly-typed futures.

- separate logic for registering for vanilla push/voip notifications
  (few dependencies) from responding to UILocalNotifications (lots of
  dependencies). Ultimately I'd like to consolidate the remaining
  UILocalNotifications logic with the existing NotificationsManager

== Misc ==

more debug logging
more uniform logging
remove stale logic around newly registered user

// FREEBIE
8 years ago
Matthew Chen b0e1904f96 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 7923eafe7c Use separate Giphy API key for Signal iOS.
// FREEBIE
8 years ago
Michael Kirk f314b2e50a Fix registration screen layout
// FREEBIE
8 years ago
Michael Kirk b5258be9b5 respond to code review
// FREEBIE
8 years ago
Michael Kirk 876521f4c3 Fetch messages sooner when launched from background
The only reason a notification wakes/launches the app is to fetch
messages.

However, upon launching, especially if the app had been killed, it can
take a second or two before being notified of the notification that woke
us. Rather than wait, just fetch messages ASAP.

// FREEBIE
8 years ago
Michael Kirk c7cfe188ee Sync push tokens on background launch as well
// FREEBIE
8 years ago
Matthew Chen 7d9c2825d8 Add progressive search to Gif picker.
// FREEBIE
8 years ago
Matthew Chen 5999178e78 Remove FLAnimatedImage.
// FREEBIE
8 years ago
Matthew Chen fd28e54132 Respond to CR.
// FREEBIE
8 years ago