session-ios

Commit Graph

Author	SHA1	Message	Date
Russ Shanahan	e7126f8c60	Less confusing "#" avatar for unknown Contact instead of "+" For consistency with the Android and Desktop client behavior. * Show a placeholder avatar when no image, initials (#1512) If all we know about the user is their phone number, their avatar image is rendered as a placeholder. Previously, it would render the first few characters of their phone number as if they were initials (eg. "+") * Rename, extend OWSContactsManager methods (#1512) Rename from: nameStringForPhoneIdentifier to: displayNameForPhoneIdentifier Also, add: - (BOOL)nameExistsForPhoneIdentifier:(NSString )identifier; Which reports whether there's any "name" for a contact. Remove unused typedefs These aren't used in the project anymore, and they were causing compiling warnings due to a lack of nullability indication. * Resolve some OWSContactsManager nullability warnings Did a pass through all of the existing nullability warnings in OWSContactsManager. Tried to pick descriptors that best reflected the behavior of the methods. // FREEBIE	9 years ago
Michael Kirk	06ca3c9290	Mail and Message invite flow * Spruce up compose contact-picker - Fix random sorting for contacts missing first or last name - Add Avatar to contact picker - de-dupe contacts Better copy for INVALID_MESSAGE error. // FREEBIE	9 years ago
Michael Kirk	ee0cce75e8	Disappearing Messages * Per thread settings menu accessed by tapping on thread title This removed the toggle-phone behavior. You'll be able to see the phone number in the settings table view. This removed the "add contact" functionality, although it was already broken for ios>=9 (which is basically everybody). The group actions menu was absorbed into this screen * Added a confirm alert to leave group (fixes #938) * New Translation Strings * Extend "Add People" label to fit translations. * resolved issues with translations not fitting in group menu * Fix the long standing type warning where TSCalls were assigned to a TSMessageAdapter. * Can delete info messages Follow the JSQMVC pattern and put UIResponder-able content in the messageBubbleContainer. This gives us more functionality and allows us to delete some code. yay! It's still not yet possible to delete phone messages. =( * Fixed some compiler warnings. * xcode8 touching storyboard. So long xcode7! * Fixup multiline info messages. We were seeing info messages like "You set disappearing message timer to 10" instead of "You set disappearing message timer to 10 seconds." Admittedly this isn't a very good fix, as now one liners feel like they have too much padding. If the message is well over one line, we were wrapping properly, but there's a problem when the message is just barely two lines, the cell height grows, but the label still thinks it's just one line (as evinced by the one line appearing in the center of the label frame. The result being that the last word of the label is cropped. * Disable group actions after leaving group. // FREEBIE	9 years ago

Author

SHA1

Message

Date

Russ Shanahan

e7126f8c60

Less confusing "#" avatar for unknown Contact instead of "+"

For consistency with the Android and Desktop client behavior.

* Show a placeholder avatar when no image, initials (#1512)

  If all we know about the user is their phone number, their avatar image
  is rendered as a placeholder. Previously, it would render the first few
  characters of their phone number as if they were initials (eg. "+")

* Rename, extend OWSContactsManager methods (#1512)

  Rename from: nameStringForPhoneIdentifier
           to: displayNameForPhoneIdentifier

  Also, add:
  - (BOOL)nameExistsForPhoneIdentifier:(NSString *)identifier;

  Which reports whether there's any "name" for a contact.

* Remove unused typedefs

  These aren't used in the project anymore, and they were causing
  compiling warnings due to a lack of nullability indication.

* Resolve some OWSContactsManager nullability warnings

  Did a pass through all of the existing nullability warnings in
  OWSContactsManager. Tried to pick descriptors that best reflected the
  behavior of the methods.

// FREEBIE

Michael Kirk

06ca3c9290

Mail and Message invite flow

* Spruce up compose contact-picker
- Fix random sorting for contacts missing first or last name
- Add Avatar to contact picker
- de-dupe contacts

Better copy for INVALID_MESSAGE error.

// FREEBIE

Michael Kirk

ee0cce75e8

Disappearing Messages

* Per thread settings menu accessed by tapping on thread title

  This removed the toggle-phone behavior. You'll be able to see the phone
  number in the settings table view.

  This removed the "add contact" functionality, although it was already
  broken for ios>=9 (which is basically everybody).

  The group actions menu was absorbed into this screen

* Added a confirm alert to leave group (fixes #938)

* New Translation Strings
* Extend "Add People" label to fit translations.
* resolved issues with translations not fitting in group menu

* Fix the long standing type warning where TSCalls were assigned to a TSMessageAdapter.

* Can delete info messages

  Follow the JSQMVC pattern and put UIResponder-able content in the
  messageBubbleContainer. This gives us more functionality *and* allows us
  to delete some code. yay!

  It's still not yet possible to delete phone messages. =(

* Fixed some compiler warnings.

* xcode8 touching storyboard. So long xcode7!

* Fixup multiline info messages.

  We were seeing info messages like "You set disappearing message timer to
  10" instead of "You set disappearing message timer to 10 seconds."

  Admittedly this isn't a very good fix, as now one liners feel like they
  have too much padding.

   If the message is well over one line, we were wrapping properly, but
  there's a problem when the message is *just barely* two lines, the cell
  height grows, but the label still thinks it's just one line (as evinced
  by the one line appearing in the center of the label frame. The result
  being that the last word of the label is cropped.

* Disable group actions after leaving group.

// FREEBIE

3 Commits (8211d4584f095896e142dadc5ab19370948c1323)