Commit Graph

91 Commits (7caa29e47144e0c7d21a09b7f2025b02112c4f17)

Author SHA1 Message Date
Michael Kirk 870caaa84a simplify completion checking - make nonnull 6 years ago
Michael Kirk 13154fb828 allow long text with non-durable sends (SAE) 6 years ago
Matthew Chen 56e5feca46 Introduce ConversationSnapshot. 6 years ago
Michael Kirk f1623b6037 missing nullability text 6 years ago
Michael Kirk 7e5256856c render media+longText message 6 years ago
Michael Kirk b7989e9384 feature flag approval sending 6 years ago
Michael Kirk bc4260b444 Send long-text with other attachments 6 years ago
Michael Kirk a218d6c465 Send first chars of longtext in protobuf 6 years ago
Matthew Chen 3d757b492a Add link previews to conversation message bubbles. 6 years ago
Matthew Chen 2dcc79fbca Fix issues around link previews. 6 years ago
Matthew Chen 8e44bf554c Respond to CR. 6 years ago
Matthew Chen d775a70a89 Build link previews. 6 years ago
Matthew Chen 31ea64bdaf Build link previews. 6 years ago
Matthew Chen a477e01a4a Apply LinkPreview model. 6 years ago
Michael Kirk af7ee5e1d1 address compiler breakage after rebase 6 years ago
Michael Kirk 5671fd2520 Revert "Revert 'new sort id'."
This reverts commit ebae75af00.
6 years ago
Matthew Chen bd40aacd53 Purge dynamic interactions from database. 6 years ago
Michael Kirk 6232b1ef67 CR: add debug asserts 6 years ago
Michael Kirk 81bc357bbb more robust handling of unsaved outgoing messages 6 years ago
Michael Kirk 668cc22af3 Perf: Insert outgoing message into conversation before save completes.
This was a huge savings - e.g. 50-70% of the time between tapping send and
rendering the message takes place in the save/postWriteTransaction blocks
6 years ago
Matthew Chen 19a2bfeaad More conversation viewmodel perf improvements. 6 years ago
Matthew Chen fea40d571c Move contact offers to Conversation view model. 6 years ago
Michael Kirk c0cb7df10a rename hasEverHadMessage -> shouldThreadBeVisible 6 years ago
Michael Kirk 1a5c47df2f Fix SAE, limit max attachments 6 years ago
Matthew Chen aeadea67e2 Send multiple attachments from the share extension. 7 years ago
Matthew Chen 7f89c90f16 Fix bug when sending non-body attachments (e.g. group avatars). 7 years ago
Michael Kirk 27cb91e9c8 Plumb through messageAlbumId so an Attachment knows what album (if any) it
belongs to.
7 years ago
Matthew Chen 60c5a84dd2 Fix issues in media gallery cells; Improve debug galleries. 7 years ago
Matthew Chen c7d427029b Respond to CR. 7 years ago
Matthew Chen f6591fac25 Add debug UI for multi-image sends. 7 years ago
Matthew Chen d04f1e6e36 Add debug UI for multi-image sends. 7 years ago
Matthew Chen 40aa78e001 Merge remote-tracking branch 'origin/release/2.31.0' 7 years ago
Michael Kirk cb9aa6304c find -E . -type f -regex ".*\.(m|h)" -exec sed -i "" -e "s/try_/throws_/" {} \; 7 years ago
Michael Kirk 3a6aafc454 Swift Exception wrap NSData+keyVersionByte 7 years ago
Michael Kirk 3560f3be5c Durable send operation
TODO
-[x] respect order of queue
-[x] replacements
  -[x] those w/o completion handler
  -[x] basic send+log operation persists
  -[x] send+ui completion
  -[x] share extension
  -[x] update state jobs
-[x] App Lifecyle
  -[x] settable
  -[x] Mark as ready on startup
  -[x] Fail appropriate jobs on startup

NICE TO HAVE
-[x] concurrent per senders
-[ ] longer retry (e.g. 24hrs)
-[ ] App Lifecyle
  -[x] retry failed jobs on startup?
  -[ ] reachability

DONE
-[x] basic passing test
-[x] datamodel
-[x] queue/classes
7 years ago
Matthew Chen 0125535d4d Pull out SignalCoreKit. 7 years ago
Matthew Chen ebae75af00 Revert 'new sort id'. 7 years ago
Michael Kirk c2f87c738a trivial replace of timestampForSorting -> sortId in some logging 7 years ago
Michael Kirk 6f8eddc955 unread indicator uses sortId
- removed timestamp parameter. This wasn't totally obvious, previously we were tracking two pieces of state

1. `unreadIndicator.firstUnseenTimestamp`:
    the first unseen timestamp for a conversation that exists in the database
2. `unreadIndicator.timestamp`:
    the timestamp of the first interaction *after* the unread indicator that fits in the loading window

We don't actually need to track `2` because it was only used in a comparison like:

   viewItem.interaction.timestampForSorting >= unreadIndicator.timestamp

But by definition, unreadIndicator.firstUnseenTimestamp is always less than or
equal to unreadIndicator.timestamp. Put into terms of the `sortId` corallary,
the sortId of the first unseen interaction in the database is always less than
or equal to the sortId of the first unseen interaction that fits in the loading
window.

In other words, there's no situation where

   viewItem.interaction.sortId >= unreadIndicator.firstUnseenSortId
7 years ago
Michael Kirk ab55e85304 step 1: timestampForSorting audit, change signature
No change in functionality in this commit, I just broke the signature to have a
systematic audit of the callsites. Added TODO's with the plan for each call.
7 years ago
Michael Kirk df61316495 minimize diff senderTimestamp -> timestamp 7 years ago
Michael Kirk 00d0d1e002 Remove legacy Error backdating - no changes in functionality
Historically we would backdate the SN change messages, but since adopting
non-blocking SN changes long ago, they're already sorted properly by creation
time, so backdating has been unnecessary for a while.

I also audited that all other error messages are saved directly after creation.

I applied deprecation attributes as appropriate as I audited.
7 years ago
Michael Kirk eef1368ad3 Timestamp audit step1: change signature
There is no change in functionality in this commit.

Apart from clarifying what the timestamp means (it's the timestamp of the
*sender*), this intentionally breaks all the call sites, so I could have a sane
way to thoroughly audit wherever we're passing in timestamps, to see where
we're depending on them to affect sort order.

For the sake of a cleaner diff of meaningful changes, instead of "fixing"
everything in this commit, I've just added comments and renamed signatures.
7 years ago
Michael Kirk 6c5fbc6de5 Update existing contact offers in place
WIP: migration / autoincrement logic

TODO:

-[x] contact offer
-[ ] verify all paths that utilized timestampForSorting, e.g. make sure SN appear before the message they affect, etc.
-[x] Monotonic ID
-[x] New extension which sorts by id
-[x] Migration
  -[ ] batch migration?

fixup contact offers
7 years ago
Michael Kirk a60d8eb161 WIP: migration / autoincrement logic
TODO:

-[ ] contact offer
-[ ] verify all paths that utilized timestampForSorting, e.g. make sure SN appear before the message they affect, etc.
-[x] Monotonic ID
-[x] New extension which sorts by id
-[x] Migration
  -[ ] batch migration?
7 years ago
Michael Kirk 920a82564f Merge tag '2.29.3.3' 7 years ago
Michael Kirk df67e883f3 BlockList vs. "zero length" group names 7 years ago
Michael Kirk c1b88b5f48 copy cleanup: remove redundant body 7 years ago
Michael Kirk b6eb1476cb Leave group when blocking it 7 years ago
Michael Kirk eadb04efcc WIP: ContactViewHelper incorporates group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] ConversationViewHelper
   -[x] Track blocked groups
   -[ ] HomeView
   -[ ] ConversationView
   -[ ] Any others?
   -[ ] Rename? Extract BlockList cache?
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[x] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
7 years ago