Commit Graph

320 Commits (7c1f1882d8c82a7ac7c0d1cf88fdd14062ff85e0)

Author SHA1 Message Date
Matthew Chen 7c1f1882d8 Sync "show UD indicators" setting. 7 years ago
Matthew Chen 603e3bf0b6 Move SM singletons to Environment. 7 years ago
Matthew Chen f1d93d4472 Merge remote-tracking branch 'origin/release/2.30.2' 7 years ago
Michael Kirk d5f69e4bba feature flag for group avatar color 7 years ago
Michael Kirk 1544f8db46 Optionally show UD status in message details 7 years ago
Matthew Chen 17541a8888 Change conversation bubble colors. 7 years ago
Michael Kirk 2b805e4eae Constantize ConversationColorName, map previous incorrect values 7 years ago
Michael Kirk d59e21e7f0 Nothing outside of TSThread should know about legacy colors 7 years ago
Michael Kirk 405cc31a38 Apply new colors to new conversation 7 years ago
Matthew Chen 95387dd220 Fix rebase breakage. 7 years ago
Matthew Chen 24d7a97616 Fix rebase breakage. 7 years ago
Matthew Chen 0125535d4d Pull out SignalCoreKit. 7 years ago
Matthew Chen ebae75af00 Revert 'new sort id'. 7 years ago
Michael Kirk 79add78d51 Merge branch 'release/2.30.1' 7 years ago
Matthew Chen 5a99cd347f Pull out OWSConversationColor to its own file. 7 years ago
Matthew Chen 43dc362fc7 Fix secondary color within message bubbles. 7 years ago
Matthew Chen 0e5f42defe Use new asset for default contact avatars. 7 years ago
Matthew Chen ec0206ff01 Adapt text size of default avatars to avatar size. 7 years ago
Matthew Chen 6d14a1b472 Local profile default avatars should use steel background. 7 years ago
Matthew Chen 27488f078a Replace old "default profile avatar" icon with default avatar for local user. 7 years ago
Matthew Chen e4ab360716 Respond to CR. 7 years ago
Matthew Chen ff6feafe8c Update text colors. 7 years ago
Matthew Chen 6715e3d1ad Respond to CR. 7 years ago
Matthew Chen b20cd57383 Rename OWSConversationColor. 7 years ago
Matthew Chen 3adc03fa2c Rework conversation message bubble colors; add "conversation colors" class. 7 years ago
Matthew Chen b3ad6e27dc Rework conversation message bubble colors; add "conversation colors" class. 7 years ago
Matthew Chen 26a2d568de Add "conversation color mode" enum. 7 years ago
Matthew Chen e5150267c2 Rework the conversation color constants. 7 years ago
Matthew Chen da63731447 Respond to CR. 7 years ago
Matthew Chen 8db4595bdc Rework group avatars to reflect conversation colors. 7 years ago
Matthew Chen 1c920c6be6 Rework group avatars to reflect conversation colors. 7 years ago
Matthew Chen 25d56b30c1 Rework group avatars to reflect conversation colors. 7 years ago
Matthew Chen 2f9eae5caf Respond to CR. 7 years ago
Michael Kirk fe7d69e9c6 Update thread's sorting order based on whatever the currently last message is 7 years ago
Michael Kirk c2f87c738a trivial replace of timestampForSorting -> sortId in some logging 7 years ago
Michael Kirk 6f8eddc955 unread indicator uses sortId
- removed timestamp parameter. This wasn't totally obvious, previously we were tracking two pieces of state

1. `unreadIndicator.firstUnseenTimestamp`:
    the first unseen timestamp for a conversation that exists in the database
2. `unreadIndicator.timestamp`:
    the timestamp of the first interaction *after* the unread indicator that fits in the loading window

We don't actually need to track `2` because it was only used in a comparison like:

   viewItem.interaction.timestampForSorting >= unreadIndicator.timestamp

But by definition, unreadIndicator.firstUnseenTimestamp is always less than or
equal to unreadIndicator.timestamp. Put into terms of the `sortId` corallary,
the sortId of the first unseen interaction in the database is always less than
or equal to the sortId of the first unseen interaction that fits in the loading
window.

In other words, there's no situation where

   viewItem.interaction.sortId >= unreadIndicator.firstUnseenSortId
7 years ago
Michael Kirk 2eb3ec6d0c benchmark migration 7 years ago
Michael Kirk c27d35f8f2 sort search results by sortId 7 years ago
Michael Kirk ab55e85304 step 1: timestampForSorting audit, change signature
No change in functionality in this commit, I just broke the signature to have a
systematic audit of the callsites. Added TODO's with the plan for each call.
7 years ago
Michael Kirk df61316495 minimize diff senderTimestamp -> timestamp 7 years ago
Michael Kirk 00d0d1e002 Remove legacy Error backdating - no changes in functionality
Historically we would backdate the SN change messages, but since adopting
non-blocking SN changes long ago, they're already sorted properly by creation
time, so backdating has been unnecessary for a while.

I also audited that all other error messages are saved directly after creation.

I applied deprecation attributes as appropriate as I audited.
7 years ago
Michael Kirk eef1368ad3 Timestamp audit step1: change signature
There is no change in functionality in this commit.

Apart from clarifying what the timestamp means (it's the timestamp of the
*sender*), this intentionally breaks all the call sites, so I could have a sane
way to thoroughly audit wherever we're passing in timestamps, to see where
we're depending on them to affect sort order.

For the sake of a cleaner diff of meaningful changes, instead of "fixing"
everything in this commit, I've just added comments and renamed signatures.
7 years ago
Michael Kirk 6c5fbc6de5 Update existing contact offers in place
WIP: migration / autoincrement logic

TODO:

-[x] contact offer
-[ ] verify all paths that utilized timestampForSorting, e.g. make sure SN appear before the message they affect, etc.
-[x] Monotonic ID
-[x] New extension which sorts by id
-[x] Migration
  -[ ] batch migration?

fixup contact offers
7 years ago
Michael Kirk a60d8eb161 WIP: migration / autoincrement logic
TODO:

-[ ] contact offer
-[ ] verify all paths that utilized timestampForSorting, e.g. make sure SN appear before the message they affect, etc.
-[x] Monotonic ID
-[x] New extension which sorts by id
-[x] Migration
  -[ ] batch migration?
7 years ago
Matthew Chen 7b2dd19fb8 Respond to CR. 7 years ago
Matthew Chen ae84528dc3 Update avatar colors; add shaded conversation color constants, modify color picker to be color-name-based, not color-based, use shaded conversation colors, remove JSQ. 7 years ago
Matthew Chen 8cf5f3e58f New grayscale palette. 7 years ago
Michael Kirk 21e67e9a1d New resolutions for call banner, rename to accommodate multiple X devices.
Only apply work-around to legacy versions where required.
7 years ago
Michael Kirk 920a82564f Merge tag '2.29.3.3' 7 years ago
Michael Kirk df67e883f3 BlockList vs. "zero length" group names 7 years ago