Commit Graph

5878 Commits (72428350c218728bad948afc828b2ebfda080ab3)
 

Author SHA1 Message Date
Matthew Chen 31d22e3e35 "Bump build to 2.20.0.35." 7 years ago
Matthew Chen ba31059e43 Merge branch 'mkirk/fix-share-with-caption' 7 years ago
Michael Kirk e43d0b1b5a Fix "Share" for attachment with caption
// FREEBIE
7 years ago
Matthew Chen 88d8eacc6e "Bump build to 2.20.0.34." 7 years ago
Michael Kirk e27ab36205 Merge branch 'mkirk/remove-share-menu' 7 years ago
Michael Kirk 5ba5d3f524 Remove "Share" from edit menu
Showing the share UI conflicts with the conversation views
inputAccessory toolbar.

Specifically:

- the long press menu acquires first responder
- tapping share presents the activity view
- at this point, the input toolbar is hidden
- launching a share extension hides the activity view, presents the
  share extension (could be the Signal share extension or another app's
  share extension)
- the conversation view (which is rendered behind the share extension)
  regains first responder, causing the input toolbar to appear above the
  share extension

One fix would be to re-implement an interface similar UIMenuController,
which does not require mucking with the responder chain, but that's
going to be more involved.

// FREEBIE
7 years ago
Michael Kirk 9428b5d02b Merge branch 'mkirk/obscure-alert' 7 years ago
Michael Kirk d7f8c3e9d3 Ensure inputAccessory doesn't obscure the SN alert
This affects iOS 8, 9, and to a lesser degree iOS10.
On iOS11, presenting an alert causes the keyboard/inputAccessoryView to
temporarily dismiss.

// FREEBIE
7 years ago
Michael Kirk c0d1126394 Merge branch 'mkirk/fix-date-formatting-crash' 7 years ago
Michael Kirk 7040437ca6 Handle nil date when formatting
// FREEBIE
7 years ago
Matthew Chen 2575d01b96 "Bump build to 2.20.0.33." 7 years ago
Matthew Chen 26fbe28c42 Merge branch 'charlesmchen/legacyPasswordOnSuccess' 7 years ago
Matthew Chen a4855acf44 Don't clear legacy db password until conversion completes. 7 years ago
Matthew Chen 85e504745c Merge branch 'charlesmchen/filterUnicodeOrderingCharacters' 7 years ago
Matthew Chen 1109158b5b Add comment. 7 years ago
Matthew Chen 70ba1720d9 Filter unicode ordering letters. 7 years ago
Matthew Chen 6ddd9d788e Merge branch 'charlesmchen/backgroundTaskVsDBTransactions' 7 years ago
Matthew Chen 3bb802189c Use background tasks during db transactions. 7 years ago
Matthew Chen 2e1dad740c Merge branch 'charlesmchen/robustMigration2' 7 years ago
Matthew Chen 706006539f Improve the robustness of the migration logic. 7 years ago
Matthew Chen cf507487c1 "Bump build to 2.20.0.32." 7 years ago
Matthew Chen 4cfb71dc65 Merge branch 'charlesmchen/robustMigration' 7 years ago
Matthew Chen d91507d897 Improve the robustness of the migration logic. 7 years ago
Matthew Chen e8cbba61f9 "Bump build to 2.20.0.31." 7 years ago
Matthew Chen 9295a56309 Elaborate logging around storage migration. 7 years ago
Matthew Chen 1fb170715b Merge branch 'charlesmchen/heicHeifFixes' 7 years ago
Matthew Chen 7132179c5c Fix handling of HEIF/HEIC when attaching image "as document." 7 years ago
Matthew Chen 11680958de "Bump build to 2.20.0.30." 7 years ago
Matthew Chen b1c4dd7b55 Merge branch 'charlesmchen/storageFailureAlert' 7 years ago
Matthew Chen 14122dab54 Fix the storage failure alert. 7 years ago
Matthew Chen 5d949368a6 "Bump build to 2.20.0.29." 7 years ago
Matthew Chen e829541932 Merge branch 'charlesmchen/callConnectionGlitches' 7 years ago
Matthew Chen 1a0f4bf928 Improve logging around network activity. 7 years ago
Michael Kirk ef7d5df09a "Bump build to 2.20.0.28." 7 years ago
Michael Kirk fbbf432a48 Merge branch 'mkirk/file-browser' 7 years ago
Michael Kirk 033505afd7 Remove slow file protection updates from launch path
To avoid blocking launch, file protection is now updated async for most
moved files. Out of paranoia, the database files are also update
redundantly on a sync code path.

It's still critical that we update permissions recursively for two
reasons:

1. Updating a containing directories FileProtection does not affect
   existing files in that directory.

2. Because we've changed the containers default file protection level
   (from unspecified to NSFileProtectionComplete), some existing files
   will have there file protection updated upon launching Signal 2.20.
   It's not clear to me which files this affects, and I haven't found
   any relevant documentation, but from observation, it seems to affect
   any top-level files in the container. Regardless, we're now doing the
   right thing: after launching 2.20, ensure all file permissions are
   what we expect.

Also removed no-op file protection on legacy db files. They've already
been moved by the time this method runs in AppSetup.

// FREEBIE
7 years ago
Michael Kirk 6eb1ce682a Debug file browser
// FREEBIE
7 years ago
Michael Kirk e6cad5dd28 Merge branch 'mkirk/call-audio-fixups' 7 years ago
Michael Kirk 8dfe06e3f2 Ensure audio session is default after call is terminated.
Previously, we were enabling PlayAndRecord when a call ended due to the
CallService observer's "updateVideoTrack" callbacks.

// FREEBIE
7 years ago
Michael Kirk 6eb1951ee6 Don't stop audio until after CallKit audio session is deactivated
// FREEBIE
7 years ago
Matthew Chen 9b73ff14ba "Bump build to 2.20.0.27." 7 years ago
Matthew Chen ef40f08212 "Bump build to 2.20.0.26." 7 years ago
Michael Kirk 8fde4a3a6f Merge branch 'mkirk/call-inaudible' 7 years ago
Michael Kirk 707ab5f5a8 Minimize changes around call audio activity
// FREEBIE
7 years ago
Michael Kirk 4dd1c7813a Instrument calls to ensure audio session is maintained
// FREEBIE
7 years ago
Michael Kirk abb51b565a Don't de-activate audio sesion when other audio activities are happening
// FREEBIE
7 years ago
Matthew Chen 22d078f3c8 Merge branch 'charlesmchen/indicVsSAE' 7 years ago
Matthew Chen 283fe17649 Apply Indic script fixes to SAE and master. 7 years ago
Matthew Chen 9341935700 Merge branch 'charlesmchen/notMigratedWarning' 7 years ago
Matthew Chen c937aaaf84 Improve handling of the not migrated case. 7 years ago