Commit Graph

2003 Commits (6ec756de444206cd8942fd06a357c0416498b1d2)

Author SHA1 Message Date
Michael Kirk b82aedc3a0 Assertion failures for unexpected promise state
These don't currently result in failed calls, but we should at least
know about it in debug.

// FREEBIE
8 years ago
Michael Kirk 438635393b Don't send ICE updates until after the CallOffer has been sent.
This ensures message ordering for clients that can't handle out of order
call messages (legacy iOS and Android).

Even when we revert the previous commit, to send ICE Updates sooner,
we'll want to keep this (until we're confident all clients can receive
out of order call messages)

// FREEBIE
8 years ago
Michael Kirk d910da0157 Partial revert of: Send ICE updates immediately - 2dcfb4e3b8
That change makes it more likely that the remote client will receive an
ICE update before their peer connection client is set.

We want to ship the robustness fix (waitForPeerConnection in
handleRemoteAddedIceCandidate) before we have the caller start sending
ICE updates immediately, in a future release.

At that time, we can simply revert this commit.

// FREEBIE
8 years ago
Michael Kirk 2067697ed4 Add comment and clearer tests per CR
// FREEBIE
8 years ago
Michael Kirk 4f1ee98489 scrub any data that slips through to logs
Similar to phone number scrubbing, we leave a short prefix of the data
to help with debugging without leaking much data.

// FREEBIE
8 years ago
Matthew Chen b7c2512eac Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 81555d1225 Add “new contact” and “add to existing contact” buttons in 1:1 conversation settings view.
// FREEBIE
8 years ago
Matthew Chen 1e67bb52e3 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 2202fe70fe Fix broken tests.
// FREEBIE
8 years ago
Matthew Chen f584c4b434 Fix broken tests.
// FREEBIE
8 years ago
Matthew Chen 0b28285deb Fix broken tests.
// FREEBIE
8 years ago
Matthew Chen 69ba2811db Run orphan cleanup on startup.
// FREEBIE
8 years ago
Michael Kirk d15da6e6d4 fix bubble calculator tests
// FREEBIE
8 years ago
Michael Kirk 82180f6a97 fix compilation problems
// FREEBIE
8 years ago
Matthew Chen c9355630c7 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen d639d6557e Add owsFail free function for swift.
// FREEBIE
8 years ago
Matthew Chen 669e0644ea Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 5cf0441f55 Add a reminder that you are in archive view.
// FREEBIE
8 years ago
Matthew Chen 54a5b960c7 Add a reminder that you are in archive view.
// FREEBIE
8 years ago
Matthew Chen 8f3b837a65 Add a reminder that you are in archive view.
// FREEBIE
8 years ago
Matthew Chen 2e727a24b5 Convert home view to programmatic layout.
// FREEBIE
8 years ago
Michael Kirk 5223104566 respect system sort order for contacts
// FREEBIE
8 years ago
Matthew Chen b19dd648d2 Bump build number to v2.14.0.0.
// FREEBIE
8 years ago
Michael Kirk 2dcfb4e3b8 Send ICE updates immediately.
Now that SN changes do not block incoming messages, the caller does not
need to enqueue outgoing ICE updates.

However this introduces the possibility that the call recipient could
recieve an ICE update before their peerConnectionClient is set up - so
now we ensure that call service waits for it's peerConnectionClient
before processing incoming ICE updates.

// FREEBIE
8 years ago
Matthew Chen 1a400f8414 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen b6531a8b5d If two users call each other at the same time, ensure they both see “busy”.
// FREEBIE
8 years ago
Michael Kirk f681712ea0 Code Cleanup
- make some logging clearer
- remove noisy unhelpful logging
- clearer method names

// FREEBIE
8 years ago
Michael Kirk e584f4d1e1 copy tweaks
// FREEBIE
8 years ago
markus.fassbender 422336db32 fixes compiler warnings FREEBIE 8 years ago
Matthew Chen c817346ee3 Fix “timer circular reference” leaks.
// FREEBIE
8 years ago
Michael Kirk d8330a2c4f Fix bluetooth audio for calls
Allow bluetooth in all call speaking modes. This was much simpler to fix
now that all call AudioSession mgmt happens in one method.

// FREEBIE
8 years ago
Matthew Chen e3f2583b4a Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 9cbc1e6a1b Block device from sleeping while Debug UI is visible and during database upgrades.
// FREEBIE
8 years ago
Matthew Chen 0244e134f5 Block device from sleeping during certain activities.
// FREEBIE
8 years ago
Matthew Chen bfd04088bd Persist registration view’s “last registered” values in keychain so that they persist across clean installs.
// FREEBIE
8 years ago
Michael Kirk 1afc6525e5 selecting network status does not highlight
// FREEBIE
8 years ago
Matthew Chen 9aa54cad63 Fix missing “database upgrade” label on launch screen.
// FREEBIE
8 years ago
Matthew Chen ab9770c175 Fix missing “database upgrade” label on launch screen.
// FREEBIE
8 years ago
Matthew Chen 5038744811 Fix missing “database upgrade” label on launch screen.
// FREEBIE
8 years ago
Matthew Chen d94ee7ab11 Add options to send 3k debug messages.
// FREEBIE
8 years ago
Matthew Chen ac48b13882 Bump version number to 2.13.4.0.
// FREEBIE
8 years ago
Matthew Chen 9e5447f1d4 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen b400c0a327 Don’t show app upgrade nag unless we are at rest in home view or registration view.
// FREEBIE
8 years ago
Matthew Chen 944cd7beef Show app update nag on launch if necessary.
// FREEBIE
8 years ago
Michael Kirk 8e891eb357 Merge branch 'hotfix/2.13.3.0'
// FREEBIE
8 years ago
Matthew Chen c5bf85d0b3 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen ab3aa9d0ce Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 97169f521a Move more initialization until after didBecomeActive is complete to avoid the “bad food” crash.
// FREEBIE
8 years ago
Matthew Chen 73869b1eff Fix possible cause of crash on launch.
// FREEBIE
8 years ago
Matthew Chen 7135895c1c Modify TSStorageManager to use separate shared read and write connections.
// FREEBIE
8 years ago
Michael Kirk 906b307e1f remove unneccessary hack
Now that we have a nice system message design, we don't need to shoe
horn group updates into the TSCall adapter.

// FREEBIE
8 years ago
Matthew Chen dcf3de2ae2 Bump version to 2.13.3.0.
// FREEBIE
8 years ago
Michael Kirk 174706817c clearer comment
I erroneously thought this code was an error, maybe a better comment
would have saved me some time?

// FREEBIE
8 years ago
Michael Kirk 12d8ecfdfc Copy tweak: "Incomplete" -> "Unanswered" outgoing call
// FREEBIE
8 years ago
Michael Kirk 1f9f066fa9 print call record when declining a call
// FREEBIE
8 years ago
Michael Kirk 1e0cf89f7a Explanatory comment
// FREEBIE
8 years ago
Michael Kirk 43a3a4afaf play *after* stop
In theory this shouldn't make a difference, since we're not playing the
ringer twice, but in practice I fail to here ringer audio 50% of the
time (in DEBUG builds) while app is in the foreground.

// FREEBIE
8 years ago
Michael Kirk 8abde1dff8 Non-Callkit adapter plays audio from notification when app is in
background

// FREEBIE
8 years ago
Michael Kirk ff10f52779 remove unneccessary hack
Now that we have a nice system message design, we don't need to shoe
horn group updates into the TSCall adapter.

// FREEBIE
8 years ago
Michael Kirk c1881c02c8 constantize file name per CR
// FREEBIE
8 years ago
Michael Kirk 9b1695f28c Play audible alert for missed call
// FREEBIE
8 years ago
Michael Kirk 89260e843f Unregistered users should have 0 badge count
// FREEBIE
8 years ago
Michael Kirk 6335782568 Make sure we're requesting access for contacts before checking access
I'm actually not sure how I got my simulator wedged into this state -
but my contacts access was "undetermined" and I had several messages.

Maybe they appeared while the app was closed?

I verified that the banner appears as expected when access is denied.

// FREEBIE
8 years ago
Matthew Chen 1552c64777 Add “delete old messages” and “save all attachments” debug commands.
// FREEBIE
8 years ago
Matthew Chen 72faa5f82d Add clean up command to the “orphan audit” debug UI.
// FREEBIE
8 years ago
Matthew Chen feb32fdf8e Find orphan and missing attachment stream files.
// FREEBIE
8 years ago
Matthew Chen 284d55ef6c Rework the debug UI.
* Move debug stats to the about view.
* Convert about view to OWSTableView.
* Add DebugUIPage.
* Add non-thread Debug UI.

// FREEBIE
8 years ago
Matthew Chen 07c8eb54b7 Prevent "scroll to button" button from blipping.
// FREEBIE
8 years ago
Matthew Chen 2d8ad30efa Bump version to 2.13.2.0.
// FREEBIE
8 years ago
Matthew Chen 3e87d41715 Update l10n strings.
// FREEBIE
8 years ago
Michael Kirk c6cd0bbcae Always show timestamp after unread indicator
// FREEBIE
8 years ago
Michael Kirk bef3a56e50 DebugUI: create fake unread messages
helpful for printing unread indicator

// FREEBIE
8 years ago
Michael Kirk 964e558139 log when starting token sync in prod
// FREEBIE
8 years ago
Michael Kirk 6719008ed9 bump version
// FREEBIE
8 years ago
Michael Kirk d0d4e67615 update badge count when app is in background
// FREEBIE
8 years ago
Matthew Chen 226b7354de Bump build from to 2.13.0.16.
// FREEBIE
8 years ago
Matthew Chen 132348c440 Update l10n strings.
// FREEBIE
8 years ago
Matthew Chen 1e8c24cba3 Bump build from to 2.13.0.15.
// FREEBIE
8 years ago
Matthew Chen e48d51d084 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen a462cba452 Don’t reply to “no longer verified”.
// FREEBIE
8 years ago
Matthew Chen db3407853a Refine fake contact creation.
// FREEBIE
8 years ago
Matthew Chen 791c5bb89e Revise phone number length limit in registration view.
// FREEBIE
8 years ago
Matthew Chen 351c8c00f0 Remove phone number length limit in registration view.
// FREEBIE
8 years ago
Matthew Chen 4133673d70 Bump build number to 2.13.0.14.
// FREEBIE
8 years ago
Matthew Chen 67d60ff01b Bump build number to 2.13.0.13.
// FREEBIE
8 years ago
Matthew Chen ff89cbabcc Bump build number to 2.13.0.12.
// FREEBIE
8 years ago
Matthew Chen 84d8fb0853 Update l10n strings.
// FREEBIE
8 years ago
Michael Kirk a933fbf215 sync verifications with contact syncing
// FREEBIE
8 years ago
Michael Kirk 37b7bf18e9 clarify code and clean up code formatting
I think we hit some pathological cases in clang format, but this is
clearer anyway IMO

// FREEBIE
8 years ago
Matthew Chen e814ae129d Fix crash in manual censorship circumvention logic on iOS 9.
// FREEBIE
8 years ago
Matthew Chen f7c81bae9d Show the “scroll down” button if user scrolls up, even if there are no unread messages.
// FREEBIE
8 years ago
Matthew Chen eff1974eeb [SSK] Reduce chattiness of logs; increase log file sizes.
// FREEBIE
8 years ago
Matthew Chen 15ecb03471 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 7726c68047 Persist registration values in the keychain for debug builds only.
// FREEBIE
8 years ago
Matthew Chen 06baf5128f Bump build number to 2.13.0.11.
// FREEBIE
8 years ago
Matthew Chen 3d0811c03f Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 029da7e0ce Hang up current call if we receive a call offer from the same user.
// FREEBIE
8 years ago
Matthew Chen 9fc92990f5 Improve logging in CallService.
// FREEBIE
8 years ago
Matthew Chen 0855faabb4 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen efbda70764 Improve UX for multiple “no longer verified” members of a group.
// FREEBIE
8 years ago
Matthew Chen afb83cfaaa Improve UX for multiple “no longer verified” members of a group.
// FREEBIE
8 years ago
Matthew Chen f1e5be4c17 Improve UX for multiple “no longer verified” members of a group.
// FREEBIE
8 years ago
Matthew Chen a039aac36d Improve UX for multiple “no longer verified” members of a group.
// FREEBIE
8 years ago
Matthew Chen f3f832557f Respond to CR.
// FREEBIE
8 years ago
Matthew Chen ec077235ba Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 6a5fe94d59 Improve perf of attachment stream file path upgrade.
// FREEBIE
8 years ago
Matthew Chen b39c4905c3 Invalid message adapter cache when app becomes visible.
// FREEBIE
8 years ago
Matthew Chen 4f0b5838ec Bump build number to 2.13.0.10.
// FREEBIE
8 years ago
Matthew Chen 0738568b94 Fix upgrade launch screen.
// FREEBIE
8 years ago
Michael Kirk 11fa08470d [JSQ] Fix: can't dismiss keyboard after sending
// FREEBIE
8 years ago
Michael Kirk 8898f4a6d4 CR: future proof view placement if we change hierarchy
// FREEBIE
8 years ago
Michael Kirk da7dae8163 CR: rename longpress->longPress
// FREEBIE
8 years ago
Michael Kirk c70b1e9681 Make system messages deletable
// FREEBIE
8 years ago
Michael Kirk fbba2f5dd7 colocate CollectionViewDelegate methods
// FREEBIE
8 years ago
Michael Kirk 39563ab8c2 present from signalsViewController so users don't get confused by being
dropped into a different thread when the call is over.

e.g. chatting with Alice, but Bob calls. When I end the call with Bob It
would be too easy to fire off a message assuming it's going to Bob.

// FREEBIE
8 years ago
Michael Kirk 982433c2bf update call screen avatar when contacts change
in particular this is a problem when initiating a call from a cold app
state. The call screen renders before the contacts have completely
loaded.

// FREEBIE
8 years ago
Michael Kirk 36c09aeb84 cleanup ahead of PR
// FREEBIE
8 years ago
Michael Kirk ff93732ed7 WIP: fix call from contacts when signal hasn't been launched yet 8 years ago
Matthew Chen 59d3e9ed51 Bump build number to 2.13.0.9.
// FREEBIE
8 years ago
Matthew Chen 5ae4b99f89 Refine observation of async registration completion.
// FREEBIE
8 years ago
Matthew Chen de453b2960 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 5796bbd858 Max out the unread count at 99.
// FREEBIE
8 years ago
Michael Kirk bee4b118e6 remove unneccessary explanation of UI
// FREEBIE
8 years ago
Michael Kirk 0419d35f12 CR: rename method
not always resized when used

// FREEBIE
8 years ago
Michael Kirk 8fc2289152 prefer becomeFirstResponder
Feels a little more reasonable than interecepting canBecomeFirstResponder

// FREEBIE
8 years ago
Michael Kirk b4d3e8e744 Fix: tapping input obscures last messages
// FREEBIE
8 years ago
Matthew Chen d603e587f6 Bump build number to 2.13.0.8.
// FREEBIE
8 years ago
Matthew Chen 988ec86fbc Bump build number to 2.13.0.7.
// FREEBIE
8 years ago
Matthew Chen d01a52758b Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 0d07e0222f Avoid stale mapping in conversation view.
// FREEBIE
8 years ago
Matthew Chen 331a1e90e3 Avoid stale mapping in conversation view.
// FREEBIE
8 years ago
Matthew Chen f6f08891eb Avoid stale mapping in conversation view.
// FREEBIE
8 years ago
Matthew Chen d4a6a35ee3 Avoid stale mapping in conversation view.
// FREEBIE
8 years ago
Matthew Chen 9f2a2d1ee6 Don’t show “export with Signal” UI until async database view registration is complete.
// FREEBIE
8 years ago
Matthew Chen 66a71d7241 Bump build number to 2.13.0.6.
// FREEBIE
8 years ago
Matthew Chen 301e925cc8 Update l10n strings.
// FREEBIE
8 years ago
Michael Kirk b404fa3c2b Save identity from profile fetch even if there's no pre-existing
identity.

This allows us to view someone's SN before messaging them.

// FREEBIE
8 years ago
Matthew Chen fa58977683 Prevent layout from jumping around in fingerprint view.
// FREEBIE
8 years ago
Michael Kirk 4f3278db1e Fix layout of timestamp for system messages
Incorporate topLabelSize into cell size for system messages.

We are using the term "bubble size" to describe the interaction specific
views of a collection cell. It's a crappy name, but coincides with other
usage.

// FREEBIE
8 years ago
Michael Kirk 1125e2ac99 System messsages can show timestamp
added the JSQCollectionViewCell cellTopLabel to the system message
layout

// FREEBIE
8 years ago
Matthew Chen c952036075 Bump build to 2.13.0.5.
// FREEBIE
8 years ago
Matthew Chen 104a548eb2 Ensure message mapping is up-to-date when app returns from background.
// FREEBIE
8 years ago
Matthew Chen dc134a991a Tweak font size on fingerprint view.
// FREEBIE
8 years ago
Matthew Chen 57c1519b1c Tweak font size on registration view.
// FREEBIE
8 years ago
Matthew Chen e14b9b511d Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 8649b26033 Don’t auto-scroll after “loading more messages” unless we have “more unseen messages”.
// FREEBIE
8 years ago
Matthew Chen 4d0b15f58c Show long-form app version in about view.
// FREEBIE
8 years ago
Matthew Chen 119f1f3429 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 6276dcb34c Fix “Invalid media attachments” crash.
// FREEBIE
8 years ago
Matthew Chen ab95b04e56 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 3c59678b7d Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 90c4ba27bf Respond to post-holiday code reviews.
// FREEBIE
8 years ago
Matthew Chen bd440f0878 Respond to post-holiday code reviews.
// FREEBIE
8 years ago
Michael Kirk 1661e8dc34 assume contact in 1:1 thread
// FREEBIE
8 years ago
Michael Kirk a41b10a695 ignore tap on legacy non-blocking SN change message
// FREEBIE
8 years ago
Matthew Chen 3c28f15dbd Respond to CR.
// FREEBIE
8 years ago
Matthew Chen d340c3262d Tweak the database upgrade copy.
// FREEBIE
8 years ago
Matthew Chen 3e38967590 Do not show database upgrade screen for unregistered users.
// FREEBIE
8 years ago
Matthew Chen f9fcbad1aa Add a “last app completed launch” version.
// FREEBIE
8 years ago
Matthew Chen cf3101226b Improve the upgrade screen.
// FREEBIE
8 years ago
Matthew Chen 75ccff0e4f Improve debug tools for creating “fake” and “tiny attachment” messages.
// FREEBIE
8 years ago
Michael Kirk 60e87bb16f clearer copy for SN changes
// FREEBIE
8 years ago
Matthew Chen 631a2bbb12 Bump build number.
// FREEBIE
8 years ago
Matthew Chen 35d68c6180 Fix "writes on long-lived read connection" issue.
// FREEBIE
8 years ago
Matthew Chen da55f45af7 Bump build number.
// FREEBIE
8 years ago
Matthew Chen 16dd87a407 Use launch screen as root view controller while database views are loading.
// FREEBIE
8 years ago
Matthew Chen 12df7fae83 Update l10n strings.
// FREEBIE
8 years ago
Matthew Chen 7805119c03 Bump build number.
// FREEBIE
8 years ago
Matthew Chen 3bc73bea25 Don't return busy signal to untrusted callers.
// FREEBIE
8 years ago
Matthew Chen f71f33c2a6 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen c7426f9343 Avoid crashing on startup due to database view creation.
* Substitute unread view for unseen view until unseen view is ready.
* Register as many views as possible async.
* Perform blocking, safe migrations before async registration of views.
* Add debug settings view for internal app stats.
* Show blocking overlay until async registration of database views is complete.
* Convert version migrations to use AppVersions.

// FREEBIE
8 years ago
Matthew Chen b18e7cde34 Don’t show offers in conversation with self.
// FREEBIE
8 years ago
Matthew Chen 9fa1b295a4 Bump build number.
// FREEBIE
8 years ago
Matthew Chen 05e316381b Remove “block on safety number changes” setting in preferences.
// FREEBIE
8 years ago
Matthew Chen d0791bf510 Add debug UI to create fake messages.
// FREEBIE
8 years ago
Matthew Chen 575d631123 Reduce number of database views.
// FREEBIE.
8 years ago
Matthew Chen 6f1f1fac80 Improve handling of group creation failures.
// FREEBIE
8 years ago
Matthew Chen bdfa435738 Allow notification sound check from any thread.
// FREEBIE
8 years ago
Matthew Chen f5f506d06f Investigate “call stuck on connecting” issue.
// FREEBIE
8 years ago
Matthew Chen 55b86eba28 Use reference cells for measurement.
// FREEBIE
8 years ago
Matthew Chen 83b03c0047 Use reference cells for measurement.
// FREEBIE
8 years ago
Matthew Chen 91af4f93e1 Use reference cells for measurement.
// FREEBIE
8 years ago
Matthew Chen 389305e2b9 Fix build warnings.
// FREEBIE
8 years ago
Matthew Chen 5e993e72c1 Throttle notification sounds.
// FREEBIE
8 years ago
Matthew Chen a73c6ede60 Tweak verification UI.
* Add “tap for options” to verification banner copy.
* Add close button to banners.
* Always use shield icon for verification row in conversation settings view.
* Add action sheet to verification banner.

// FREEBIE
8 years ago
Matthew Chen 935244843e Tweak verification UI.
* Add “tap for options” to verification banner copy.
* Add close button to banners.
* Always use shield icon for verification row in conversation settings view.
* Add action sheet to verification banner.

// FREEBIE
8 years ago
Matthew Chen e9ed91fb07 Update l10n strings.
// FREEBIE
8 years ago
Matthew Chen c18a670d6b Don’t update expiration for messages twice.
// FREEBIE
8 years ago
Matthew Chen 027cd8cb34 Rework how messages are marked read.
// FREEBIE
8 years ago
Matthew Chen 65d84fd043 Throttle profile fetch and retry on failure.
// FREEBIE
8 years ago
Matthew Chen f8f4e5ee6f Throttle profile fetch and retry on failure.
// FREEBIE
8 years ago
Matthew Chen 1d27fc62d6 Bump version and build number to v2.13.0.0.
// FREEBIE
8 years ago
Matthew Chen b68b188379 Use shield instead of checkmark in conversation settings view when users is not verified.
// FREEBIE
8 years ago
Matthew Chen 7d7b6689c4 Tweak verification state messages.
// FREEBIE
8 years ago
Matthew Chen 7da28bd5dc Multiple refinements around verification.
* Check for identity key before presenting fingerprint view.
* Show verification state in a separate subtitle in conversation view.
* Let users verify from group members view.

// FREEBIE
8 years ago
Matthew Chen 11ca51c95f Show verification state banner. Show verification state in conversation settings view.
// FREEBIE
8 years ago
Matthew Chen 471e307ecc Use checkmark to indicate verification status in conversation view header subtitle, fingerprint view, and in conversation settings row icon.
// FREEBIE
8 years ago
Matthew Chen a7269a9a5d Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen 128e147c1b Show verification state in fingerprint view and let user change that state.
// FREEBIE
8 years ago
Matthew Chen 10f3f7fe13 Add “learn link”. Move “scan” button into QR code.
// FREEBIE
8 years ago