Commit Graph

345 Commits (6e457e43ca2ed13639f27861fe65deeed06c2bb7)

Author SHA1 Message Date
Matthew Chen b3ad6e27dc Rework conversation message bubble colors; add "conversation colors" class. 7 years ago
Matthew Chen 26a2d568de Add "conversation color mode" enum. 7 years ago
Matthew Chen e5150267c2 Rework the conversation color constants. 7 years ago
Matthew Chen da63731447 Respond to CR. 7 years ago
Matthew Chen 8db4595bdc Rework group avatars to reflect conversation colors. 7 years ago
Matthew Chen 1c920c6be6 Rework group avatars to reflect conversation colors. 7 years ago
Matthew Chen 25d56b30c1 Rework group avatars to reflect conversation colors. 7 years ago
Matthew Chen 2f9eae5caf Respond to CR. 7 years ago
Michael Kirk fe7d69e9c6 Update thread's sorting order based on whatever the currently last message is 7 years ago
Michael Kirk c2f87c738a trivial replace of timestampForSorting -> sortId in some logging 7 years ago
Michael Kirk 6f8eddc955 unread indicator uses sortId
- removed timestamp parameter. This wasn't totally obvious, previously we were tracking two pieces of state

1. `unreadIndicator.firstUnseenTimestamp`:
    the first unseen timestamp for a conversation that exists in the database
2. `unreadIndicator.timestamp`:
    the timestamp of the first interaction *after* the unread indicator that fits in the loading window

We don't actually need to track `2` because it was only used in a comparison like:

   viewItem.interaction.timestampForSorting >= unreadIndicator.timestamp

But by definition, unreadIndicator.firstUnseenTimestamp is always less than or
equal to unreadIndicator.timestamp. Put into terms of the `sortId` corallary,
the sortId of the first unseen interaction in the database is always less than
or equal to the sortId of the first unseen interaction that fits in the loading
window.

In other words, there's no situation where

   viewItem.interaction.sortId >= unreadIndicator.firstUnseenSortId
7 years ago
Michael Kirk 2eb3ec6d0c benchmark migration 7 years ago
Michael Kirk c27d35f8f2 sort search results by sortId 7 years ago
Michael Kirk ab55e85304 step 1: timestampForSorting audit, change signature
No change in functionality in this commit, I just broke the signature to have a
systematic audit of the callsites. Added TODO's with the plan for each call.
7 years ago
Michael Kirk df61316495 minimize diff senderTimestamp -> timestamp 7 years ago
Michael Kirk 00d0d1e002 Remove legacy Error backdating - no changes in functionality
Historically we would backdate the SN change messages, but since adopting
non-blocking SN changes long ago, they're already sorted properly by creation
time, so backdating has been unnecessary for a while.

I also audited that all other error messages are saved directly after creation.

I applied deprecation attributes as appropriate as I audited.
7 years ago
Michael Kirk eef1368ad3 Timestamp audit step1: change signature
There is no change in functionality in this commit.

Apart from clarifying what the timestamp means (it's the timestamp of the
*sender*), this intentionally breaks all the call sites, so I could have a sane
way to thoroughly audit wherever we're passing in timestamps, to see where
we're depending on them to affect sort order.

For the sake of a cleaner diff of meaningful changes, instead of "fixing"
everything in this commit, I've just added comments and renamed signatures.
7 years ago
Michael Kirk 6c5fbc6de5 Update existing contact offers in place
WIP: migration / autoincrement logic

TODO:

-[x] contact offer
-[ ] verify all paths that utilized timestampForSorting, e.g. make sure SN appear before the message they affect, etc.
-[x] Monotonic ID
-[x] New extension which sorts by id
-[x] Migration
  -[ ] batch migration?

fixup contact offers
7 years ago
Michael Kirk a60d8eb161 WIP: migration / autoincrement logic
TODO:

-[ ] contact offer
-[ ] verify all paths that utilized timestampForSorting, e.g. make sure SN appear before the message they affect, etc.
-[x] Monotonic ID
-[x] New extension which sorts by id
-[x] Migration
  -[ ] batch migration?
7 years ago
Matthew Chen 7b2dd19fb8 Respond to CR. 7 years ago
Matthew Chen ae84528dc3 Update avatar colors; add shaded conversation color constants, modify color picker to be color-name-based, not color-based, use shaded conversation colors, remove JSQ. 7 years ago
Matthew Chen 8cf5f3e58f New grayscale palette. 7 years ago
Michael Kirk 21e67e9a1d New resolutions for call banner, rename to accommodate multiple X devices.
Only apply work-around to legacy versions where required.
7 years ago
Michael Kirk 920a82564f Merge tag '2.29.3.3' 7 years ago
Michael Kirk df67e883f3 BlockList vs. "zero length" group names 7 years ago
Michael Kirk b447e68597 clarify post-unblock-group copy 7 years ago
Michael Kirk c1b88b5f48 copy cleanup: remove redundant body 7 years ago
Michael Kirk 0f9b0936df Use cached group details when rendering blocklist 7 years ago
Michael Kirk 1f15ba6dc5 Cache group details on blocking manager
In case the group thread is later deleted.
7 years ago
Michael Kirk 7b7da4bc13 add docs to BlockListCache 7 years ago
Michael Kirk 448936d156 BlockListCache
block manager synchronizes on self for coherent read/writes to blocking state
across threads, but we want to be able to have performant reads on the main
thread.
7 years ago
Michael Kirk b6eb1476cb Leave group when blocking it 7 years ago
Michael Kirk c6de8c579c WIP: Localizations 7 years ago
Michael Kirk eadb04efcc WIP: ContactViewHelper incorporates group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] ConversationViewHelper
   -[x] Track blocked groups
   -[ ] HomeView
   -[ ] ConversationView
   -[ ] Any others?
   -[ ] Rename? Extract BlockList cache?
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[x] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
7 years ago
Michael Kirk 236c17f65e WIP: group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[ ] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
7 years ago
Matthew Chen cc117b385c Modify environment accessors to use our 'shared' convention. 7 years ago
Matthew Chen 3a12446be8 Modify environment accessors to use our 'shared' convention. 7 years ago
Matthew Chen f9eab5cd24 Merge remote-tracking branch 'origin/release/2.29.2' 7 years ago
Michael Kirk c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
7 years ago
Matthew Chen ac4365e1c9 Add OWSThumbnailService. 7 years ago
Matthew Chen 9ab4da5c81 cherry-pick Merge branch 'charlesmchen/logSdp' 7 years ago
Matthew Chen fac7f6932f Rename TSGroupMetaMessage enum values. 7 years ago
Matthew Chen f473f60111 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen cc5a480baa Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen c0d486b1f1 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 3a50377902 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 0b5b74a901 Respond to CR. 7 years ago
Matthew Chen b4539328e1 Log call session description. 7 years ago
Matthew Chen 2d06c05a4f Log call session description. 7 years ago
Matthew Chen 713606271c Rename fail macros in Obj-C. 7 years ago
Matthew Chen 5b50e81b4f Rename fail macros in Swift. 7 years ago
Matthew Chen cf6f3841a8 Apply new Swift logging. 7 years ago
Michael Kirk bc2ba63c21 DRY refactor 7 years ago
Michael Kirk 37738c24c5 Allow menuActions + callBanner
// FREEBIE
7 years ago
Michael Kirk 82e559d11b Use swift macros for main thread assert 7 years ago
Michael Kirk 1743407cc2 Code cleanup per code review 7 years ago
Michael Kirk 3022f92925 Tweak tint for search bar icons in dark theme 7 years ago
Michael Kirk e435358bfd Revert "Add custom themed search bar."
This reverts commit 8daaef22da.
7 years ago
Matthew Chen 4971d40c75 Respond to CR. 7 years ago
Matthew Chen 9e21612298 Respond to CR. 7 years ago
Matthew Chen 6dd474d794 Theme quoted replies. 7 years ago
Matthew Chen a92fca5c13 Theme quoted replies. 7 years ago
Matthew Chen 8daaef22da Add custom themed search bar. 7 years ago
Matthew Chen 4ea5d9b849 Theme review. 7 years ago
Matthew Chen a76d488e8b Fix QA issues in theme. 7 years ago
Matthew Chen 26001e49d1 Unify log tags. 7 years ago
Michael Kirk 8829cdfb4b Toast view when tapped message doesn't exist, mark remotely sourced. 7 years ago
Michael Kirk c05700fd98 Log in OWSFail
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
7 years ago
Matthew Chen 8ecf6884c5 Remove "sending" color for outgoing messages. 7 years ago
Matthew Chen 5ef0b6d056 Refine theme. 7 years ago
Michael Kirk 2ea7e2b036 CR: clean up preferences 7 years ago
Michael Kirk 0bc03b0fd4 Move seed 7 years ago
Matthew Chen 25a98554b7 Intern JSQMessagesViewController. 7 years ago
Matthew Chen 48975eaac8 Respond to CR. 7 years ago
Michael Kirk d591fb7f2c Fix some compiler warnings 7 years ago
Michael Kirk 7a5f5476db rename to avoid confusion 7 years ago
Michael Kirk 24060c17d0 CR: proper width calculation for header view 7 years ago
Michael Kirk fef6c64bdc decrease header spacing from 32->28.
Previous spacing was based on applying the "full width" gutter spacing twice.
7 years ago
Michael Kirk 1a2428a4b0 CR: leave some wiggle room on max window height. 7 years ago
Michael Kirk bdc8181cbc hide menu view controller when resigning active
// FREEBIE
7 years ago
Michael Kirk dde2fd6f33 Hide menu window when vc dismisses.
Normally this isn't possible, just being paranoid.

// FREEBIE
7 years ago
Michael Kirk 82fdd5b883 Split out generic action sheet components
Keep the message specific components separte, so we could re-use the
MenuActionsViewController.
7 years ago
Michael Kirk 3a157d9df6 window level on iOS11
// FREEBIE
7 years ago
Michael Kirk 635c0275db stop observing db notifications while message actions are presented
This let's new messages appear after the message actions are dismissed without
complicating scroll state.
7 years ago
Michael Kirk 22fada2457 don't dismiss keyboard when presenting actions 7 years ago
Michael Kirk aa98963fd9 Abandonded: separate window pattern
Hiding the old window, caused keyboard to resign first responder.
7 years ago
Michael Kirk 6037a440c9 wire up window mgmt 7 years ago
Matthew Chen 8287076499 More design tweaks. 7 years ago
Matthew Chen 0c420ed28a Tweak appearance. 7 years ago
Matthew Chen 750b935122 Tweak appearance. 7 years ago
Matthew Chen 376e2cc1db Respond to CR. 7 years ago
Matthew Chen 35f058c46a Rework unread indicators. 7 years ago
Matthew Chen ecafe546b6 Rework unread indicators. 7 years ago
Matthew Chen 8d72bb032e Rework unread indicators. 7 years ago
Matthew Chen 8b3bdb88f3 Revert "Merge branch 'charlesmchen/tweakCalls'"
This reverts commit 3e0233ea60, reversing
changes made to 74ce3012cf.
7 years ago
Michael Kirk f22cb48f85 date break font/color to spec
// FREEBIE
7 years ago
Michael Kirk 28abf426f1 White status bar for call screen
Transition to VC controlled status bar style.
7 years ago
Michael Kirk 10ac7be03a prefer localizedUppercaseString for user facing text
// FREEBIE
7 years ago
Michael Kirk 76745bee5b failed background color to spec 7 years ago
Matthew Chen b92fc89986 Retweak date and unread messages breaks. 7 years ago