Commit Graph

1383 Commits (5a0f752de7ba604562cc088773cace07c11b4d7e)

Author SHA1 Message Date
Niels Andriesse 3bd3341e64 Clean 6 years ago
Niels Andriesse ef680a1cc2 Don't ask for contacts 6 years ago
Niels Andriesse d4fd3af433 Fix Signal bug 6 years ago
Niels Andriesse 8a605858fd Clean & suppress warnings for dependencies 6 years ago
Niels Andriesse 9d64b76af6 Clean & fix bad merge 6 years ago
Mikunj 520d41565f Disable networking calls when updating profile.
Remove avatar from profile controller.
6 years ago
Michael Kirk 19002a13b1 Cannot delete last item in rail 6 years ago
Michael Kirk a1e008f930 apply new rounding/highlight design 6 years ago
Michael Kirk 4af9fa6789 "add more" as rail cell 6 years ago
Michael Kirk da79a53d96 cleanup compiler warnings 6 years ago
Michael Kirk fa45339f83 move to public category 6 years ago
Michael Kirk cfebb53719 more concise constants post translation 6 years ago
Michael Kirk 57b1aaa3dc inline enum converters 6 years ago
Michael Kirk 30266bf65e autoformatted 6 years ago
Michael Kirk 64a0c4bfaa auto-migrate to Swift5 6 years ago
Michael Kirk 501e2c761f Merge tag '2.38.1.2' 6 years ago
Michael Kirk 1fae83a777 respect any CDN headers (eg Host for front) 6 years ago
Michael Kirk 07e88009e4 Merge tag '2.38.0.11' 6 years ago
Matthew Chen a3efb58d15 Respond to CR. 6 years ago
Matthew Chen 517a550593 Further improve "first responder" behavior in the image editor. 6 years ago
Matthew Chen eb5cf3978c Fix first responder issue in image editor. 6 years ago
Michael Kirk fa2d5b422b maintain body text navigating to/from approval view 6 years ago
Michael Kirk 1a4062dd89 Nav buttons: batch, camera/library switch, done 6 years ago
Michael Kirk 7dbb9517af Centralize attachment state in nav controller 6 years ago
Michael Kirk 6502d7d4a5 remove `isMultiSendEnabled` feature flag 6 years ago
Michael Kirk 1357449dcc Make OrderedDictionary keys generic 6 years ago
Matthew Chen db958f4a01 Preserve caption text of edited images. 6 years ago
Matthew Chen d9760b6bbc Fix bug around layer ordering when rendering image editor output. 6 years ago
Matthew Chen 5973c326de Ensure new text items are on the canvas. 6 years ago
Michael Kirk f8244eeefe Fix SAE crash for iOS9 6 years ago
Michael Kirk 58d99a480f Notify iOS9 users occasionally that iOS10 will soon be required 6 years ago
Matthew Chen 3ce3f9faaa Add accessibilityIdentifiers to conversation settings view. 6 years ago
Matthew Chen f073dd9a52 Add accessibilityIdentifiers to conversation settings view. 6 years ago
Matthew Chen 4188993fc5 Add accessibilityIdentifiers to 'new contact thread' view. 6 years ago
Matthew Chen 95e125d55e Simplify usage of accessibilityIdentifiers. 6 years ago
Matthew Chen 2d854406a1 Add accessibilityIdentifiers to home view. 6 years ago
Michael Kirk ed6b461662 search icon 6 years ago
Matthew Chen a7ae79aaad Ignore keyboard notifications while the view is disappearing or has disappeared. 6 years ago
Matthew Chen 558b5f5816 Tap to dismiss caption editor. 6 years ago
Matthew Chen 4ea608cd45 Ensure status bar is hidden in image editor subviews. 6 years ago
Michael Kirk e3cc8bb101 Keep results bar visible when dismissing keyboard or returning to view. 6 years ago
Michael Kirk 3850ca29b0 Bigger hack to fix problem with lesser hack.
There were two symptoms to this bad "leave app while dismissing keyboard"
state...

The first, most noticeable symptom was that the main window no longer respected
the device orientation. This was caused by UIKit temporarily disabling
autorotate during an interactive keyboard dismissal, and not cleaning up after
itself when we hid the window mid dismissal due to our screen protection
feature. This was solved previously in: ca0a555f8

The second symptom remained, and is solved by this commit. Wherein after
getting in this bad state, the interactive keyboard dismiss function behaves
oddly. Normally when interactively dismissing the keyboard in a scroll view,
the keyboard top follows your finger, until you lift up your finger, at which
point, depending on how close you are to the bottom, the keyboard should
completely dismiss, or cancel and return to its fully popped position. In the
degraded state, the keyboard would follow your finger, but when you lifted your
finger, it would stay where your finger left it, it would not complete/cancel
the dismiss.

The solution is, instead of only re-enabling autorotate, to use a higher level
private method which is called upon complete/cancellation of the interactive
dismissal. The method, `UIScrollToDismissSupport#finishScrollViewTransition`,
as well as re-enabling autorotate, does some other work to restore the UI to
it's normal post interactive-keyboard-dismiss gesture state.

For posterity here's the decompiled pseudocode:

```
/* @class UIScrollToDismissSupport */
-(void)finishScrollViewTransition {
    *(int8_t *)&self->_scrollViewTransitionFinishing = 0x0;
    [self->_controller setInterfaceAutorotationDisabled:0x0];
    [self hideScrollViewHorizontalScrollIndicator:0x0];
    ebx = *ivar_offset(_scrollViewNotificationInfo);
    [*(self + ebx) release];
    *(self + ebx) = 0x0;
    esi = *ivar_offset(_scrollViewForTransition);
    [*(self + esi) release];
    *(self + esi) = 0x0;
    return;
}
```
6 years ago
Matthew Chen 908fe1d0c9 Apply presentAlert() throughout codebase. 6 years ago
Matthew Chen 882dd16d7c Apply presentAlert() throughout codebase. 6 years ago
Matthew Chen c9d62f47cc Respond to CR. 6 years ago
Matthew Chen 1a80f0c293 Add accessibility identifiers to privacy popups and subviews. 6 years ago
Matthew Chen cb5ce42e76 Add accessibility identifiers to privacy popups and subviews. 6 years ago
Matthew Chen f37a3059fa Add accessibility identifiers to debug log popups. 6 years ago
Matthew Chen 81508e9d02 Add accessibility identifiers to settings popups. 6 years ago
Matthew Chen d7b1e65a71 Add accessibility identifiers to blocklist popups. 6 years ago