Commit Graph

45 Commits (49839900bcfd582e27e4e271aef3a4b57f056dc8)

Author SHA1 Message Date
Niels Andriesse 476edc14f1 Remove CallKit 6 years ago
Niels Andriesse 86a9e6534e Clean 6 years ago
gmbnt f15fdcd128
Merge pull request #70 from loki-project/clear-all-data-fix
Use signal implementation of reset data
6 years ago
Mikunj 5dfefbf739 Use signal implementation of reset. 6 years ago
Niels Andriesse 823d6de2e6 Start new conversation screen redesign 6 years ago
Niels Andriesse 177b194d67 Start home screen redesign 6 years ago
Niels Andriesse aeb3cecf55 WIP 7 years ago
Matthew Chen aad5533127 Respond to CR. 7 years ago
Matthew Chen 01d9993b9d Handle notifications for open conversations. 7 years ago
Matthew Chen f3d0cd99fc Handle notifications for open conversations. 7 years ago
Michael Kirk d26c095fe7 Merge remote-tracking branch 'origin/release/2.36.0' 7 years ago
Matthew Chen f7d659bdef Clean up onboarding changes. 7 years ago
Michael Kirk cb3a36ba3d Platform specific notification clearing 7 years ago
Michael Kirk 7aad3a9e7a Avoid spurious crash reporting 7 years ago
Matthew Chen 5010b027b1 Sketch out the backup restore view. 7 years ago
Matthew Chen 0b4ed1175d Create AppEnvironment. 7 years ago
Matthew Chen d7e52367ff Create AppEnvironment. 7 years ago
Matthew Chen 3eb84ed0e0 Move message processing singletons to SSKEnvironment. 7 years ago
Matthew Chen 39f1be65f3 Respond to CR. 7 years ago
Matthew Chen 1d40cbfb41 Rework account attributes; persist manual message fetch; add "unrestricted UD" setting. 7 years ago
Matthew Chen 0125535d4d Pull out SignalCoreKit. 7 years ago
Matthew Chen b076f14964 Swift exit(). 7 years ago
Matthew Chen a7a05e9bbf Respond to CR. Rework how CallNotificationsAdapter adaptee is populated. 7 years ago
Matthew Chen e1db60c1c0 Rework creation of singletons. 7 years ago
Matthew Chen df7acfeed3 Simplify OWSPreferences access. 7 years ago
Matthew Chen 3a12446be8 Modify environment accessors to use our 'shared' convention. 7 years ago
Michael Kirk c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
7 years ago
Matthew Chen cc5a480baa Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen c0d486b1f1 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 3a50377902 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 713606271c Rename fail macros in Obj-C. 7 years ago
Michael Kirk 7e8b2e3034 Faster conversation presentation.
There are multiple places in the codebase we present a conversation.

We used to have some very conservative machinery around how this was done, for
fear of failing to present the call view controller, which would have left a
hidden call in the background. We've since addressed that concern more
thoroughly via the separate calling UIWindow.

As such, the remaining presentation machinery is overly complex and inflexible
for what we need.

Sometimes we want to animate-push the conversation. (tap on home, tap on "send message" in contact card/group members)
Sometimes we want to dismiss a modal, to reveal the conversation behind it (contact picker, group creation)
Sometimes we want to present the conversation with no animation (becoming active from a notification)

We also want to ensure that we're never pushing more than one conversation view
controller, which was previously a problem since we were "pushing" a newly
constructed VC in response to these myriad actions. It turned out there were
certain code paths that caused multiple actions to be fired in rapid succession
which pushed multiple ConversationVC's.

The built-in method: `setViewControllers:animated` easily ensures we only have
one ConversationVC on the stack, while being composable enough to faciliate the
various more efficient animations we desire.

The only thing lost with the complex methods is that the naive
`presentViewController:` can fail, e.g. if another view is already presented.
E.g. if an alert appears *just* before the user taps compose, the contact
picker will fail to present.

Since we no longer depend on this for presenting the CallViewController, this
isn't catostrophic, and in fact, arguable preferable, since we want the user to
read and dismiss any alert explicitly.

// FREEBIE
7 years ago
Matthew Chen d6cb07cc4a Respond to CR. 7 years ago
Matthew Chen 27b6a5e5bb Open message search results. 7 years ago
Matthew Chen 9936003637 Respond to CR. 8 years ago
Matthew Chen 9a4889c4fb Simplify debug notifications. 8 years ago
Matthew Chen 91d54360ba Add contact view. 8 years ago
Matthew Chen 21ab670fc9 Clean up ahead of PR. 8 years ago
Michael Kirk 319e0d808f Merge tag '2.21.0.14' into release/2.22.0 8 years ago
Michael Kirk 3aebaefc31 A lighter touch for the fix-call connect.
Though it should be fine, reloading the callUIAdapter is a bit heavy
handed. And the current implementation is prone to being broken, since
we sometimes forget not to treat callUIAdapter as a singleton.

Longer term we can find a way to either: make callUIAdapter a true
singleton or possibly make callUIAdapter a private member of something
which *is* a true singleton.

Since we only *need* it to be reloaded the one time the migration runs
(or when a user changes settings which should be rare) it makes sense to
remove it from the happy path.

// FREEBIE
8 years ago
Matthew Chen d6f4db1523 Rename TSStorageManager to OWSPrimaryStorage. 8 years ago
Matthew Chen 85686d3144 Continue TSStorageManager refactor. 8 years ago
Matthew Chen a29c4ce5d6 Pull out OWSStorage base class for TSStorageManager. 8 years ago
Matthew Chen b4e8df79da Migrate environment to SignalMessaging. 8 years ago
Matthew Chen c817aa51b3 Migrate environment to SignalMessaging. 8 years ago