Commit Graph

469 Commits (122ef91e57905c099f26f833131bc2aa73cefe0a)

Author SHA1 Message Date
Matthew Chen 64762eb427 Observe YapDatabaseModifiedExternallyNotification. 7 years ago
Matthew Chen 62cf9b1dd5 Respond to CR. 7 years ago
Matthew Chen d17ccadea2 Use AppContext to resolve share extension FIXMEs. 7 years ago
Matthew Chen e712e8bfc4 Use AppContext to resolve share extension FIXMEs. 7 years ago
Matthew Chen 4c31d99498 Respond to CR. 7 years ago
Matthew Chen ffa69b3502 Add application context class. 7 years ago
Matthew Chen 8d4e9b4565 Respond to CR. 7 years ago
Matthew Chen 779e89fe74 Clean up ahead of PR. 7 years ago
Matthew Chen 7429e1968c Clean up ahead of PR. 7 years ago
Matthew Chen edaf65223a Migrate to shared data NSUserDefaults. 7 years ago
Matthew Chen cd11ec5698 Add app group, share keychain. Take a first pass at file migration to shared data directory. 7 years ago
Michael Kirk 336aa13520 Avoid overzealous assert
// FREEBIE
7 years ago
Michael Kirk 2072359a72 add todo 7 years ago
Michael Kirk e9796600c6 disable some asserts for now
// FREEBIE
7 years ago
Michael Kirk 961727814b Move pinning certificates into App
// FREEBIE
7 years ago
Michael Kirk a11d83187b WIP: Framework-friendly - compiles but crashes on launch
// FREEBIE
7 years ago
Michael Kirk c5b0f7cd01 framework compatible CocoaLumberjack import
With previous import style, the `LOG_ASYNC_ENABLED, LOG_LEVEL_DEF`
macros were not being defined.

@import style module includes are handled differently in ObjC++, causing
problems with out millisecondTimeStamp implementation. Rather than
address that problem head on, I simple reimplemented our millisecond
timestamp method in objective-c, removing our single ObjC++ file.

// FREEBIE
7 years ago
Michael Kirk 7894a58769 FIXME: Changes to get share extension compiling
This was a slash and burn approach, and breaks existing functionality.
We need to address all of these before merging.

// FREEBIE
7 years ago
Matthew Chen 829464baaf Remove concurrency limitations from signal service. 7 years ago
Matthew Chen ba88da60ca Use dedicated db connection for recipient identities. 8 years ago
Matthew Chen 9b4ac4073f Improve robustness around unknown country codes. 8 years ago
Matthew Chen d9fcfdeeb7 Fix deadlock when responding to contacts sync messages. 8 years ago
Matthew Chen 9b197fad03 Fix deadlock when responding to contacts sync messages. 8 years ago
Matthew Chen d8ae5841d6 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen b3d17ea192 Improving handling of edge cases in conversation view. 8 years ago
Matthew Chen 45c7d80d97 Improving handling of edge cases in conversation view. 8 years ago
Matthew Chen 6d4a05bbea Improving handling of edge cases in conversation view. 8 years ago
Matthew Chen 2642f6fcea Fix group creation. 8 years ago
Matthew Chen 21e9f57cbe Imitate Android's behavior of delaying local notifications based on incoming sync messages. 8 years ago
Matthew Chen 2d8a7b03d0 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen d7b0424c75 Don't back up profile pics, attachments or gifs.
// FREEBIE
8 years ago
Matthew Chen 2f84e0c426 Fix calling; be explicit about which messages should be saved. 8 years ago
Matthew Chen 19ba564f80 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 00feb14b10 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 5eea0347b5 Rework the "update with..." methods to avoid re-saving deleted models. 8 years ago
Matthew Chen 94b59c326e Rework the "update with..." methods to avoid re-saving deleted models. 8 years ago
Matthew Chen c6160a5a1e Rework the "update with..." methods to avoid re-saving deleted models. 8 years ago
Matthew Chen 69fa80b890 Don't resurrect zombies. 8 years ago
Matthew Chen fce52841f9 Don't resurrect zombies. 8 years ago
Matthew Chen 5c90bc72df Never request contacts permission if app is in the background. 8 years ago
Matthew Chen cc0e58365e Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 0abdbffe1f Improve handling of attachment edge cases. 8 years ago
Matthew Chen bac3bd4b68 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 518f15155a Respond to CR.
// FREEBIE
8 years ago
Matthew Chen efcd42012c Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 071dbd4414 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 8b65246619 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen e1b32315de Fix assert after registration.
// FREEBIE
8 years ago
Matthew Chen 5541be784f Fix build warnings from XCode 9. 8 years ago
Matthew Chen 6e840ff956 Fix build warnings from XCode 9. 8 years ago
Matthew Chen a6bfc0a60e Fix build warnings from XCode 9. 8 years ago
Matthew Chen 2d21e2ae2c Fix build warnings from XCode 9. 8 years ago
Matthew Chen da7338580c Merge tag '2.18.1.0' 8 years ago
Michael Kirk e82a3f3ddf respond to CR
// FREEBIE
8 years ago
Michael Kirk 8ef9e96b91 Avoid group-sync deadlock by making post-upload save async
// FREEBIE
8 years ago
Michael Kirk 98fd15fae7 Avoid groupsync deadlock - pass in transaction
// FREEBIE
8 years ago
Matthew Chen 8b6265f1b5 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 4d57402367 Ensure attachments always have a valid content type.
// FREEBIE
8 years ago
Matthew Chen e07a240ee5 Merge tag '2.18.0.9' 8 years ago
Michael Kirk 81cff837ae Include root certs from pki.goog
// FREEBIE
8 years ago
Michael Kirk 6c13d46be2 use manually specified censorship host
// FREEBIE
8 years ago
Michael Kirk 11e07370a9 more logging
// FREEBIE
8 years ago
Michael Kirk a30533e7b5 Add GTSGIAG3 to censorship circumvention trust store
openssl x509 -outform der -in GIAG3.pem -out GIAG3.crt

// FREEBIE
8 years ago
Michael Kirk 295646e5fa Rebase cleanup
// FREEBIE
8 years ago
Michael Kirk 0706edf42a Generate new registrationId on re-register
In order for others to know they should start a new session with us, we
need to change our registration id.

To achieve this, I consolidated all the Account related attributes on
TSAccountManager - luckily they were already in the proper collection, I
just moved the API to hang on the AccountManager instead of a TSStorage
category extension.

Also:

@synchronize access to `registrationId`

// FREEBIE
8 years ago
Michael Kirk 58d4c95362 Re-register without losing your messages in Debug-UI
// FREEBIE
8 years ago
Matthew Chen 1fa75ead5d Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 74096fc2c2 Don't send sync messages to self if no linked devices.
// FREEBIE
8 years ago
Matthew Chen db8a381960 Merge remote-tracking branch 'origin/release/2.18.0' 8 years ago
Michael Kirk cf9874302b Remove unecessary subdata for unpadded attachment
// FREEBIE
8 years ago
Michael Kirk ce51d2da3e Example (disabled) padding strategy for attachment sender
The padding strategy the sender uses can change without needing to
update the receiver, so long as we continue to record the unpadded
length of the attachment in the attachment pointer.

// FREEBIE
8 years ago
Michael Kirk cbbb376860 Handle receiving padded attachments
Don't send padded attachments yet.

// FREEBIE
8 years ago
Michael Kirk 259695a9fd Attachments require digest or show explanatory error.
// FREEBIE
8 years ago
Michael Kirk 6eeb78157a Include size in attachment pointer
// FREEBIE
8 years ago
Matthew Chen 3927815a35 Fix tests broken by the JSQ rewrite.
// FREEBIE
8 years ago
Matthew Chen bf8d694eb4 Rework attachment approval UI.
// FREEBIE
8 years ago
Matthew Chen d04f9111db Rework attachment approval UI.
// FREEBIE
8 years ago
Michael Kirk 68e755ade9 Merge branch 'release/2.18.0' 8 years ago
Michael Kirk 0cd56d4bcc On iOS11 doc picker requires system appearance.
Otherwise nav items are illegible.

// FREEBIE
8 years ago
Matthew Chen 4dabb71815 Fix "can't send same GIF twice" issue.
// FREEBIE
8 years ago
Matthew Chen fb4d43d542 Fix "can't send same GIF twice" issue.
// FREEBIE
8 years ago
Matthew Chen e3868df69a Move write of incoming messages off main thread.
// FREEBIE
8 years ago
Matthew Chen 8704722f90 Don't start expiration of incoming messages until attachments are downloaded.
// FREEBIE
8 years ago
Matthew Chen 227fd5280d Resize conversation view cells as necessary.
// FREEBIE
8 years ago
Michael Kirk 0f859d6b20 Merge branch 'release/2.18.0' 8 years ago
Michael Kirk 3080cb512b Compose View: collation index and group search
- Include table index for contacts
- Fix extra spacing in OWS table view
- Separate search results into contact/invite sections
- Include groups in search results when composing new message
- Compose Screen search matches on group member names

// FREEBIE
8 years ago
Matthew Chen fb408f980c Remove JSQ.
// FREEBIE
8 years ago
Michael Kirk b2efb722d2 Log timestamp of sent messages
This is really helpful when cross referencing debug logs with the
recipient. (We already log timestamps on the receiving side).

// FREEBIE
8 years ago
Michael Kirk 9a7e3cb9d8 Register for manual message fetching when unable to obtain push tokens
// FREEBIE
8 years ago
Michael Kirk df15c904bc Rework push registration
== Account Registration ==

Not complete until push tokens are uploaded

== Remote Notifications Registration ==

Extracted from PushManager

- wait for notification-settings registration to complete before
  requesting push tokens, otherwise it's possible token requests will
  be ignored.

- Less state required for push notification callbacks, specifically, we
  no longer need to ensure we've created a promise before the
  registration delegate methods get called.

- no more TOCFuture in Signal-iOS (still in SSK for now). It's not in
  cases of inexplicable behavior - one a recently, push notification
  premature free, in redphone, and more popular use, and I've seen two
  futures inexplicably being nil.  Instead, let's consolidate around
  PromiseKit for popularly used, maintained, strongly-typed futures.

- separate logic for registering for vanilla push/voip notifications
  (few dependencies) from responding to UILocalNotifications (lots of
  dependencies). Ultimately I'd like to consolidate the remaining
  UILocalNotifications logic with the existing NotificationsManager

== Misc ==

more debug logging
more uniform logging
remove stale logic around newly registered user

// FREEBIE
8 years ago
Michael Kirk 703d4df9e5 Avoid phantom notifications for group info requests
// FREEBIE
8 years ago
Joshua Lund 8ff14a3f6a Enable censorship circumvention in Qatar.
// FREEBIE
8 years ago
Matthew Chen 0c46b770e9 Ignore group info requests if sender and recipient aren't both known group members.
// FREEBIE
8 years ago
Matthew Chen 13a6657991 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 2a5a0929e6 Create & access groups more carefully.
// FREEBIE
8 years ago
Matthew Chen 380ed0f82b Create & access groups more carefully.
// FREEBIE
8 years ago
Matthew Chen a31b1aeea6 Respond to "sync block list" request.
// FREEBIE
8 years ago
Michael Kirk 462a6e4456 Persist read receipts to proper collection
// FREEBIE
8 years ago
Michael Kirk 2125dbe72c CR: Avoid potential transaction nesting
also clean up description method

// FREEBIE
8 years ago
Michael Kirk 5d62741a3c Sync read receipt configuration upon set
// FREEBIE
8 years ago
Michael Kirk ab5b090338 Sync read receipt config to linked devices
// FREEBIE
8 years ago
Michael Kirk be197621ac Add read receipts field/configuration protos
Also converge with Android protos where possible

// FREEBIE
8 years ago
Michael Kirk a2421d5b3e Fix "unknown attachment" notifications
The transaction in which the attachments were created hasn't been
committed yet.

// FREEBIE
8 years ago
Matthew Chen 08e560f969 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 0a081f7dcc Use longer delay when batch processing incoming messages.
// FREEBIE
8 years ago
Matthew Chen 69c9a5a49b Use longer delay when batch processing incoming messages.
// FREEBIE
8 years ago
Matthew Chen 46d2b7a891 Refine read receipt processing cycle.
// FREEBIE
8 years ago
Matthew Chen 6b3c0377cf Refine read receipt processing cycle.
// FREEBIE
8 years ago
Matthew Chen c3dca21a69 More thread safety fixes.
// FREEBIE
8 years ago
Matthew Chen 65957c932d Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 8b15dba4e7 Fix "mark as read on linked device".
// FREEBIE
8 years ago
Matthew Chen facbc56062 Move more work off the main thread.
// FREEBIE
8 years ago
Matthew Chen 9573e0e16d Move more work off the main thread.
// FREEBIE
8 years ago
Matthew Chen 1df1144e43 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 33376f66d2 Simplify processing of messages from linked devices.
// FREEBIE
8 years ago
Matthew Chen 9b5affb390 Send silent messages where appropriate.
// FREEBIE
8 years ago
Matthew Chen d557817bb4 Format message statuses with date if possible.
// FREEBIE
8 years ago
Matthew Chen 834ad3f8e1 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 01bda556c8 Fix class rename.
// FREEBIE
8 years ago
Matthew Chen 6b8c9b6bcf Iterate the names of the incoming message queue extensions.
// FREEBIE
8 years ago
Matthew Chen eec0efa3c8 Fix class rename.
// FREEBIE
8 years ago
Matthew Chen a4d285f50d Respond to CR.
// FREEBIE
8 years ago
Matthew Chen aa7329013d Handle new-style delivery receipts.
// FREEBIE
8 years ago
Matthew Chen 25c40ea3cf Handle new-style delivery receipts.
// FREEBIE
8 years ago
Matthew Chen ee13084d5c Respond to CR.
// FREEBIE
8 years ago
Matthew Chen ffe44e68be Refactor linked device read receipts.
// FREEBIE
8 years ago
Matthew Chen 16d4256e99 Address deadlocks in profile manager.
// FREEBIE
8 years ago
Matthew Chen 19e010645e Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 9f9ac746d1 Sketch out message metadata view.
* Show message metadata view from conversation view.
* Pull out MediaMessageView class.
* Track recipient read timestamps.
* Add per-recipient status to message metadata view.
* Add share button to message metadata view.

// FREEBIE
8 years ago
Matthew Chen f001e8c225 Respond to CR.
// FREEBIE
8 years ago
Michael Kirk ce2a4422e3 fix desktop linking for some users
// FREEBIE
8 years ago
Matthew Chen b74da07f7e Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 825503210b Remove extraneous database view.
// FREEBIE
8 years ago
Matthew Chen 11cadf4200 Send, receive & show read receipts to senders/from receivers.
* Send read receipts to senders.
* Honor "send read receipts" preference.
* Process read receipts from recipients.
* Refactor "mark as read" logic.
* Serialize and apply recipient read receipts received before sync transcript.
* Show recipient read receipts in conversation view.

// FREEBIE
8 years ago
Matthew Chen f2d19ffe09 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 7268bde506 Add stress group to debug UI.
// FREEBIE
8 years ago
Matthew Chen bd416176ae Add stress group to debug UI.
// FREEBIE
8 years ago
Matthew Chen 77e0c9664c Respond to CR.
// FREEBIE
8 years ago
Matthew Chen edd63164d7 Fix build breaks.
// FREEBIE
8 years ago
Matthew Chen 874ebf7038 Use private queues in message decrypter and batch processor.
// FREEBIE
8 years ago
Matthew Chen 077b74a0aa Fix handling of edge cases around groups.
// FREEBIE
8 years ago
Matthew Chen 2b0b49b7f6 Don't batch message decryption.
// FREEBIE
8 years ago
Matthew Chen bfb03c0db4 Fix message processing edge cases.
// FREEBIE
8 years ago
Matthew Chen 35a2470cb7 Post notifications asynchronously.
// FREEBIE
8 years ago
Matthew Chen 1c8dbcd223 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 3eaeb4e0ec Add read receipts manager.
* Simplify read receipts plumbing.
* Rework incoming read receipts handling.
* Rework outgoing read receipts handling.
* Make "database view registration complete" check thread-safe.
* Don't send sync messages to self if no linked devices.

// FREEBIE
8 years ago
Matthew Chen 2cfa24ba7b Respond to CR.
// FREEBIE
8 years ago
Matthew Chen b28c4b74b2 Pull out TSMessageDecrypter class.
// FREEBIE
8 years ago
Matthew Chen f1b7d895e2 Modify precommit script to clean up includes and forward declarations.
// FREEBIE
8 years ago
Matthew Chen 993df25f3f Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 46f17a02cb DRY up decryption logic.
// FREEBIE
8 years ago
Matthew Chen e39b9169b9 Decrypt and process messages in batches.
// FREEBIE
8 years ago
Matthew Chen 9987ebb3c0 Decrypt and process messages in batches.
// FREEBIE
8 years ago
Matthew Chen 023c804a61 Decrypt and process messages in batches.
// FREEBIE
8 years ago
Matthew Chen fa353259c3 Process messages in a single transaction (wherever possible).
// FREEBIE
8 years ago
Matthew Chen 6fce2c26b7 Process messages in a single transaction (wherever possible).
// FREEBIE
8 years ago
Matthew Chen afc753e7ed Add batch message processor.
// FREEBIE
8 years ago
Matthew Chen c498e4b354 Decouple message decryption and processing.
// FREEBIE
8 years ago
Matthew Chen bfd50a9e0e Make "database view registration complete" check thread-safe.
// FREEBIE
8 years ago
Matthew Chen 8a4d67a6e4 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 183f0f1ccd Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 74b2f30523 Revert "Modify read receipt photos to support sending read receipts to both linked devices and senders."
This reverts commit 37e67179c8a8d6ebfdfa124ef0c1229f220ed11d.
8 years ago
Matthew Chen a7546aee63 Modify read receipt photos to support sending read receipts to both linked devices and senders.
// FREEBIE
8 years ago
Matthew Chen 39a961e376 Rework incoming read receipts handling.
// FREEBIE
8 years ago
Matthew Chen 737503549d Rework incoming read receipts handling.
// FREEBIE
8 years ago
Matthew Chen 2b1ea19960 Modify read receipt photos to support sending read receipts to both linked devices and senders.
// FREEBIE
8 years ago
Matthew Chen 0e7eaf7c62 Modify read receipt photos to support sending read receipts to both linked devices and senders.
// FREEBIE
8 years ago
Matthew Chen a5ece18e6c Fix build break.
// FREEBIE
8 years ago
Matthew Chen 400f536e37 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 872ce17dd6 Clean up data source temp files when complete.
// FREEBIE
8 years ago
Matthew Chen 05b1818874 Don't "scroll to bottom" when messages are sent from desktop.
// FREEBIE
8 years ago
Matthew Chen d3ad0950ba Clean up the data source class.
// FREEBIE
8 years ago
Matthew Chen 9dfebb2d4b Apply OWSFail() in more places.
// FREEBIE
8 years ago
Matthew Chen c21a7673c8 Rework preservation of attachment filenames.
// FREEBIE
8 years ago
Matthew Chen 0746b1300d Apply DataSource to message sender.
// FREEBIE
8 years ago
Matthew Chen b95b5f69de Apply DataSource to message sender.
// FREEBIE
8 years ago
Matthew Chen 20e5013aae Convert DataSource to Objective-C.
// FREEBIE
8 years ago
Matthew Chen 69816cdf0e Convert DataSource to Objective-C.
// FREEBIE
8 years ago
Michael Kirk 2eaaba9082 crashfix: on addObject, presumably it's nil.
I'm not sure how this is happening, but this will prevent the crash and
give us additional diagnostic data in the cases where it is happening.

// FREEBIE
8 years ago
Matthew Chen bb1681f965 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen cc048b3971 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen d032339472 Modify debug builds to use production service.
// FREEBIE
8 years ago
Michael Kirk 01d0117f9b provisioning cipher: Fix memory leak, handle failure
Explicitly malloc'd buffer should either be explicitly free'd or
ownership given to NSData via `freeWhenDone:YES`

Instead I opted to avoid the explict malloc altogether, and avoided some
unnecessary allocations.

Also made sure encryption failures propogate to error handler

// FREEBIE
8 years ago
Michael Kirk 1f7b6f61c6 Regression test for provisioning cipher
// FREEBIE
8 years ago
Michael Kirk bdb75fa596 infer when group has been whitelisted on linked device
// FREEBIE
8 years ago
Matthew Chen b00db33d12 Don't ignore attachments.
// FREEBIE
8 years ago
Michael Kirk 3ffb321e2a fix assert
// FREEBIE
8 years ago
Michael Kirk d71b7684a6 cleanup logging
// FREEBIE
8 years ago
Michael Kirk ec0cf36abb Don't print empty bubbles.
e.g. if we add another "invisible" flag message in the future we want to
be able to roll it out immediately.

// FREEBIE
8 years ago
Michael Kirk 69e8ca8eac Handle receiving profile key messages
(don't print empty bubble)

// FREEBIE
8 years ago
Michael Kirk 9c56660618 profile key flag and debug action
// FREEBIE
8 years ago
Michael Kirk 0feb966a1c comment cleanup / code formatting
// FREEBIE
8 years ago
Michael Kirk 6cde79c568 Assert profile key length on sending/receiving
// FREEBIE
8 years ago
Michael Kirk 6235e7fe5c Don't send profile key with every sync message since we explicitly sync
upon update/create.

Following Signal-Android's lead here.

// FREEBIE
8 years ago
Michael Kirk 526d5e33b9 Sync profile key to sibling devices when updating contact
// FREEBIE
8 years ago
Michael Kirk 46919e4702 Add own profile key to multidevice provisioning message
// FREEBIE
8 years ago
Michael Kirk 1f3d2d1ed6 Send any profile key in contact sync
// FREEBIE
8 years ago
Michael Kirk f0a57edde0 proto update: multiDevice profileKey sync
Also:

- minimize diff between Signal-Android's protos
- comment whereever we diverge from Signal-Android

// FREEBIE
8 years ago
Michael Kirk 1e51bf4899 extract event names
// FREEBIE
8 years ago
Michael Kirk 251e206b6d profiles vs. censorship circumvention
// FREEBIE
8 years ago