Commit Graph

510 Commits (0b64ecf675fda0441df5cdfe0a9bcbe9b2934bbf)

Author SHA1 Message Date
Matthew Chen 0d8cfc5403 Rename contact share class to contact. 8 years ago
Matthew Chen 796958d87f Elaborate contact conversion. 8 years ago
Matthew Chen e22e9a7842 Populate contact share protos. 8 years ago
Matthew Chen 757234d309 Populate contact share protos. 8 years ago
Matthew Chen 2a63423c3d Elaborate fake contact shares. 8 years ago
Matthew Chen 521013a674 Fix contact share property synthesis. 8 years ago
Matthew Chen 7490a55f61 Sketch out "contact share" model. 8 years ago
Matthew Chen 4b8a2fa8a3 Sketch out "contact share" model. 8 years ago
Matthew Chen 6005747856 Update protos to reflect 'share contact'. 8 years ago
Matthew Chen bb96454070 More outgoing message fixes. 8 years ago
Matthew Chen 752bca313c Fix glitches in outgoing messages. 8 years ago
Matthew Chen 8dbe4387b7 Update protos to reflect 'share contact'. 8 years ago
Matthew Chen f16e9a2920 Fix issues in outgoing messages status changes. 8 years ago
Matthew Chen 5c6f9ec088 Fix issues in outgoing messages status changes. 8 years ago
Matthew Chen 8f19622a89 Fix sync transcripts. 8 years ago
Matthew Chen 5773b45345 Respond to CR. 8 years ago
Matthew Chen c75c3d5f9e Respond to CR. 8 years ago
Matthew Chen 204d379603 Respond to CR. 8 years ago
Matthew Chen 4de4a4b229 Respond to CR. 8 years ago
Matthew Chen 40ac0daa9a Respond to CR. 8 years ago
Matthew Chen 6486b99415 Clean up ahead of PR. 8 years ago
Matthew Chen 9e6062f21c Rework outgoing message state. 8 years ago
Matthew Chen 9275c67818 Rework outgoing message state. 8 years ago
Matthew Chen 212891c50d Detect and handle corrupt database views. 8 years ago
Matthew Chen f70a45ef1b Clean up ahead of PR. 8 years ago
Matthew Chen 50a59c907d Detect and handle corrupt database views. 8 years ago
Matthew Chen d3b484482c Detect and handle corrupt database views. 8 years ago
Matthew Chen c5981b164b Notify users of corrupt messages. 8 years ago
Michael Kirk d1230abdc5 Fix type declaration
// FREEBIE
8 years ago
Michael Kirk 9c81eb44a1 Replace remaining UI usage of `interaction.description`
// FREEBIE
8 years ago
Michael Kirk 897d4a925b HomeView caches thread models
// FREEBIE
8 years ago
Michael Kirk 5f2b38c50b Introduce Thread view model
// FREEBIE
8 years ago
Michael Kirk 1fb1b5bbe2 WIP unjank home screen
verify `description` isn't used elsewhere (notifications? conversation
view?)

Probably want to remove overzealous asserts for now, but would be good
to work towards leaving them enabled.

// FREEBIE
8 years ago
Matthew Chen 7912598ccb Merge branch 'release/2.24.0' 8 years ago
Michael Kirk eec7678979 Group's meta message defaults to "Delivery"
// FREEBIE
8 years ago
Michael Kirk c88ce07f66 CR: Clean up comments, use property setter instead of ivar
// FREEBIE
8 years ago
Michael Kirk eb140a6839 Timer info messages *before* the message which changed the timer
// FREEBIE
8 years ago
Michael Kirk a9e7c5e879 Cleanup: simplify migration, remove unused code
// FREEBIE
8 years ago
Michael Kirk 754549adf1 Start timer for expiring message based on when read receipt was sent
// FREEBIE
8 years ago
Michael Kirk dfb2a034af Use explicit transactions.
- Start expiration within scope of existing transaction when we're
  already in a transaction

// FREEBIE
8 years ago
Michael Kirk b7625689cb Simplify reasoning around disappearing messages
1. Max duration between runs is now a separate timer we set up once and
   don't touch, so we can separate any potential bugs in scheduling logic.
2. When we want to "run now" we just run now, rather than going through
   the scheduler.
3. Detect if messages aren't being deleted in a timely way.

// FREEBIE
8 years ago
Michael Kirk 57ae2b173f Clarify existing functionality, but no change in behavior
rename vars
use clearer date comparison method

// FREEBIE
8 years ago
Matthew Chen 5ce39337ed Handle malformed protos. 8 years ago
Matthew Chen 9c93099515 Fix incomplete asserts. 8 years ago
Matthew Chen 829cfd0428 Reduce oversize text size. 8 years ago
Matthew Chen 45892e822b Move 'background' check in message processing logic off main thread. 8 years ago
Michael Kirk b2b70258f2 Make our protos backwards compatible with Signal-Android
Android doesn't have a flags field (yet?). We should make sure our
existing fields align with theirs.

// FREEBIE
8 years ago
Michael Kirk bd8e03fe8a Fix spurious "Group Updated" message
Regression introduced in Message factory method refactor (not in the wild).

// FREEBIE
8 years ago
Matthew Chen d95f2bdc66 Respond to CR. 8 years ago
Matthew Chen d561ba4c62 Reduce 0xdead10cc crashes. 8 years ago
Matthew Chen db6f1326bb Fix previews of oversize text messages. 8 years ago
Matthew Chen 83a470d441 Fix previews of oversize text messages. 8 years ago
Michael Kirk d94709e13f Show label when captioning limit has been reached.
// FREEBIE
8 years ago
Michael Kirk 6b6f4f9336 Limit caption length
// FREEBIE
8 years ago
Matthew Chen c269add62f Respond to CR. 8 years ago
Matthew Chen 76995e4594 Enforce quoted reply edge cases. 8 years ago
Matthew Chen 6a07599e00 Respond to CR. 8 years ago
Matthew Chen 65015e686f Tap on quoted replies. 8 years ago
Michael Kirk 81b2b57703 CR: add comments, make atomic
// FREEBIE
8 years ago
Michael Kirk 02efbd3069 Fix blip where thumbnail is initially missing from outgoing message
// FREEBIE
8 years ago
Michael Kirk 90486aa49c Inline method with one caller, fix formatting
// FREEBIE
8 years ago
Michael Kirk 8e4c6b8af6 Update protos for voice messages
// FREEBIE
8 years ago
Michael Kirk 941b7ec1bc clarify method signature
// FREEBIE
8 years ago
Michael Kirk c56e8acc51 QuotedReplyModel from SSK->SignalMessaging
// FREEBIE
8 years ago
Michael Kirk 1d4c0624be Clarify variable names
// FREEBIE
8 years ago
Michael Kirk a9459757f0 Lingering var renames QuotedReplyDraft -> QuotedReplyModel
// FREEBIE
8 years ago
Michael Kirk f1714bf252 Handle synced quotes
// FREEBIE
8 years ago
Michael Kirk 622f6bdf21 OrphanDataCleaner vs. QuotedAttachment thumbnails
// FREEBIE
8 years ago
Michael Kirk 4399967e99 Comment cleanup, remove unnecessary includes
// FREEBIE
8 years ago
Michael Kirk fa2e1ba89b Fetch thumbnail when not available locally
// FREEBIE
8 years ago
Michael Kirk 42f454b075 Generate thumbnail when quoted attachment is available locally
// FREEBIE
8 years ago
Michael Kirk 351f9ea263 Simplify attachment processor
We've accepted all attachment types for a long while now.

// FREEBIE
8 years ago
Michael Kirk 3252866727 remove unused params
// FREEBIE
8 years ago
Michael Kirk cb5d3d4f85 Use QuotedReplyModel to access attachment data
This view model loads the attachment when it's build.

// FREEBIE
8 years ago
Michael Kirk 3334f2a063 tentative proto changes
// FREEBIE
8 years ago
Michael Kirk 51a4298c14 WIP: Send attachment info in protobuf (no thumbnails yet)
// FREEBIE
8 years ago
Michael Kirk 55c6d99d98 populate draft toolbar
// FREEBIE
8 years ago
Michael Kirk 253435b27f extract QuotedReplyDraft model 8 years ago
Michael Kirk 0b8b3b4f16 WIP: towards avatar attachment streams
// FREEBIE
8 years ago
Michael Kirk 53af41fcc6 Reusable UploadOperation based on extracted OWSOperation
// FREEBIE
8 years ago
Michael Kirk 2975d4d5d2 Sync with android protos
// FREEBIE
8 years ago
Matthew Chen ca4757b8d1 Clean up ahead of PR. 8 years ago
Matthew Chen 2b3b08d7c5 Respond to CR. 8 years ago
Matthew Chen f230717b68 Modify attachment emojis. 8 years ago
Matthew Chen 30403be9ba Respond to CR. 8 years ago
Matthew Chen 5a17c5609f Quote reply to oversize text. 8 years ago
Matthew Chen 9085609087 Fix interaction initializers and tests. 8 years ago
Michael Kirk 52ea54ae64 Add thumbnail when available
MVP

- [x] populate from menu
- [x] send quoted message

TODO

- [x] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
8 years ago
Michael Kirk cfbbeca7ac WIP: QuotedMessagePreviewView
MVP

- [] populate from menu
- [] send quoted message

TODO

- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
8 years ago
Matthew Chen 2278cdd589 Modify cells to show quoted messages. 8 years ago
Matthew Chen 7cf169012c Elaborate conversation view items around quoted replies. 8 years ago
Matthew Chen c36297a9ad Elaborate 'quoted reply' variations in the Debug UI. 8 years ago
Matthew Chen 4240b517d0 Respond to CR. 8 years ago
Matthew Chen 8e4f2ca0ed Rework proto schema changes for quoted replies.
Sketch out model changes for quoted replies.

Sketch out quoted reply input preview.

Send quoted messages protos.

Update models to reflect quoted messages.

Rework interaction initializers.

Rework interaction initializers.

Add debug UI methods for generating quoted reply variations.

Add debug UI methods for generating quoted reply variations.
8 years ago
Matthew Chen 4602ad9014 Respond to CR. 8 years ago
Matthew Chen 8254052bb2 Lazy restore attachments. 8 years ago
Matthew Chen 1dced463cb Lazy restore attachments. 8 years ago
Matthew Chen b2ac8f10e2 Lazy restore attachments. 8 years ago
Matthew Chen 61dc2c0249 Add local cache of backup fragment metadata. 8 years ago
Matthew Chen e88f5643f7 Add local cache of backup fragment metadata. 8 years ago
Matthew Chen d0c691bb7f Lazy attachment restores. 8 years ago
Michael Kirk 394cc6637c Backport comments from translations
// FREEBIE
8 years ago
Matthew Chen bb596dba98 Add screen lock feature. 8 years ago
Matthew Chen cf0e6fce09 Add screen lock feature. 8 years ago
Matthew Chen b067d81017 Don't log message send errors. 8 years ago
Matthew Chen 8d689ec090 Properly cleanup content. 8 years ago
Michael Kirk 9c57a1f7e1 Don't generate thumbnail until attachment has been saved
// FREEBIE
8 years ago
Michael Kirk 2465d6df00 CR: ensure image is safe before generating thumbnail
// FREEBIE
8 years ago
Michael Kirk 32bf9d52a1 CR: Delete thumbnail with directory
// FREEBIE
8 years ago
Michael Kirk 8e9eb6d212 CR: Use a less-likely-to-collide thumbnail name for legacy attachments
If you had a legacy file foo.jpg and a file foo-thumbnail.jpg, we'd use
the foo-thumbnail.jpg as the thumbnail for foo.

This isn't a problem with modern attachments as each is in it's own
directory.

// FREEBIE
8 years ago
Michael Kirk a0bd2c2324 OrphanDataCleaner shouldn't delete active thumbnails
// FREEBIE
8 years ago
Michael Kirk 4aeff7ba67 Thumbnail generation
// FREEBIE
8 years ago
Michael Kirk 985af76d0b WIP: All Media view
TODO

- [ ] label video/gif
- [ ] reasonable load perf
- [ ] reasonable scroll perf
- [ ] select / delete
- [ ] cancel share action from media details returns signal style

NICE TO HAVE

- [ ] fancy in/out animation from All Media <-> tiles
- [ ] label video thumbnail with duration stamp
- [ ] Other perf?
- [ ] dbModified?
- [ ] select / send
- [ ] darken section header a shade once it's "active"

DONE

- [x] tap to refocus on new media
- [x] generate test data
- [x] section headers
- [x] equal spacing around cells

// FREEBIE

WIP WIP extract datasouce to GalleryViewController

- [x] swipe through is broken
- [x] present animation
- [x] dismiss animation

// FREEBIE
8 years ago
Michael Kirk e5b1c0c9b4 Fake media send
// FREEBIE
8 years ago
Michael Kirk 4ac9a1019b Media page view controller
First pass at a swipe-through media view for conversations.

Future work could include

- title label per item
  - sender name
  - date/time
- photo rail
- include caption

// FREEBIE
8 years ago
Matthew Chen 4746948dfe Respond to CR. 8 years ago
Matthew Chen b296cfb893 Sketch out incremental backup manager and settings view. 8 years ago
Matthew Chen d6f4db1523 Rename TSStorageManager to OWSPrimaryStorage. 8 years ago
Matthew Chen 2395dbf66b Fix redundant sync sends. 8 years ago
Matthew Chen 59c745756a Clean up codebase. 8 years ago
Matthew Chen c2f092018c Elaborate request factory. 8 years ago
Matthew Chen 004479a2ce Elaborate request factory. 8 years ago
Matthew Chen c17a819366 Elaborate request factory. 8 years ago
Matthew Chen b9458fffef Respond to CR. 8 years ago
Matthew Chen dcf7f550ae Fix redundant sync sends. 8 years ago
Matthew Chen b07f466e08 Fix redundant sync sends. 8 years ago
Michael Kirk 60259a8a13 Merge branch 'release/2.21.0' 8 years ago
Matthew Chen e12a1e984a Work on two-factor auth settings UI. 8 years ago
Matthew Chen 71972ebe2f Be more explicit about expire timer. 8 years ago
Matthew Chen bf48ccd4ad Merge remote-tracking branch 'origin/hotfix/2.20.1' 8 years ago
Matthew Chen 47a6d844c9 Refine handling of unsafe filename characters. 8 years ago
Matthew Chen d32e90c3d1 Fix build break. 8 years ago
Matthew Chen 59f480d5c4 Use background tasks during storage registration and disappearing message jobs. 8 years ago
Matthew Chen ad78b1ea53 Convert duplicate timestamp fail to log. 8 years ago
Michael Kirk b79244affa Don't enqueue sender read receipts from self-sent messages
These messages are always already read.

Reminder, there are two types of read receipts:

1. One informs our linked devices that we've read a message on another
device.
2. The other informs the sender that we've read their message.

This change is about the latter, we'll continue to send the former to
ourself.

The proximate cause for this change was a failing assert in
OWSMessageSender#handleSendToMyself:(TSOutgoingMessage *)outgoingMessage

The assert was failing because we were sending a message to ourself
which had no body or attachment (the sender-read receipt). Rather than
filtering them out from the message sender, we should never ask the
message sender to do nonsense work (send a senderReadReceipt to ourself)

// FREEBIE
8 years ago
Matthew Chen 10ca369da8 Respond to CR. 8 years ago
Matthew Chen 6006d22870 Improve handling of attachments with captions. 8 years ago
Matthew Chen 8576da791c Improve handling of attachments with captions. 8 years ago
Matthew Chen 96b5f22799 Improve handling of attachments with captions. 8 years ago
Matthew Chen 706006539f Improve the robustness of the migration logic. 8 years ago
Matthew Chen d91507d897 Improve the robustness of the migration logic. 8 years ago
Matthew Chen 90b8ee4849 Merge remote-tracking branch 'origin/hotfix/2.19.7' 8 years ago
Matthew Chen 77bf0b66f5 Fix attachment MIME types. 8 years ago
Matthew Chen d648a258d1 Merge branch 'hotfix/2.19.7' 8 years ago
Matthew Chen abfd333a17 Address Indic script crash. 8 years ago
Matthew Chen b7958262ba Respond to CR. 8 years ago
Matthew Chen 8930110efd Fix glitch in batch processing of incoming messages. 8 years ago
Matthew Chen 6f28c75257 Fix glitch in batch processing of incoming messages. 8 years ago
Matthew Chen 81522e4a23 Respond to CR. 8 years ago
Matthew Chen 01496b2db8 Avoid deadlocks in message sender. 8 years ago