Commit Graph

8 Commits (08ba42c5635e10205daa3930e3a8550f9048730d)

Author SHA1 Message Date
Matthew Chen 08ba42c563 Update SignalRecipient with “is WebRTC enabled” property from service.
// FREEBIE
8 years ago
Michael Kirk ebeae2608d Fix crash on messaging unregistered user
// FREEBIE
9 years ago
Michael Kirk 027fa10730 Only dispatch async at top level.
Previously each method was dispatching it's callbacks async. This is a
waste of code, processing, and makes crash logs impenetrable.

// FREEBIE
9 years ago
Michael Kirk 4ba1e86ec1 Explain send failures for text and media messages
Motivation
----------
We were often swallowing errors or yielding generic errors when it would
be better to provide specific errors.

We also didn't create an attachment when attachments failed to send,
making it impossible to show the user what was happening with an
in-progress or failed attachment.

Primary Changes
---------------
- Funnel all message sending through MessageSender, and remove message sending
  from MessagesManager.
  - Record most recent sending error so we can expose it in the UI
  - Can resend attachments.
  - Update message status for attachments, just like text messages
- Extracted UploadingService from MessagesManager
  - Saving attachment stream before uploading gives uniform API for send vs.
    resend
  - update status for downloading transcript attachments
- TSAttachments have a local id, separate from the server allocated id
  This allows us to save the attachment before the allocation request. Which is
  is good because:
  1. can show feedback to user faster.
  2. allows us to show an error when allocation fails.

Code Cleanup
------------
- Replaced a lot of global singleton access with injected dependencies to make
  for easier testing.
- Never save group meta messages. Rather than checking before (hopefully) every
  save, do it in the save method.
- Don't use callbacks for sync code.
- Handle errors on writing attachment data
- Fix old long broken tests that weren't even running. =(
- Removed dead code
- Use constants vs define
- Port flaky travis fixes from Signal-iOS

// FREEBIE
9 years ago
Michael Kirk 2dba7d141a Fix contact/group sync messages. (#32)
Initially we don't have device messages for our remote device. We need to send the empty device list to get the updated list of remote devices.

Introduced lots of dependency injection to make MessagesManager more testable.

// FREEBIE
9 years ago
Michael Kirk a99fde4d3b Device manager
// FREEBIE
9 years ago
Michael Kirk c1a0b88232 Don't crash when contact lookup is given nil contact
// FREEBIE
9 years ago
Frederic Jacobs 5d91a5bd4f Init Commit 10 years ago